Repository navigation
Conversation
…s M4 and ChannelId
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
/arsonmix-ci ui 498a60a |
Deploying arsonmix with
|
| Latest commit: |
ce673e9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9575913f.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-g-mv36-correlated-f.arsonmix.pages.dev |
… editor ACK lease
…ed ChannelId owner
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 498a60a11f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
/arsonmix-ci ui 7bf0719 |
|
@codex review Please review exact current G-MV36 HEAD |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
/arsonmix-ci ui f650659 |
|
@codex review Please review exact G-MV36 head |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
/arsonmix-ci native f650659 |
|
Cross-thread G-MV37 merge notice (20 Nov 2026): PR #834 has just MERGED on main at |
|
G-MV36 continuation / G-MV37 reconciliation: exact PR HEAD @codex review |
|
/arsonmix-ci ui 0d2268a |
|
/arsonmix-ci native 0d2268a |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Exact combined G-MV36/G-MV37 qualification update for |
|
INT-1 delivery coordination: #837 |
… touching FX code
|
/arsonmix-ci ui ce673e9 |
|
/arsonmix-ci native ce673e9 |
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
G-MV36 — one exact physical FX editor request → HWND ACK lifecycle
Starting from
main@07e5f65fbe69bcfe1c5768bf0528bfed631b2ccd, after G-MV35 and the merged N-MOD Device Apply coordinator. This is a functional FX editor reliability milestone, not a visual/layout rewrite.Changes
web/approved-native-bridge.jsfor both legacy M4 and installed ChannelId VST3/ImmerSIB. Every physical native editor click gets a uniquefx-editor-NrequestId, with one pending HWND feedback lease. Old pending feedback is expired on device lifecycle change or after eight seconds. First matching ACK wins; unsolicited/replayed ACK is ignored, never used to mutate accepted PCM.editorNavigationLeaseMatchesrule checks the exact installed ChannelId, FX catalog/instance/slot, device epoch/hardware fingerprint and accepted graph/roster revision. M4 keeps its G-MV35 exact hosted editor guard and now uses the same native feedback adapter.nativeEditorDispatchPlanandnativeEditorAckResultreuse existing G-MV31/G-MV35 leases, validate accepted hardware owner before processing any ACK, and match both requestId and instanceId. A later producer snapshot retires stale pending editor feedback even without a native reply; the existing native JUCE processor lease still owns the HWND.src/Main.cpp: echo the editorrequestIdinarMixRoutingFxEditorAckalongside the existing instanceId; DSP/PCM/plugin processing and action names remain identical.emitNoticeremains its own error/notification source. No optimistic "Effect settings updated" claim on HWND success.Scope and non-goals
Exactly five files:
web/approved-fx-rack-view-model.js,web/approved-native-bridge.js,src/Main.cpp,tests/approved_native_m2_contract.test.cjs,tests/imersip_p92_catalog_contract_test.py(existing source-contract update). No new JS controller or PCM accepted source, no extra audio callback, no N-MOD/IO-2C/IO-3A logic, no .smix persisted schema, no FX DSP rewrite, no CSS/images/geometry or second preview. Existing one approved/preview/, M4, ChannelId and .smix logical use distinct intended native editor pathways.Qualification in progress
Fast UI and Fast Native; exact-head full Chromium /preview/ 109-step suite; Codex exact-HEAD code review, Required CI Merge Gate and final conflict/revision check before protected squash merge. Physical Windows/dual-ASIO FAT and installer release are not part of this source milestone.
CI feedback reconciliation
Initial Fast Native and P9 source tests failed on stale assertions from pre-G-MV36 inline editor dispatch and previously adjacent accepted Global FX sync; the old-HEAD Codex P2 review correctly identified both. Both tests were updated to validate the same native owner and readback through the new pure VM and single IPC adapter, without relaxing runtime safety. Latest exact head:
f6506598e6c9dd2da16610eb9a8f59cf06ab9aeb. Added fail-closed offline .smix owner switch admission to the pure ChannelId editor plan, deferred dispatch, and native feedback, plus deterministic tests. Fast UI / Fast Native / Fast P9 / Windows-owned-FX are now PASS at exact HEAD. The previous P2 source-contract review was resolved; new Codex exact-HEAD review COMPLETED zero findings and zero unresolved. Full Chromium 109-step run is in progress; protected merge gate is temporarily failureuiFull: missing/duplicate jobwhile manual UI run remains unfinished (tracked publisher issue #823), not a bypass. Complete the exact-HEAD full UI and refresh the publisher only via a legitimate successful Fast UI job rerun before merging.