Skip to content

refactor(gui G-MV36): correlate FX editor requests, installed leases and native HWND ACK - #832

Open
masarray wants to merge 13 commits into
mainfrom
refactor/g-mv36-correlated-fx-editor-lifecycle-20261120
Open

masarray wants to merge 13 commits into
mainfrom
refactor/g-mv36-correlated-fx-editor-lifecycle-20261120

Conversation

@masarray

@masarray masarray commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

G-MV36 — one exact physical FX editor request → HWND ACK lifecycle

Starting from main@07e5f65fbe69bcfe1c5768bf0528bfed631b2ccd, after G-MV35 and the merged N-MOD Device Apply coordinator. This is a functional FX editor reliability milestone, not a visual/layout rewrite.

Changes

  • Single routed FX-editor IPC in web/approved-native-bridge.js for both legacy M4 and installed ChannelId VST3/ImmerSIB. Every physical native editor click gets a unique fx-editor-N requestId, with one pending HWND feedback lease. Old pending feedback is expired on device lifecycle change or after eight seconds. First matching ACK wins; unsolicited/replayed ACK is ignored, never used to mutate accepted PCM.
  • ChannelId editor last-moment admission: both at click time and immediately before deferred dispatch the same pure editorNavigationLeaseMatches rule checks the exact installed ChannelId, FX catalog/instance/slot, device epoch/hardware fingerprint and accepted graph/roster revision. M4 keeps its G-MV35 exact hosted editor guard and now uses the same native feedback adapter.
  • One pure FX Rack ViewModel policy: nativeEditorDispatchPlan and nativeEditorAckResult reuse existing G-MV31/G-MV35 leases, validate accepted hardware owner before processing any ACK, and match both requestId and instanceId. A later producer snapshot retires stale pending editor feedback even without a native reply; the existing native JUCE processor lease still owns the HWND.
  • Tiny JUCE GUI-host protocol completion in src/Main.cpp: echo the editor requestId in arMixRoutingFxEditorAck alongside the existing instanceId; DSP/PCM/plugin processing and action names remain identical.
  • Avoid duplicate UI rejection toasts from the same editor ACK, since the existing JUCE native emitNotice remains its own error/notification source. No optimistic "Effect settings updated" claim on HWND success.
  • Extend contract tests for multiple clicks, stale request replay, M4 vs ChannelId, changed pin with same epoch, edited catalog/FX instance, retained/roster/graph revision changes, and real Main.cpp ACK echo.

Scope and non-goals

Exactly five files: web/approved-fx-rack-view-model.js, web/approved-native-bridge.js, src/Main.cpp, tests/approved_native_m2_contract.test.cjs, tests/imersip_p92_catalog_contract_test.py (existing source-contract update). No new JS controller or PCM accepted source, no extra audio callback, no N-MOD/IO-2C/IO-3A logic, no .smix persisted schema, no FX DSP rewrite, no CSS/images/geometry or second preview. Existing one approved /preview/, M4, ChannelId and .smix logical use distinct intended native editor pathways.

Qualification in progress

Fast UI and Fast Native; exact-head full Chromium /preview/ 109-step suite; Codex exact-HEAD code review, Required CI Merge Gate and final conflict/revision check before protected squash merge. Physical Windows/dual-ASIO FAT and installer release are not part of this source milestone.

CI feedback reconciliation

Initial Fast Native and P9 source tests failed on stale assertions from pre-G-MV36 inline editor dispatch and previously adjacent accepted Global FX sync; the old-HEAD Codex P2 review correctly identified both. Both tests were updated to validate the same native owner and readback through the new pure VM and single IPC adapter, without relaxing runtime safety. Latest exact head: f6506598e6c9dd2da16610eb9a8f59cf06ab9aeb. Added fail-closed offline .smix owner switch admission to the pure ChannelId editor plan, deferred dispatch, and native feedback, plus deterministic tests. Fast UI / Fast Native / Fast P9 / Windows-owned-FX are now PASS at exact HEAD. The previous P2 source-contract review was resolved; new Codex exact-HEAD review COMPLETED zero findings and zero unresolved. Full Chromium 109-step run is in progress; protected merge gate is temporarily failure uiFull: missing/duplicate job while manual UI run remains unfinished (tracked publisher issue #823), not a bypass. Complete the exact-HEAD full UI and refresh the publisher only via a legitimate successful Fast UI job rerun before merging.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T04:17:29.870583Z ce673e9 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 498a60a

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: ce673e9
Status: ✅  Deploy successful!
Preview URL: https://9575913f.arsonmix.pages.dev
Branch Preview URL: https://refactor-g-mv36-correlated-f.arsonmix.pages.dev

View logs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 498a60a11f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/approved-native-bridge.js Resolved

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 7bf0719

Copy link
Copy Markdown
Owner Author

@codex review

Please review exact current G-MV36 HEAD 7bf0719028fba5346d94b85e1366932fe67aad74, including the updated Global FX and ImmerSIB contracts and physical editor request/ACK lifecycle; earlier P2 finding was fixed and resolved.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 7bf0719028

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui f650659

Copy link
Copy Markdown
Owner Author

@codex review

Please review exact G-MV36 head f6506598e6c9dd2da16610eb9a8f59cf06ab9aeb. Latest change fences editor requests/ACK when the GUI switches to an offline .smix workspace between click, queued dispatch and producer readback. All earlier P2 assertions were corrected.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: f6506598e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native f650659

Copy link
Copy Markdown
Owner Author

Cross-thread G-MV37 merge notice (20 Nov 2026): PR #834 has just MERGED on main at 55f79ec90447a1b4972954237975592b4f24b9d2 (source-qualified Chromium 109/109, Fast UI/Native PASS; three files: Channel Strip VM, bridge M/ST handler, M2 tests). Your open G-MV36 PR #832 started on main 07e5f65...; before protected merge, re-evaluate exact head against main@55f79ec90447a1b4972954237975592b4f24b9d2 and reconcile the separate native bridge/M2 test hunks to avoid unintentionally regressing the M/ST one-owner policy. No G-MV36 FX Editor scope has been modified by G-MV37. Do not force-merge or assume the old base is current; rerun required exact-head checks if you update the branch.

Copy link
Copy Markdown
Owner Author

G-MV36 continuation / G-MV37 reconciliation: exact PR HEAD 0d2268a03f4006520ea778752cff8606c9c1ec70 is now a two-parent merge of original FX-editor HEAD f6506598e6c9dd2da16610eb9a8f59cf06ab9aeb with merged main@55f79ec90447a1b4972954237975592b4f24b9d2 (#834). All 7 bridge + 4 M2-test FX-editor patch hunks applied uniquely over the newer M/ST implementation, and the exact compare against current main shows ONLY the original five G-MV36 files. No C++ DSP/PCM/IO-2D/IO-3 or N-MOD change added beyond the existing 3 requestId echo lines. GitHub now reports mergeable=true, behind=0. New exact-head Fast UI/Native/P9/owned-FX checks are underway. Previous old-head full UI/native/review evidence is NOT counted for the combined HEAD. Do not merge until new full UI, Windows native, exact-head review and required CI gate succeed; physical hardware ASIO FAT remains PENDING.

@codex review
Please inspect exact merged HEAD against latest main, especially G-MV37 M/ST dispatch preservation, editor request/ACK/replay/timeout and offline owner fencing; do not reuse the old-head review verdict.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 0d2268a

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 0d2268a

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 0d2268a03f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

Exact combined G-MV36/G-MV37 qualification update for 0d2268a03f4006520ea778752cff8606c9c1ec70: full Chromium /preview/ #44665075155 SUCCESS; Fast UI/Native, focused Windows native FX HWND and P9 scoped checks PASS; exact-head Codex review clean. Required Merge Gate publisher #44666916164 has reconciled the exact SHA correctly and says uiFull: passed, nativeFull: running; no waiver, no redundant paid build. Windows MSVC/CTest #44665114543 remains IN PROGRESS. Parent #832 must not merge until native CTest and Required Merge Gate are successful. Follow-up G-MV38 #836 is stacked and has already passed exact-HEAD Fast UI/Native and its fixed Codex review; it cannot be promoted ahead of this gate. Physical ASIO hardware FAT still pending.

Copy link
Copy Markdown
Owner Author

INT-1 delivery coordination: #837
Please treat completion of G-MV36 as a near-term user-testable Windows integration prerequisite, not a launch point for another editor micro-PR series. Refresh current main, #832 HEAD and required checks; at last audit, exact-head Windows MSVC/CTest, Chromium and Codex had passed but PR was still OPEN. Verify full Required Merge Gate and review resolution, then protected squash merge only when actually green. Preserve G-MV37 M/ST changes and accepted /preview/ browser/native parity. Immediately hand off merged commit to stacked G-MV38 #836. Post short receipt: HEAD / main SHA / gate / merged SHA / practical UX effect. Avoid duplicate CI runs.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui ce673e9

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native ce673e9

Copy link
Copy Markdown
Owner Author

@codex review
INT-1 source-complete review for exact G-MV36 HEAD ce673e9b48a71591a5f42e837093efa4946c355b. Only change since previous zero-finding FX editor review is a two-parent merge of the latest main@f509028f AGENTS.md INT-1 coordination note, without changes to reviewed FX source/PCM logic. Please inspect requestId/ACK readback lifecycle and main provenance, especially any unintended protected branch-content loss. Fast UI/native PASS, full UI/Windows CI in progress.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: ce673e9b48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant