Skip to content

feat(native FX): Graphic EQ 31 with dbx frequencies and supplied SVG faders - #835

Draft
masarray wants to merge 43 commits into
mainfrom
feat/graphic-eq31-native-fx
Draft

masarray wants to merge 43 commits into
mainfrom
feat/graphic-eq31-native-fx

Conversation

@masarray

@masarray masarray commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

Graphic EQ 31 — native built-in FX / ArSonMix (UX revised 20 Nov 2026)

Scope

  • Native built-in insert in existing ArSonMix FX Rack and mixer-owned JUCE editor. Stable ID armix.builtin.graphic-eq31.v1; no standalone plugin, second WebView, additional render graph or FX host.
  • 31 fixed dbx/ISO 1/3-octave nominal centres, 20 Hz–20 kHz, ±12 dB, linked stereo, fixed Q and smooth coefficient transitions.
  • Owner's byte-exact original assets/fx/graphic-eq31/slider_eq_grp.svg remains source artwork, with Track, Text, THUMB groups. Per-band frequency labels and SVG vector thumb movement are parameter-driven.
  • Visual correction: no gain knob, no input/output gain controls or hidden gain DSP. Original SVG raster _Image3 added a repeated dark rectangular shadow; exclude that bitmap group only from the UI clone, leaving the original source unchanged and the authored vector THUMB intact. Do not replace the track/thumb with generic JUCE controls.
  • Readable 50px fader pitch (31×50=1550px), original SVG horizontally cropped in the UI clone (60 0 352 2042) to remove empty margins while preserving track geometry. Native editor defaults to 1610×391, width-resizable 850–1900, LOW/MID/HIGH scroll for narrow windows, Inter font for labels and controls. Hide repetitive per-band Hz subgroups on the UI clone.
  • Flat/Smile convenience buttons and post-EQ clip readback; owner FX Rack maintains insert power/bypass.
  • GEQ1 v3 binary state (132 bytes): 31 bands only. Strictly validate and migrate historical v1 140-byte and v2 136-byte states, discarding former input/output trims rather than silently applying hidden gain.

Verification / release boundary

  • Source-artwork + no-shadow/no-knob/50px + state migration regression contracts included.
  • Windows native exact-SHA qualification requested for 40016cfc6b1bc077c7956831ee7acfba22fc0d54. Check CI and result before merge; don't confuse unrelated green jobs with real MSVC/CTest.
  • A source-derived Chromium screenshot/HTML was visually inspected (31 SVG controls; no duplicated bitmap shadows; Flat/Smile interactive). Not a running Windows/JUCE screenshot or physical ASIO FAT.
  • Physical FAT still required: ASIO audible response, editor open/reopen, slider independence, Flat/Smile, no gain regressions, clipping, no XRUN, and .smix restore.
  • Keep draft/unmerged until exact-SHA native tests and protected gate pass; cross-thread integration via issue [INT-1][DELIVERY] One testable Windows Integration Preview — G-MV + N-MOD + I/O + Graphic EQ #837 / G-MV / N-MOD retains one approved /preview/ mixer.

See docs/fx/GRAPHIC_EQ31_NATIVE.md and current AGENTS.md for contract.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native d7e5eaa

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 40016cf
Status: ✅  Deploy successful!
Preview URL: https://8edcdef9.arsonmix.pages.dev
Branch Preview URL: https://feat-graphic-eq31-native-fx.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native baa591b

Copy link
Copy Markdown
Owner Author

Cross-thread audit — owner's clarified Graphic EQ 31 requirements (2026-11-20)

Confirmed the requested implementation is ArSonMix native built-in FX, never a standalone/VST3. Current PR HEAD baa591b4ba3f459af25c4b87a1c74caccabcca4e contains the 31 dbx/ISO nominal centre frequencies, ±12 dB faders, embedded converted slider SVG, JUCE editor, native FX registry, stereo biquad core and targeted tests.

Validation note: The exact-head automated runs presently reported success for UI smoke and targeted built-in FX Windows preset tests. The combined status endpoint still reports ArSonMix / Required CI Merge Gate as pending, and the PR reports Cloudflare Pages deploy failed. Do not treat green unrelated/targeted jobs as final full Windows-native integration qualification. Verify the GraphicEq31FrequencyResponseAndRealtimeStability executable is actually invoked in an exact-HEAD Windows native run and reconcile the required gate before merge.

Acceptance FAT on user's Windows/ASIO: add via built-in FX picker; open/reopen modeless editor; move 31 faders independently; confirm frequency-centre response and non-NaN output across supported sample rates; verify mono/stereo source behavior in existing rack; power/bypass; save/reload .smix; avoid XRUN on automation; confirm clipping/headroom and no audio callback allocation. Preserve current G-MV/N-MOD editor dispatch ownership and avoid another FX surface. No merge/release claim until those gates are met.

Copy link
Copy Markdown
Owner Author

Cross-thread G-MV reconciliation: G-MV36 #832 exact merged candidate 0d2268a retains one correlated JUCE editor HWND and is awaiting full Windows native gate. G-MV38 #836 stacked at 83cecbbaa6 centralizes five existing browser-specific built-in editor IDs in pure FX Rack VM, while all other installed FX (including armix.builtin.graphic-eq31.v1) fall back to the existing JUCE native HWND dispatch. Your Graphic EQ 31 addition to web/approved-native-bridge.js only touches nativeBuiltins[] catalog metadata and does not overlap either editor routing hunk, so it should remain compatible. On retarget/merge, please re-evaluate on current main, preserve both the built-in catalog and the new editorSurfacePlan dispatch; do not add a second browser editor path or independent FX host. This is a coordination notice, not a claim that #835 hardware FAT/Windows CTest is complete.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native dcda95d

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 615e80d

Copy link
Copy Markdown
Owner Author

GEQ31 follow-up — real code fixes + source-derived GUI preview (615e80d)

New commits on this same PR branch, avoiding a second FX host/editor:

  • f4e4aa7 — 29 DSP test assertions rewritten as fail-closed GEQ_CHECK; in Release (NDEBUG), previously all side-effecting assert expressions could be compiled away, making a false-green test.
  • dcda95d — default JUCE editor width 1500→1280; resizable 1070–1700px with 31 independently reflowed frequency bands.
  • d50653c — moving silver thumb geometry follows each fader width, avoiding neighboring control overlap at compact widths.
  • 615e80d — contract docs updated.

A local 1366×430 source-derived Chromium preview was rendered from the owner's uploaded slider SVG, stripped to track-only, with 31 dynamic thumbs for visual review. This is not a live JUCE screenshot or audio FAT. The image is delivered directly in the user conversation, not a competing mixer or shipped UI.

Native exact-head CI was requested with /arsonmix-ci native 615e80df1a2a878aeef4c0dbdb14f7ec92a36575. The earlier native attempt for baa591b failed before native compilation in an unrelated Windows PowerShell FAT collector test (spawnSync powershell.exe ETIMEDOUT, 30s timeout); avoid attributing that failure to GEQ DSP without evidence. Required merge gate remains pending until exact-head MSVC/CTest finishes. Keep draft/unmerged for Windows ASIO FAT.

Additional gap found: BuiltInFxAcceptedSnapshot.h / BuiltInFxUserPresetStore.h still allowlist only the four legacy effect families. Thus portable user-defined .armixfx presets for GEQ31 are not wired, although .smix insert state and the Flat/Smile buttons are separate and already supported. Do not claim generic portable FX preset support for GEQ31 until explicit schema/readback/recall integration tests are implemented.

Cross-thread: retain one JUCE editor HWND through G-MV36/#832 and G-MV38/#836, and no GUI authority migration from current approved FX Rack.

Copy link
Copy Markdown
Owner Author

INT-1 Graphic EQ 31 integration: #837
Deliver one native built-in FX users can insert and actually audition; avoid another mock/surface. Current #835 was a draft and HEAD has moved since initial audit, so inspect fresh SHA, native Windows MSVC/CTest, realtime/response tests, CPU/XRUN and review before promotion. Reconcile native/editor catalog and supplied dbx 31-frequency SVG UI with G-MV38 #836's single editor policy; no parallel browser FX dispatcher. Verify bypass, slider params, native editor open/reopen and .smix save/recall, exactly one FX processing instance. If qualified in time, include INT-1 first integrated alpha; otherwise clearly scope first alpha without it rather than block indefinitely. Hardware audible validation remains independent; receipt exact SHA and gates to #837.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 48e8eec

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 12bde7f

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 449000b

Copy link
Copy Markdown
Owner Author

Owner SVG redesign — code and visual review checkpoint (449000b)

Owner feedback: previous GEQ31 editor rejected because it replaced the authored SVG slider with a hand-painted JUCE thumb. Corrected in this PR.

  • Exact uploaded slider_eq_grp.svg (33,354 bytes, SHA256 aeaf02b8904a667724f34774a692da39a5a466bae302611f347fae4d9fd14dba) committed as assets/fx/graphic-eq31/slider_eq_grp.svg, with Track, Text, THUMB groups and embedded raster/vector THUMB intact. GitHub content re-fetched and confirmed byte-equal to the attachment.
  • Obsolete slider_eq_vector.svgz removed. CMake now embeds the owner's original as BinaryData::slider_eq_grp_svg; .gitattributes preserves exact bytes on Windows.
  • JUCE editor reworked to light/silver equalizer-interface.svg reference styling, 1280×470 resizable window, 31 80px original-artwork faders in a horizontal viewport, LOW/MID/HIGH navigation, original frequency text, native APVTS attachments, Flat/Smile, trims and peak meter.
  • Perf fix: parse source once per band at first draw; obtain Drawable children Slider_EQ/THUMB using JUCE 8 component IDs, and update the original THUMB with affine translation on parameter change. No XML parsing or embedded PNG decode during every drag, and never hand-paint a substitute fader.
  • Python CTest GraphicEq31OriginalSvgLayersAndDynamicThumb checks the exact source asset SHA256, named layers, embedded PNG, native bindings and CMake owner.
  • Independent Chromium design proof rendered 31 original SVGs at real viewport sizes; confirmed input drag moves only original THUMB and updates text, LOW/MID/HIGH expose all 31 bands, Flat resets thumbs. User-visible PNG + interactive HTML delivered in conversation. This is NOT a native JUCE screenshot/audio FAT.

Release gate: Exact SHA native Windows CMake/MSVC/CTest still must pass, followed by owner's hardware ASIO audio/UI FAT and cross-thread G-MV/N-MOD reconciliation. Keep PR draft/unmerged until qualified. CI dispatched for 449000bc124c087463615a37d49647f7e92b6915.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native e333280

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 40016cf

Copy link
Copy Markdown
Owner Author

Visual-defect closure: original SVG faders, readable pitch, no shadow, no gain knob

Root cause found by inspecting the owner's actual slider_eq_grp.svg: THUMB has (1) a raster use id="_Image3" carrying a large dark shadow and (2) the real vector thumb. Previous UI rendered both across 31 faders, creating repeated vertical shadow blocks. The 37px cells also compressed track/thumb labels beyond comfortable visual recognition.

Code committed (current exact head 40016cfc6b1bc077c7956831ee7acfba22fc0d54):

  • Native GraphicEq31Editor: 50px band pitch (31×50=1550px), shared neutral panel, horizontal scrolling on narrow windows, source viewBox cropped for true track visibility, Inter frequency labels.
  • Original slider_eq_grp.svg remains byte-for-byte unchanged. On the UI XML clone only, remove raster shadow wrapper _Image3, preserve the original vector THUMB and Track, hide redundant repeated Hz subgroup, move actual thumb independently.
  • No knob UI and no input/output trim DSP. Remove unused KNOB-EQ.svg from BinaryData (original source preserved in repo). GEQ1 v3 band-only state (132 bytes) with full validation/migration from v1/v2 saved states.
  • Existing FX Rack/ChannelId authority and one JUCE editor preserved. No new WebView, plugin format or render graph.

Visual verification: local Chromium rendered all 31 SVG faders, no _Image3 nodes/bitmap uses, 50px pitch, Flat returned all bands to 0, and Smile changed band values. This is a browser visual preview only, not a running JUCE/Windows screenshot, ASIO FAT or release artifact.

CI: exact-head /arsonmix-ci native 40016cfc6b1bc077c7956831ee7acfba22fc0d54 requested; full MSVC/CTest & required merge gate must finish before merging. Historical previous exact-SHA Windows CI (e333280) failed because generated BinaryData::KNOB_EQ_svg symbol did not exist; the obsolete knob reference has now been removed entirely, with source-level regression against return. Keep PR #835 draft until real tests/owner visual review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant