Skip to content

refactor(gui G-MV38): single allowlisted FX editor surface policy for /preview/ - #836

Open
masarray wants to merge 17 commits into
mainfrom
refactor/g-mv38-editor-surface-single-policy-20261120
Open

masarray wants to merge 17 commits into
mainfrom
refactor/g-mv38-editor-surface-single-policy-20261120

Conversation

@masarray

@masarray masarray commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

INT-1A — integrated G-MV36 + G-MV38 native FX editor lifecycle / MVVM on current N-MOD main

This existing PR #836 now carries both GUI workstreams in one protected source qualification rather than incurring two full Windows builds every time independently merged main advances. No new micro-PR was opened.

Integrated exact HEAD: 3bc60cebf5a4d94e310285f9f07e89a441caeb4a; second parent is main@c04ed7bcdd8b352b8905cb7d3d1fc9d99a9d6d5a (merged N-MOD #833). G-MV source parents: #832 ce673e9 + previously reviewed #836 fc5450b. All source hunks applied uniquely; HEAD is behind=0, and diff from main has exactly six files.

User-visible functionality

  • Correlated physical JUCE VST3/ImmerSIB editor requests, exact instanceId/requestId, accepted device/graph/roster/slot lease, stale ACK/readback/owner retirement, one native HWND; error handling never invents an FX settings toast.
  • One pure G-MV38 FX Editor Surface Plan selects five approved /preview/ built-in browser editors, existing offline logical vendor editor, and original native JUCE hosted editor for other installed VST3/future Graphic EQ effects. No second render/UI owner; safe catalog allowlist.
  • Preserves G-MV37 one-owner M/ST policy, existing GAIN/WIRE/SOF, and merged N-MOD refactor(native M2): single-owner .smix SAVE/OPEN admission and negative regression matrix #833 .smix SAVE/OPEN/recovery; JUCE Main.cpp holds both the N-MOD optional-editor .has_value() fix and the G-MV36 requestId ACK echo.
  • Single approved /preview/ and exactly the same JUCE WebView2-assembled GUI, one accepted PCM render graph and primary direct ASIO owner.

Files (exact main diff)

src/Main.cpp, web/approved-native-bridge.js, web/approved-fx-rack-view-model.js, tests/approved_native_m2_contract.test.cjs, tests/imersip_p92_catalog_contract_test.py, tests/native_harmony_assembly_test.py.

Gate / release boundary

Fast UI/Native/P9/FX source checks → ONE full Chromium UI + ONE Windows FAT (MSVC/CTest/verified portable + Inno installer) for exact 3bc60cebf5a4d94e310285f9f07e89a441caeb4a, following repository smart CI runbook. Codex exact-HEAD review, Required CI Merge Gate, no force merge. The earlier #832 full Chromium/Windows source ce673e9 were SUCCESS but cannot authorize this changed combined SHA; they are historical evidence only. No current installer or physical ASIO/dual-vendor FAT is claimed at this point.

When this integrated PR merges under all protected gates, close parent #832 as fully absorbed/superseded by #836, not falsely marked MERGED. This avoids duplicate native compilation without losing a single fix.

Explicitly excluded unsafe/unaccepted work

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T04:51:45.332594Z 3bc60ce Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

@codex review
Please review exact G-MV38 head 409382b934c61b64750944982f8028291742207c against stacked G-MV36 #832. In particular check whether the strict editor-surface registry preserves all existing native built-in WebView editors, offline .smix logical vendor, new native JUCE built-in fallback and real VST3/ImmerSIB HWND; verify its fail-closed behavior on stale editorNavigationLeaseMatches, spoofed catalog and missing WebView owner. The PR will be retargeted to main only after #832 merges.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3bc60ce
Status: ✅  Deploy successful!
Preview URL: https://b3641820.arsonmix.pages.dev
Branch Preview URL: https://refactor-g-mv38-editor-surfa.arsonmix.pages.dev

View logs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 409382b934

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/approved-native-bridge.js Resolved

Copy link
Copy Markdown
Owner Author

@codex review
Please review exact newer G-MV38 head 83cecbbaa68196421b9b75be96cf6f2f4270f3bd; previous P2 finding on obsolete inline editor assertions was fixed. Fast UI and Fast Native source contracts PASS on this commit; verify allowlisted editor surface, offline .smix behavior, native JUCE HWND fallback and tests.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 83cecbbaa6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

G-MV38 exact-head qualification checkpoint (commit 83cecbbaa68196421b9b75be96cf6f2f4270f3bd): Fast UI #44666414499 SUCCESS, Fast Native #44666414550 SUCCESS, scoped harmony SUCCESS, newest exact-head Codex review no major findings. Prior P2 source-assertion mismatch is fixed; thread resolved. Diff against parent #832 is exactly four GUI/contract files, no JUCE/C++/ASIO changes.

CI dispatcher only authorizes expensive exact-SHA milestone when PR's base is main (scripts/chat_ci_dispatch.mjs). This PR is deliberately stacked on #832, whose full Chromium is SUCCESS but Windows nativeFull is still running. Do not bypass the protection by dispatching G-MV38 Chromium from this stacked base. Once #832 is merged after the full native gate, retarget G-MV38 onto new main, reconcile code as needed and run its single full Chromium qualification, protected Required Merge Gate, then merge if clean. No physical ASIO FAT or installer claim.

Copy link
Copy Markdown
Owner Author

INT-1 GUI dependency: #837
This is stacked on G-MV36 #832. Once #832 is legitimately merged, retarget/reconcile ONLY G-MV38's editor-surface policy onto fresh main, with original G-MV37 M/ST and M4 editor lease intact. Verify one /preview/ and native WebView2 FX editor dispatch, including native-hosted future Graphic EQ 31 (#835), no second browser catalog/IPC owner, and fail-closed stale instance behavior. Exact-head Fast UI + complete Chromium + relevant Windows/owned-FX CI + Codex + protected gate before merge. Send the integration issue a precise merged SHA / blocker receipt; do not claim standalone screenshot tests are hardware FAT.

Copy link
Copy Markdown
Owner Author

@codex review
INT-1 exact-head review on G-MV38 fc5450b5125d3bf5c3cacc7a1e677a358013cb19: reconciled two-parent merge of current G-MV36 #832 ce673e9b48a71591a5f42e837093efa4946c355b and existing reviewed G-MV38 83cecbbaa68196421b9b75be96cf6f2f4270f3bd. Diff against #832 remains EXACTLY four expected GUI/contract files; AGENTS/INT-1 now matches main, no N-MOD, I/O or Graphic EQ file changes. Review exact editorSurfacePlan lease, offline .smix, VST3/ImmerSIB/unknown built-in native HWND fallback, and preview/WebView2 consistency. Parent #832's full native CI is still running; do not mistake new quick contracts for full qualification.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: fc5450b512

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

INT-1 G-MV38 exact-head integration receipt: fc5450b5125d3bf5c3cacc7a1e677a358013cb19 (parents 83cecbbaa68196421b9b75be96cf6f2f4270f3bd + G-MV36 ce673e9b48a71591a5f42e837093efa4946c355b). Changed relative to current parent #832: only four web/approved-native-bridge.js, web/approved-fx-rack-view-model.js, tests/approved_native_m2_contract.test.cjs, tests/native_harmony_assembly_test.py. Current exact-head Fast UI #44674543798 SUCCESS, Fast Native #44674543809 SUCCESS, Harmony scoped SUCCESS and Codex review latest fc5450b512 NO major findings. Historical P2 source-assertion thread resolved. No full Chromium/Windows for this new HEAD yet while stacked on #832: parent #832 still waiting on independent full Windows native build and protected CI gate; native UI cannot be claimed user-tested/installer available. Next: only after parent protected merge, retarget #836 to new main, validate diff, run exact-SHA full UI plus justified native/FAT qualification, and merge after gate. Keep approved /preview/, G-MV37 M/ST, physical FX instance lease, N-MOD #833, I/O #825/#830, and Graphic EQ #835 independent.

@masarray
masarray changed the base branch from refactor/g-mv36-correlated-fx-editor-lifecycle-20261120 to main November 20, 2026 04:48

Copy link
Copy Markdown
Owner Author

@codex review
INT-1A FINAL COMBINED CODE REVIEW for exact PR #836 HEAD 3bc60cebf5a4d94e310285f9f07e89a441caeb4a against current main c04ed7bcdd8b352b8905cb7d3d1fc9d99a9d6d5a. Six-file integration combines G-MV36 #832 correlated JUCE FX HWND requestId/ACK/readback lease with G-MV38 editorSurfacePlan (five browser editor whitelist, offline logical, native VST3/unknown builtin fallback), while retaining N-MOD #833 .smix SAVE/OPEN and G-MV37 M/ST. Please focus stale ACK/instance/session, Main.cpp N-MOD+FX coexistence, editor whitelist security, no dual PCM/UI owner, and exact bridge tests. PR will only merge on full UI+Windows FAT+protected gate success.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 3bc60ce

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat 3bc60ce

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 3bc60cebf5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant