Repository navigation
refactor(native M2): single-owner .smix SAVE/OPEN admission and negative regression matrix - #833
Conversation
…ssion recovery owner
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…session lifecycle owner
Deploying arsonmix with
|
| Latest commit: |
5c02af1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0b23faf0.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-nmod-m2-session-adm.arsonmix.pages.dev |
|
/arsonmix-ci native a60e8f6 |
|
/arsonmix-ci native c36fc4d |
|
INT-1 N-MOD M2 release-critical handoff: #837 |
Use the logical FX editor's optional occupancy, not pointer comparison. Guard SAVE and async OPEN against a conflicting editor or Device Apply. Incorporate exact current main.
|
@codex review Exact candidate |
|
/arsonmix-ci native 5c02af1 |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
INT-1 G-MV active integration notice (20 Nov): #832 now rebased/reconciled onto |
|
INT-1 N-MOD merge receipt N-MOD | Exact qualified head Restored a valid MSVC build by checking the optional vendor editor lease with |
M2 software closure slice: one session SAVE/OPEN admission writer
Based on
main@07e5f65fbe69bcfe1c5768bf0528bfed631b2ccd; integrated commitc36fc4dc948f73a931c11c18ce5305dcd0d281a0.Actual responsibility removed from ConsoleWindow
NativeMixerSessionRecovery::planSavenow decides fail-closed save eligibility and whether an operation is an unchanged logical autosave, logical-only portable export, or installed-native capture.NativeMixerSessionRecovery::planOpenowns the async-load admission matrix: changed epoch/busy/STREAM rejection, retained-only rejection, M4/ChannelId physical restore vs logical-only open.ConsoleWindowremains composition/OS-adapter: it gathers actual engine/status evidence, manages the file chooser, capture-mute/restore, worker callbacks, hotkey identity activation and one existing browser ACK/readback. No new DSP graph, dispatcher, store, lease or fallback.src/Main.cpp; converted into explicit decision dispatch without changing saved formats or physical device graph.Final candidate: actual source-bound contract reconciliation
tests/audio_continuity_contract_test.mjsandtests/mixer_io_operator_contract_test.mjsnow assert the new Recovery owner rather than stale inlineMain.cppexpression locations, retaining STOP/offline failure safety.AudioIODevice::isOpen(); contexts are populated with named fields rather than fragile ordered booleans.Regression added
tests/native_mixer_session_store_test.cppnow exercises both plans' accepted/rejected transitions including busy, read-only, offline logical autosave/export, retained, legacy M4, ChannelId installed, pending recovery, missing physical device, unauthorized/interrupt, shutdown exception, active secondary stream, graph pending, stale epoch.Parallel merge safety
#832touchesMain.cppat FX editor hunk ~6272; this change is only SAVE/OPEN ~3430–3560, with no bridge/UI edits.#830touches Main's includes/native accepted capture ~1725–1950; this slice does not modify its capture schema, SourceBinding or current IO contract.#825modifies LiveAudioEngine/LiveDryRoutingLab/device reader. This PR does not touch those files, CMake, or native PCM.#731/#708/#635/#661must be semantically reconciled if revived; do not merge stale source blobs.Scope & acceptance
This is a software M2 session-policy vertical slice, NOT full M2 milestone closure, not hardware FAT, not installer or release. M2 still has FX/editor lease and broader host lifecycle responsibilities to close. Do not claim green CI before exact-head qualification.
Validation contract
/arsonmix-ci native <SHA>(MSVC/CTest), targeted review + Required Merge Gate, protected squash merge, verify post-merge main..smixbinary SHA/HEAD durability, identity/hotkey activation only upon acceptance, DIRECT ASIO output fence, SOURCE ONLY/WIRE/BUS/MAIN, one primary render graph.Tracks #527.