Skip to content

refactor(gui G-MV37): one pure M/ST policy across saved, ChannelId and M4 mixers - #834

Merged
masarray merged 3 commits into
mainfrom
refactor/g-mv37-processing-format-one-policy-20261120
Nov 20, 2026
Merged

masarray merged 3 commits into
mainfrom
refactor/g-mv37-processing-format-one-policy-20261120

Conversation

@masarray

Copy link
Copy Markdown
Owner

G-MV37: One source-owned M/ST (MONO/STEREO) control policy across all mixer authorities

Base main@07e5f65fbe69bcfe1c5768bf0528bfed631b2ccd. HEAD 04cb49c95e4c3631bb8cb7ac78937d88690e69f3.

Found three separate target/admission branches for M/ST inside the 4k-line approved-native-bridge.js. Replaced them with one pure processingFormatPlan in existing approved-channel-strip-view-model.js:

  • Offline saved .smix: exact INPUT ChannelId, valid workspace, writable document, supported native logical format op, no pending; returns a document-only intent.
  • Installed ChannelId: exact admitted physical native owner + epoch + graph/roster + callback ChannelId + supported operation, canonical device hardware fingerprint and unique INPUT role; controller remains the one existing correlated ACK/readback owner.
  • Verified M4: uses existing m4ChannelPatchPlan for input ordinal, device/route/session identity, source provenance and current native format. No other IPC adapter or pending map. The bridge sends the existing M4 channel patch unchanged.

The bridge now delegates all source format decisions/target toggles to this pure policy; no optimistic GUI mutation. On stale/ambiguous/unknown formats, edits are rejected rather than guessing MONO. Added regression tests for all three modes, native authority retirement, epoch/roster drift, duplicate input rows, malformed format, invalid hardware identity, pending/logical readOnly, M4 route mismatch and reusing one bridge dispatch.

Exactly 3 files: existing strip VM, existing native bridge, native M2 contract tests. No JS dispatcher/PCM model, new GUI state, JUCE DSP, device topology, IO-2C, N-MOD, FX editor lifetime or HTML/CSS changes. G-MV36 PR #832 concurrently owns FX editor lifecycle and is explicitly not duplicated here.

Gates Fast UI/Native, Chromium /preview/, Codex, protected exact-head merge gate; do not merge untested or while base main diverges. Windows installed ASIO hardware FAT is explicitly out of scope.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T02:37:58.127735Z 624baf5 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 624baf5
Status: ✅  Deploy successful!
Preview URL: https://bd8f0b88.arsonmix.pages.dev
Branch Preview URL: https://refactor-g-mv37-processing-f.arsonmix.pages.dev

View logs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04cb49c95e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 624baf5

Copy link
Copy Markdown
Owner Author

@codex review

Please review latest exact HEAD 624baf5dbf47b25239dffcf864cf7a56cdf78b9a; both prior stale test assertions are fixed and Fast UI/Native pass.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 624baf5dbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@masarray
masarray merged commit 55f79ec into main Nov 20, 2026
46 of 47 checks passed

Copy link
Copy Markdown
Owner Author

G-MV37 — MERGED MAIN, final source-qualified handoff · 20 November 2026

Hasil pengguna: One consistent M/ST (MONO/STEREO) permission and target policy now serves the same approved /preview/ native mixer across .smix offline, installed ChannelId and compatible M4. The bridge delegates decisions to the existing pure Channel Strip ViewModel instead of independently reading/toggling M/ST in 3 branches. Invalid/ambiguous input format or stale native graph fails closed. The existing logical document commit, native controller ACK + independently accepted PCM readback and M4 channel patch remain the sole transaction owners. No visual redesign or user gesture change.

Status nyata MERGED MAIN: PR #834, squash 55f79ec90447a1b4972954237975592b4f24b9d2 from exact-head 624baf5dbf47b25239dffcf864cf7a56cdf78b9a, base 07e5f65fbe69bcfe1c5768bf0528bfed631b2ccd. Verified main exactly 55f79ec90447a1b4972954237975592b4f24b9d2; squash Git tree 30bf0feee32930796bd4d66b8d94e14efbb99e7c is identical to full-CI qualified head tree. Exactly 3 changed files: web/approved-channel-strip-view-model.js, web/approved-native-bridge.js, tests/approved_native_m2_contract.test.cjs. No changes to JUCE C++, DSP/ASIO/PCM, FX Editor, IO-2C/IO-3A, N-MOD, .smix storage format or HTML/CSS.

Bukti: Fast UI PASS #44661745473; Fast Native PASS #44661745545; exact-head Full Chromium /preview/ #44661923299 SUCCESS 109/109 on rerun, including live FX/GAIN/WIRE/format-related GUI and CSS parity. The initial Full Chromium run of this same SHA failed on the unrelated Stage C hover-hardware pixel screenshot parity, not M/ST, and the unchanged-SHA rerun passed; keep this flaky screenshot signal auditable rather than claiming an initial clean run. Exact-head Codex review COMPLETED zero findings, zero unresolved; an earlier P1 test-only finding at old HEAD was fixed in commits 03319a4/624baf5, reviewer replied and thread resolved. Required CI Merge Gate SUCCESS before protected squash, refreshed via rerunning already successful Fast UI job as documented in issue #823; not bypassed. No branch/main divergence at merge (behind=0).

Aman dipakai? Source changes and browser UX: YA for source-qualified workflow, subject to real hardware testing; Windows installed / direct ASIO two-device physical FAT BELUM. No new installer/release or physical hardware claim. Post-merge automatic UI #44663754022 and Native #44663753988 still IN PROGRESS at last check.

Tindakan Anda: TIDAK PERLU MELAKUKAN APA-APA.

Cross-thread merge advisory: Concurrent G-MV36 FX Editor PR #832 started from the pre-G37 base 07e5f65.... Its maintainer MUST reconcile against the new main 55f79ec90447a1b4972954237975592b4f24b9d2 and recheck source-contract tests before merge; bridge edits are separate locations, but do not assume conflict-free without verifying. Next GUI modularization should address an unrelated owned lifecycle (e.g. device/source/WIRE), not duplicate G-MV31–37, preserve one approved /preview/ and one PCM owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant