Repository navigation
refactor(gui G-MV37): one pure M/ST policy across saved, ChannelId and M4 mixers - #834
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying arsonmix with
|
| Latest commit: |
624baf5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd8f0b88.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-g-mv37-processing-f.arsonmix.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04cb49c95e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
/arsonmix-ci ui 624baf5 |
|
@codex review Please review latest exact HEAD |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
G-MV37 — MERGED MAIN, final source-qualified handoff · 20 November 2026Hasil pengguna: One consistent M/ST (MONO/STEREO) permission and target policy now serves the same approved /preview/ native mixer across Status nyata MERGED MAIN: PR #834, squash Bukti: Fast UI PASS #44661745473; Fast Native PASS #44661745545; exact-head Full Chromium Aman dipakai? Source changes and browser UX: YA for source-qualified workflow, subject to real hardware testing; Windows installed / direct ASIO two-device physical FAT BELUM. No new installer/release or physical hardware claim. Post-merge automatic UI #44663754022 and Native #44663753988 still IN PROGRESS at last check. Tindakan Anda: TIDAK PERLU MELAKUKAN APA-APA. Cross-thread merge advisory: Concurrent G-MV36 FX Editor PR #832 started from the pre-G37 base |
G-MV37: One source-owned M/ST (MONO/STEREO) control policy across all mixer authorities
Base
main@07e5f65fbe69bcfe1c5768bf0528bfed631b2ccd. HEAD04cb49c95e4c3631bb8cb7ac78937d88690e69f3.Found three separate target/admission branches for M/ST inside the 4k-line
approved-native-bridge.js. Replaced them with one pureprocessingFormatPlanin existingapproved-channel-strip-view-model.js:.smix: exact INPUT ChannelId, valid workspace, writable document, supported native logical format op, no pending; returns a document-only intent.m4ChannelPatchPlanfor input ordinal, device/route/session identity, source provenance and current native format. No other IPC adapter or pending map. The bridge sends the existing M4 channel patch unchanged.The bridge now delegates all source format decisions/target toggles to this pure policy; no optimistic GUI mutation. On stale/ambiguous/unknown formats, edits are rejected rather than guessing MONO. Added regression tests for all three modes, native authority retirement, epoch/roster drift, duplicate input rows, malformed format, invalid hardware identity, pending/logical readOnly, M4 route mismatch and reusing one bridge dispatch.
Exactly 3 files: existing strip VM, existing native bridge, native M2 contract tests. No JS dispatcher/PCM model, new GUI state, JUCE DSP, device topology, IO-2C, N-MOD, FX editor lifetime or HTML/CSS changes. G-MV36 PR #832 concurrently owns FX editor lifecycle and is explicitly not duplicated here.
Gates Fast UI/Native, Chromium
/preview/, Codex, protected exact-head merge gate; do not merge untested or while base main diverges. Windows installed ASIO hardware FAT is explicitly out of scope.