Skip to content

ArSon Vocal Throw M2 — real native music-channel Auto BPM tap and fallback - #474

Closed
masarray wants to merge 61 commits into
mainfrom
feature/arson-vocal-throw-music-tempo-m2-20261108
Closed

masarray wants to merge 61 commits into
mainfrom
feature/arson-vocal-throw-music-tempo-m2-20261108

Conversation

@masarray

@masarray masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner

ArSon Vocal Throw M2 — real native MUSIC ChannelId tempo feed

Closes part of #473. Draft engineering qualification, not field-certified release.

Dependency / stacked change

Built on top of still-draft M1 PR #469 (exact green MSVC/63 CTest baseline 4db384851e6f6378cca4fd037b744c98bd1f0ba3). This draft temporarily targets main to use the repository's owner-authorized exact-SHA Windows qualification lane; do not merge it before M1 is resolved. The M2-only diff is the comparison from M1's head to this branch.

Actual native pipeline

Accepted ChannelId music/backing lane, selected explicitly from Vocal Throw editor -> native epoch/revision/role admission -> pre-FX tap from authoritative DynamicNativeSessionPublisher::render() -> bounded 10ms mean-energy SPSC, no separate audio callback -> CONTROL-only onset correlation + BPM lock/fallback -> one precomputed sample interval per active VocalThrowProcessor. Audio retains dry zero-added-sample path; existing dual frozen tails keep their own intervals as music tempo changes.

Delivered

  • Source selection from native /preview/ FX editor with DSP/graph ACK and BPM/confidence readback (including manual fallback, no simulated browser BPM).
  • 72/95/120/160 BPM deterministic music fixture, role/epoch/source fencing, no callback heap, silence holdover + stale fallback tests.
  • No FFT, locking, heap, disk, JS audio or worker on ASIO callback; each selected music PCM sample only requires bounded absolute energy observation.
  • Revision rebind for surviving native source across WIRE/FX edits; stale/missing sources fail closed.
  • Manual BPM and TAP remain serialized presets and fallback; automatic tempo does not overwrite them.

Limitations / release gates

  1. The detector is an energy-onset music beat estimator, not a full genre-independent beat tracking ML model. Must verify syncopated real backing mixes, false half/double-time and venue bleed on physical devices.
  2. Beat phase is exposed as estimated onset anchor for diagnostics, but full sample-perfect global transport/grid quantization is still outstanding; do not claim phase-locked live latency compensation.
  3. Tempo source is a single song-wide selected backing ChannelId, ephemeral (not yet durable per Show); supported only on the native DIRECT accepted PCM graph. Source disappears or graph epoch becomes stale -> manual/TAP fallback.
  4. Windows MSVC/CTest, actual Chromium UI, ASIO 64/128 frame 44.1/48/96k xrun/CPU and singing FAT are qualification gates. Keep draft until evidence.

No duplicate audio engine or conflicting M4 routing authority.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 39ba9a4
Status:⚡️  Build in progress...

View logs

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native cce6323

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 39ba9a4

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

M2 exact-native checkpoint / follow-up regression

Verified on Windows Actions #42498186748 for cce63231da52f69e6789873ecc406adba69aa1cb:

  • Real Windows JUCE/MSVC compilation passed.
  • 64/64 native CTests passed, including NativeMusicTempoSourceOnsetsAndFallback (real accepted-graph backing PCM, source/epoch fencing, silence holdover, 72/95/120/160 BPM and callback no-heap tests).
  • Approved native FX desktop/mobile Chromium FAT passed; native source selector ACK/readback verified.

Post-green hardening in new head 39ba9a48de8fe87270f9ed0cf9cac49fb004dfed:

  • VocalThrowProcessor::consumeRealtimeEdits() atomically samples precomputed music tempo before a same-block THROW, including when bypassed.
  • prepareToPlay() invalidates stale auto interval cache across device/rate reprepare.
  • New deterministic Vocal Throw PCM test compares 180 BPM music-synced tail vs 120 BPM manual fallback and proves already-frozen tail timing does not change when the tempo source disappears.
  • Added durable M2 design/qualification document.

Fast contracts + targeted Chromium on final head pass. Exactly one owner-authorized Windows native final-head run #42499813920 is running for new CTest. No additional full build is requested. PR remains draft; physical ASIO/singer/xrun and sample-accurate beat-phase alignment are not certified. M2 is stacked on draft PR #469: do not merge out of dependency order.

Copy link
Copy Markdown
Owner Author

Repository housekeeping (2026-11-10): Close as superseded, not merged. The M2 tempo implementation was included in the reconciled M1–M11 delivery in merged #497/#499. This older stacked draft should not be merged again against newer main. Remaining verified-device and musical-sync acceptance stays in #473.

Original branch/PR history remains available for audit. Current main and any pending candidate must pass their own exact-SHA CI and hardware gates.

@masarray masarray closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant