Skip to content

ArSon Vocal Throw — native phrase-aware concert delay (manual / auto / hybrid) - #469

Closed
masarray wants to merge 37 commits into
mainfrom
feature/arson-vocal-throw-native-20261108
Closed

masarray wants to merge 37 commits into
mainfrom
feature/arson-vocal-throw-native-20261108

Conversation

@masarray

@masarray masarray commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

ArSon Vocal Throw — native ChannelId live vocal FX

Implement actual C++ DSP in the authoritative JUCE PCM graph (not browser DSP or an independent audio engine).

Implemented

  • Real zero-added-sample dry path, rolling 2.5s stereo vocal capture, up to 1.5s last-word/phrase freeze.
  • Bounded capture-copy work per sample; auto phrase-end gate and cooldown; manual trigger; hybrid default; sample-timed subdivided BPM echoes with fading, decay and wet ducking.
  • JUCE AudioProcessor insert on the existing per-ChannelId graph, fx slot/rack bypass + Show save/restore, strict schema/version.
  • Native UI controller: approved /preview/ FX picker, compact preset editor, THROW, TAP BPM, gated mode/echo parameters and accepted DSP ACK + epoch/revision/instance readback.
  • C++ standalone deterministic no-heap/PCM tests wired into CTest; one-mixer JS/UI assembly guard and fast syntax CI.
  • Engineering notes: docs/ARSON_VOCAL_THROW_NATIVE_20261108.md.

Boundaries and outstanding quality gate

Auto is vocal phrase-end detection; automatic tempo estimation from the separate music/backing BUS is NOT implemented yet. Current tempo is set by BPM or TAP. No MIDI footswitch binding yet. Energy-envelope heuristic is not trained singing/lyric phrase recognition.

This is an engineering qualification PR, not yet approved for main/release. Await exact-SHA C++ Windows MSVC/CTest, native WebView2/Chromium UI FAT, physical ASIO stress at 64/128 samples, real vocalist listening test (breaths/hold/bleed), routing and Show restore tests. Do not treat static/quick checks as live-singing certification.

Built from merged Compressor main SHA 8accbc4. Harmony PR #467 is separate and not altered.

Test strategy

Scope CI to existing quick Windows contracts and UI quick lane for PR; full native build/device qualification only for exact head, avoiding redundant workflow dispatches.

2026-11-08 — realtime/musicality hardening

Source hardening through b2657cd0e6c56a69599162c56e6d81fd60ba23d5:

  • Independent two-voice frozen tails: next cue no longer truncates an active echo. When pool is saturated, cue receives negative DSP acknowledgement instead of overwriting a sounding phrase.
  • Fixed-memory hot-path: sequential rolling write cursor; capture uses bounded contiguous 24-frame memcpy-like bulk copy per sample, avoiding per-frame modulo.
  • Hybrid manual cue suppresses auto duplicate for the same phrase; silence counter saturates across long sessions.
  • 8ms wet slewing; normalized wet gain during dense or simultaneous taps; untouched direct dry path.
  • Added C++ PCM regression fixtures for tail continuity at 8/48/96 kHz, bounded polyphony, manual/auto dedup, and dense six-repeat level.

Qualification: fast native contracts and targeted Chromium UI passed on exact b2657cd; owner-authorized Windows MSVC/CTest build dispatched as Actions run 42492553140. Physical ASIO latency/xrun and singer/bleed listening trials remain unverified. Draft/release gate remains in force.

Next architecture milestone (not falsely claimed implemented): tempo tracking from separate backing/music bus -> confidence and beat-phase/hysteresis -> lock-free shared transport -> sample-timed throw grid; optional phrase confidence and MIDI footswitch. Keep all heavy analysis off the realtime audio callback.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4db3848
Status:⚡️  Build in progress...

View logs

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native a5e2565

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

2026-11-08 — Independent implementation / qualification audit

Verified current branch head a5e2565e5dab3b209bda9968a5e7615466fda7cb and existing native code, not just GUI:

  • engine/builtin_fx/VocalThrow.h: bounded rolling capture, dry-path passthrough, auto phrase-end/manual/hybrid, six repeats, delay subdivision, smoothing/ducking, no per-callback heap allocations.
  • VocalThrowProcessor.h: actual JUCE AudioProcessor insert with realtime control queue and completion/readback, schema-versioned restore.
  • Reviewed C++ deterministic test coverage: tempo divisions, dry identity, stereo capture, manual/auto, stale cue veto, bad parameters, 8/44.1/48 kHz, callback allocator guard.
  • Exact-head GitHub Actions: Windows Native VST3 Host run 42490090626 fast native contracts PASSED; Windows MSVC/CTest SKIPPED. UI smoke run 42490090619 fast UI contracts PASSED; targeted desktop/mobile Chromium Vocal Throw FAT PASSED. These results do not certify native PCM execution or live ASIO performance.
  • Local C++ recompile was attempted but environment cannot resolve raw.githubusercontent.com; no independent native compilation result is asserted.

Next qualification gates before marking ready: trigger the existing Windows MSVC/CTest path for this exact head; test physical ASIO 64/128 sample 44.1/48/96 kHz; validate real singer/breath/bleed/hold behavior, FX bypass and routing, Show restore and device restart.

Product boundary: 'Auto' currently detects vocal phrase ending, not automatic BPM from music/backing bus. BPM entry/TAP exist; music-bus tempo/beat-phase engine and MIDI footswitch remain separate follow-up engineering work. No release claim until validated.

Keep this PR as draft while these gates are outstanding; avoid claiming complete automated music sync.

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native b2657cd

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 4db3848

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

Vocal Throw — native qualification recovery (2026-11-08)

Exact previous Windows native run 42492553140 successfully compiled all JUCE/MSVC targets; CTest had 62/63 PASS. The only failing case was NativeVocalThrowPhraseCaptureManualAutoAndNoHeap, with tests/builtin_vocal_throw_test.cpp:223 fx.throwCount()==2.

Root cause: the test expected a second auto throw after only 208ms of silence, but the detector's 18ms envelope release must first pass its -35dB gate before the 160ms silence counter. That interval was insufficient; this was a premature test expectation, not evidence that the callback crashed under normal audio. Test now verifies no early throw and a valid second throw after release + silence.

Additional functional hardening: auto-then-late-manual now rejects a duplicate of the same ended phrase; the next sung phrase correctly resets the duplicate guard. C++ tests cover both trigger orders.

Latest head: 4db384851e6f6378cca4fd037b744c98bd1f0ba3. Fast native contracts and targeted desktop/mobile Chromium FX editor FAT PASS. Single exact-SHA Windows MSVC + CTest run 42494827886 is underway; no extra runs should be dispatched while it is in progress.

Remaining required hardware gate: physical ASIO 64/128 frames at 44.1/48/96k, xrun/CPU comparison and singer/breath/bleed audition. Auto BPM from isolated backing bus and MIDI footswitch are still not implemented; do not conflate Auto phrase-end with Auto music tempo.

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

M1 qualified CI milestone / M2 handoff — 2026-11-08

  • Exact M1 commit 4db384851e6f6378cca4fd037b744c98bd1f0ba3 passed real Windows JUCE/MSVC and 63/63 CTest in Actions run 42494827886. The earlier 62/63 hybrid-gate fixture failure is resolved.
  • Chromium desktop/mobile native FX FAT passed on that commit.
  • Continued work on genuine music-source Auto BPM, based on this immutable green M1 head, is isolated in draft PR ArSon Vocal Throw M2 — real native music-channel Auto BPM tap and fallback #474, linked to issue ArSon Vocal Throw M2 — real Music BUS auto-BPM + beat-phase synchronization #473. M2 uses one accepted native PCM graph, explicit backing ChannelId tap, bounded RT summaries, off-audio tempo estimator, and precomputed new-tail interval with manual fallback; no second audio callback. M2's own C++/ASIO claims remain pending its specific Windows qualification.
  • Keep M1 as draft until product field evidence (physical ASIO 64/128, xrun/CPU, singer bleed/breath/phrase audition, restart/bypass) is available. Green CI is not the same as certified stage performance.

Copy link
Copy Markdown
Owner Author

Repository housekeeping (2026-11-10): Close as superseded, not merged. The M1–M11 Vocal Throw implementation was reconciled through merged #497 and the integrated M14 source through merged #499. This original pre-integration PR is no longer an independent merge target. Maintain feature/field qualification in #473 and #412; closing this historical PR is NOT physical ASIO certification.

Original branch/PR history remains available for audit. Current main and any pending candidate must pass their own exact-SHA CI and hardware gates.

@masarray masarray closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant