Repository navigation
Vocal Throw M5 — deterministic low-overhead music tempo scoring on control thread - #493
Closed
masarray wants to merge 5 commits into
Conversation
masarray
changed the base branch from
feature/arson-vocal-throw-hardware-face-m4-20261109
to
main
November 9, 2026 11:32
Owner
Author
|
/arsonmix-ci native 72ade3a |
Deploying arsonmix with
|
| Latest commit: |
a5a8062
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://05a5a9c8.arsonmix.pages.dev |
| Branch Preview URL: | https://feature-arson-vocal-throw-m5.arsonmix.pages.dev |
…after octave hysteresis
masarray
changed the base branch from
main
to
feature/arson-vocal-throw-hardware-face-m4-20261109
November 9, 2026 11:58
Owner
Author
|
Repository housekeeping (2026-11-10): Closing as superseded, not as a direct merge. The control-thread tempo-scoring milestone was included in subsequent Vocal Throw M1–M11 source reconciliation (#497, then #499). Close the old stacked PR to avoid independently reapplying an outdated FX/engine tree; audio-field verification remains separate. Code and review history remain on this PR; this closure does not assert a stable/public hardware-qualified release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vocal Throw M5 — bounded CONTROL-only music tempo scoring
Stacked on M4 draft #479 (M3 #476 → M2 #474 → M1 #469). Preserves all previous native phrase-echo behavior and approved hardware-editor GUI.
Audit finding
MusicTempoEstimator::evaluate()rescanned every onset pair for every BPM from 60 to 180 at each 500ms analysis update. It runs on JUCE's existing 12Hz control/UI timer, not ASIO, but can still create avoidable GUI stalls on dense syncopated backing.Implementation
std::array<float,121>scratch and native existing PCM source. No new thread, timer, heap, allocations, lock, FFT, second callback, WebView DSP or layout change.scoringComparisonsfield for CONTROL-only QA; regression tests enforce a bounded scan at 72/95/120/160 BPM, strong offbeat accents, phase lock loss/recovery and no made-up tempo from steady pad.QA and risk gates
New Windows JUCE/MSVC CTest on exact M5 SHA is required before declaring PASS. Do not infer from green M4 Chrome or M3 native CI. Physical ASIO and real concert backing + singer mic remain separate release gates. PR is draft and must not merge ahead of M1-M4.
Existing integration blocker
Current protected
maindiverged from M1/M2 due Compressor, Harmony and Player fixes. Do not overwrite those fixes by force merging the stacked branch. GitHub handoff: #473 (comment)