Skip to content

Vocal Throw M5 — deterministic low-overhead music tempo scoring on control thread - #493

Closed
masarray wants to merge 5 commits into
feature/arson-vocal-throw-hardware-face-m4-20261109from
feature/arson-vocal-throw-m5-tempo-control-budget-20261109
Closed

masarray wants to merge 5 commits into
feature/arson-vocal-throw-hardware-face-m4-20261109from
feature/arson-vocal-throw-m5-tempo-control-budget-20261109

Conversation

@masarray

@masarray masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Vocal Throw M5 — bounded CONTROL-only music tempo scoring

Stacked on M4 draft #479 (M3 #476 → M2 #474 → M1 #469). Preserves all previous native phrase-echo behavior and approved hardware-editor GUI.

Audit finding

MusicTempoEstimator::evaluate() rescanned every onset pair for every BPM from 60 to 180 at each 500ms analysis update. It runs on JUCE's existing 12Hz control/UI timer, not ASIO, but can still create avoidable GUI stalls on dense syncopated backing.

Implementation

  • One ordered pass over onset pairs (fixed 128 hits, recent <=11s, bounded 308-tick lag), dispatching each pair to only mathematically eligible BPM candidates; original score equation, 1/2/3-beat harmonic penalty, tolerance, ascending BPM tie-break, confidence, phase lock, and octave hysteresis are preserved.
  • The bounded search radius +/-12 BPM is a conservative superset of all candidates that meet the old 1.4-tick or 2.2% tolerance within 60-180 BPM. Every candidate still rechecks the original tolerance and cycle count; nothing is accepted by approximation.
  • Same fixed std::array<float,121> scratch and native existing PCM source. No new thread, timer, heap, allocations, lock, FFT, second callback, WebView DSP or layout change.
  • Deterministic scoringComparisons field for CONTROL-only QA; regression tests enforce a bounded scan at 72/95/120/160 BPM, strong offbeat accents, phase lock loss/recovery and no made-up tempo from steady pad.

QA and risk gates

New Windows JUCE/MSVC CTest on exact M5 SHA is required before declaring PASS. Do not infer from green M4 Chrome or M3 native CI. Physical ASIO and real concert backing + singer mic remain separate release gates. PR is draft and must not merge ahead of M1-M4.

Existing integration blocker

Current protected main diverged from M1/M2 due Compressor, Harmony and Player fixes. Do not overwrite those fixes by force merging the stacked branch. GitHub handoff: #473 (comment)

@masarray
masarray changed the base branch from feature/arson-vocal-throw-hardware-face-m4-20261109 to main November 9, 2026 11:32

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 72ade3a

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: a5a8062
Status: ✅  Deploy successful!
Preview URL: https://05a5a9c8.arsonmix.pages.dev
Branch Preview URL: https://feature-arson-vocal-throw-m5.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

Repository housekeeping (2026-11-10): Closing as superseded, not as a direct merge. The control-thread tempo-scoring milestone was included in subsequent Vocal Throw M1–M11 source reconciliation (#497, then #499). Close the old stacked PR to avoid independently reapplying an outdated FX/engine tree; audio-field verification remains separate.

Code and review history remain on this PR; this closure does not assert a stable/public hardware-qualified release.

@masarray masarray closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant