Repository navigation
Vocal Throw M6 P0 — repair wrong-FX Auto-BPM native snapshot and stale-graph readback - #495
Conversation
…snapshot, not EQ; fence stale device revisions
…l Throw ACK snapshot
… weak percussion cannot prevent reacquisition
Deploying arsonmix with
|
| Latest commit: |
fea39dd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c85acc56.arsonmix.pages.dev |
| Branch Preview URL: | https://feature-vocal-throw-m6-nativ.arsonmix.pages.dev |
|
/arsonmix-ci native fea39dd |
M6 P0 checkpoint — 2026-11-09 (live branch audit and real CI)Committed head Root cause A — real native GUI readback: nine Auto-BPM/beat-phase fields were erroneously populated by Root cause B — Windows red reacquisition: M5 sparse tempo scorer only counts onset pairs in the most recent 11s. Confidence previously divided by CI: exact-head fast native #42616334813 PASS; exact-head fast UI #42616334881 PASS. A single owner-authorized exact-SHA Windows #42616675859 is running on this fixed M6 SHA. Do not claim 69/69 until it finishes successfully. Dispatcher-only requirement temporarily retargeted PR #495 to main; base restored to #494 integration branch after dispatch, keeping review diff minimal. No merge or installer change. Remaining: verify Windows test #68 reacquires; if red, inspect log and fix estimator, not tests. Then reconcile M6 into final integration branch before main, preserve current Harmony/Compressor/Player; perform actual ASIO singer/MUSIC BUS field QA, xrun/CPU, device/WIRE restart, live backing syncopation and PDC tests. This checkpoint is a durable task handoff, not approval for release. |
|
Repository housekeeping (2026-11-10): Closing as superseded, not as a direct merge. The M6 tempo snapshot/readback and onset-reacquisition corrections were incorporated into the later M1–M11 Vocal Throw source reconciliation (merged #497) and combined M14 (merged #499), including native tempo tests. This older stacked draft is archived, not merged again. Hardware/ASIO certification is still pending. Code and review history remain on this PR; this closure does not assert a stable/public hardware-qualified release. |
Vocal Throw M6 P0 — correct native Auto-BPM readback + deterministic beat re-lock
Stacked on #494 integration based on protected current main; preserves M1–M5 and all Harmony, Compressor and Player work. Existing branches untouched; draft until new exact-SHA Windows CTest.
Two reproduced root causes
P0 native snapshot owner:
Main.cpp::emitNativeEqSnapshotincorrectly emitted NINE music tempo/beat status fields into the Parametric EQ payload, whileemitNativeThrowSnapshothad none. The Vocal Throw editor therefore showed manual/TAP or “NO SIGNAL” even when the engine's MUSIC bus was active/locked. Prior Chromium FAT mocks fabricated a complete Throw snapshot and missed this C++ integration defect.P0 native CTest red: Integration #494's real Windows run #42613152945 compiled successfully and passed 68/69 tests except
NativeMusicTempoSourceOnsetsAndFallbackattests/native_music_tempo_test.cpp:111 recovered.tempo.locked. A weak percussive passage fills the fixed ring with old, unrelated hits. Candidate score only uses onset pairs in the previous 11s, but confidence was divided by ALL stored hits (count_, up to 128) even after those stale hits no longer contribute. Auto-BPM then fails to reacquire when clear backing returns.Implemented corrections
arMixBuiltinThrowSnapshotowner; remove unrelated EQ pollution. Gate every readback by current device epoch AND graph revision: obsolete transport cannot show a live lock, stale source resets to 0 and user-visible fallback is Manual/TAP.tests/native_peq_assembly_test.pyguard verifying the nine BPM fields are present only in the Throw native C++ snapshot, fenced by epoch/revision, and consumed by the real GUI. Existing nativeweakBusyGrooveMustReleaseBeatGridfixture checks dropout/fallback/relock and caught the bug.Acceptance
Previous handoff #473 (comment)