Skip to content

ArSon Vocal Throw M3 — confidence-gated native beat-phase grid and sample-clock echo - #476

Closed
masarray wants to merge 32 commits into
feature/arson-vocal-throw-music-tempo-m2-20261108from
feature/arson-vocal-throw-phase-grid-m3-20261109
Closed

masarray wants to merge 32 commits into
feature/arson-vocal-throw-music-tempo-m2-20261108from
feature/arson-vocal-throw-phase-grid-m3-20261109

Conversation

@masarray

@masarray masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner

ArSon Vocal Throw M3 — beat-phase aligned native echo scheduling

Stacked on M2 draft PR #474, itself stacked on M1 draft PR #469. Product issue #473. Draft until CI and physical ASIO/singer tests.

Shipped in this branch

  • Exact per-callback sample-frame origin from existing authoritative ChannelId graph. RAII NativeBeatFrameScope is thread-local and only valid during native render; no second audio callback or audio graph.
  • MUSIC ChannelId onset summaries timestamped with real graph frame indices. Off-RT estimator publishes BPM and a separate confidence-gated phase anchor.
  • JUCE control publishes an epoch/revision-fenced, versioned atomic beat packet to Vocal Throw FX. ASIO reads once without spinning, allocating, locking or carrying music analysis.
  • On a manual/automatic THROW, a frozen tail captures the current music lattice, and its first echo is scheduled at the next suitable beat subdivision. Dry PCM is not quantized, buffered or delayed; already-playing tails are never rescheduled by changing BPM.
  • When onset phase is unreliable, DSP uses measured BPM only; when source or graph stale, accepted Manual/TAP BPM. Browser displays AUTO BPM · BEAT GRID vs AUTO BPM · BPM only without claiming phase lock from BPM alone.
  • Regression tests for actual PCM grid onset (64/128 frames), frozen-tail temporal stability, native scope expiry/revision continuity, BPM/phase confidence, and desktop/mobile native GUI readback.

Qualification

Prior exact M2 SHA 39ba9a48de8fe87270f9ed0cf9cac49fb004dfed passed 64/64 Windows native CTest; this M3 SHA requires its own CI. One targeted Windows exact-SHA qualification run, with normal fast contracts and Vocal Throw Chromium FAT; no full historical CI or duplicate queued runners.

Limitations

Source onset is summarized at 10ms granularity, hence the beat estimate is not sample-perfect; only scheduling to its estimated lattice is in sample-frame units. No guarantee of PDC-compensated external downbeat alignment, beat-phase correctness on weak/syncopated arrangements, or real ASIO xrun/latency without hardware evidence. Physical 44.1/48/96 kHz/64-128 sample and singer audition remain gates. Do not merge these PRs out of order.

See docs/ARSON_VOCAL_THROW_BEAT_GRID_M3_20261109.md.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8dbf6d5
Status: ✅  Deploy successful!
Preview URL: https://34c0180c.arsonmix.pages.dev
Branch Preview URL: https://feature-arson-vocal-throw-ha.arsonmix.pages.dev

View logs

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 433109b

@masarray
masarray changed the base branch from feature/arson-vocal-throw-music-tempo-m2-20261108 to main November 8, 2026 21:22

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 33364fe

@masarray
masarray changed the base branch from main to feature/arson-vocal-throw-music-tempo-m2-20261108 November 8, 2026 21:36

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

M3 checkpoint — 2026-11-09, verified exact SHA

HEAD: 33364fe74c188ca4bb1d9bbe2ca8142aeb36b9fb

Real Windows JUCE/MSVC: Actions run #42524993708 SUCCESS — 64/64 CTest PASS, zero failed. In particular:

  • NativeVocalThrowPhraseCaptureManualAutoAndNoHeap PASSED, including additional M3 tests for sample-grid echo onset at 64/128-frame chunks, frozen-tail no-retime and manual quarter-note fallback.
  • NativeMusicTempoSourceOnsetsAndFallback PASSED, including real accepted native-graph PCM, 72/95/120/160 BPM, beat-phase confidence, callback-frame continuity across graph revisions, device epoch reset and no-heap nested render-scope restoration.

UI: Chromium native Vocal Throw FAT #42524916837 SUCCESS, plus fast UI contracts; desktop/mobile confirms AUTO BPM · BPM only vs AUTO BPM · BEAT GRID from native accepted readback.

Source authority: M3 uses the same native ChannelId callback. The MUSIC onset summary is timestamped against its monotonic callback frame clock, and the existing JUCE control thread publishes a version/epoch/revision-fenced grid to VocalThrow inserts. DSP quantizes only the new echo start, never the dry voice, with one bounded atomic read attempt per block. No second callback, FFT, heap, mutex, or worker in ASIO. Invalid phase falls back to true measured BPM-only; invalid source or graph falls back to accepted manual/TAP.

Stacking/CI note: The repo's owner-authorized exact-SHA dispatcher only accepts PRs temporarily based on main. This PR was temporarily retargeted for that explicit CI request, and is now restored to base feature/arson-vocal-throw-music-tempo-m2-20261108, preserving a clean M3-only diff. M2 remains #474, M1 remains #469. Draft intentionally retained: none of this certifies physical ASIO 64/128 xrun/CPU, real band playback/syncopation, singer bleed, external VST3 PDC phase, or stage audition. The source's onset is windowed at 10ms, so timing is not sample-perfect beat detection.

Document: docs/ARSON_VOCAL_THROW_BEAT_GRID_M3_20261109.md. Issue #473 is partially fulfilled, pending the hardware FAT gates.

@masarray
masarray changed the base branch from feature/arson-vocal-throw-music-tempo-m2-20261108 to main November 8, 2026 22:17

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 8dbf6d5

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

2026-11-09 — M3 beat stability + premium VST face checkpoint

Exact head 8dbf6d575cd8e37de5a5249743bdc86902bc1960 (12 scoped commits since previously qualified M3 33364fe7):

DSP (real native, CONTROL only): preserve an accepted BPM across ambiguous half/double-time onset candidates with incumbent-score hysteresis. Compute beat-phase lattice by weighted agreement among multiple transients, not the newest loudest transient; reject competing offbeat rhythmic cohorts instead of snapping the singer's echo to an untrustworthy downbeat. Bounded std::array<float,121>, fixed onset history and original ASIO zero-heap path retained. Added deterministic tests for (a) 120 BPM with conflicting strong eighth-note offbeats: BPM remains stable and phase-grid drops out; (b) grid recovers when pulse becomes coherent; (c) steady pad doesn't manufacture BPM. Existing 72/95/120/160 BPM, no-heap and graph-epoch tests remain.

Built-in FX consistency: EQ, Compressor and Vocal Throw now all carry semantic armix-builtin-fx-power / armix-builtin-fx-close classes; one authoritative mixer-contextual-buttons.css owns their exact 26×24 Power and 24×24 Close hit boxes, green ON/red bypass/amber rack-off/grey unavailable states, SVG-like X and keyboard focus; accepted graph readback remains state authority. Vocal Throw's duplicate local Power/Close styling was removed.

GUI: compact refined VST finish (premium dark material, integrated native tempo LCD, concise beat lock, six-step repeat schematic, focus states, clean responsive 438px panel, reduced text noise). No simulated browser DSP. The underlying approved /preview/ remains the single GUI.

Verified: Fast UI + actual desktop/mobile Chromium FAT #42529379402 PASS; screenshot ZIP artifact #13635864043 captured and inspected. Tests assert every built-in editor has shared class family, button geometry, native power readback, LCD, responsive no-overflow.

Native Windows: owner-authorized exact-SHA run #42529534785 currently building MSVC/JUCE; do not claim 64/64 before results. PR was temporarily set to main only for dispatcher policy; restore base to M2 branch after this run. No other full Windows runs queued.

Remaining acceptance: actual music tracks, physical ASIO 64/128 44.1/48/96k xrun/CPU, live singer/mic bleed, external VST3 PDC and audition. Current 10ms onset window is not sample-perfect beat detection. Keep PR Draft.

@masarray
masarray changed the base branch from main to feature/arson-vocal-throw-music-tempo-m2-20261108 November 8, 2026 22:27

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

FINAL checkpoint — 2026-11-09 (beat stability + premium built-in FX)

Exact qualified SHA: 8dbf6d575cd8e37de5a5249743bdc86902bc1960

✅ Windows native MSVC/JUCE PASS — Actions #42529534785. Compiled application + all realtime targets. CTest 64/64 PASS, 0 failed (2.40s total); NativeVocalThrowPhraseCaptureManualAutoAndNoHeap (test #62) and NativeMusicTempoSourceOnsetsAndFallback (test #63) both passed after adding the new stability fixtures. Includes ambiguous 120 BPM dual-onset halfbeat protection, coherence phase-lock rejection/recovery and steady-pad non-triggering with callback no heap.

✅ Real desktop/mobile Chromium /preview/ FAT PASS — Actions #42529379402. Screenshots artifact #13635864043 visually inspected at 1366×768 and 390×844. Premium compact LCD, control spacing and responsive geometry verified.

✅ All three currently included built-in FX editors — Parametric EQ, Compressor and Vocal Throw — share semantic armix-builtin-fx-power and armix-builtin-fx-close classes with the one authoritative mixer-contextual-buttons.css. 26×24 Power and 24×24 Close geometry, state colors, icon and focus/press behavior. Eliminated Vocal Throw local conflicting Power/Close styles. DSP ACK/readback continues to drive Power states.

✅ Restored PR #476 base to M2 feature/arson-vocal-throw-music-tempo-m2-20261108 after exact-SHA native dispatch. It is mergeable and DRAFT, stacked on #474, stacked on #469. No merge to main without dependency and hardware gate.

Remaining reality check: The 10ms onset window does not make transient detection sample-perfect, despite frame-level echo scheduling. Real backing tracks with strong syncopation/genre changes, physical ASIO at 44.1/48/96k & 64/128, vendor FX latency compensation, CPU/xruns, live mic bleed and audible stage test remain release requirements. CI green is not hardware certification.

Copy link
Copy Markdown
Owner Author

Repository housekeeping (2026-11-10): Close as superseded, not merged. The beat-phase grid was carried in the later reconciled Vocal Throw M1–M11 integration (#497, #499). This pre-integration stacked PR is archived to avoid a stale branch merge; physical singer/ASIO acceptance remains open in #473/#412.

Original branch/PR history remains available for audit. Current main and any pending candidate must pass their own exact-SHA CI and hardware gates.

@masarray masarray closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant