Skip to content

ArSon Vocal Throw M4 — hardware VST faceplate from supplied Illustrator UI kit - #479

Closed
masarray wants to merge 30 commits into
feature/arson-vocal-throw-phase-grid-m3-20261109from
feature/arson-vocal-throw-hardware-face-m4-20261109
Closed

masarray wants to merge 30 commits into
feature/arson-vocal-throw-phase-grid-m3-20261109from
feature/arson-vocal-throw-hardware-face-m4-20261109

Conversation

@masarray

@masarray masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner

M4 — Hardware VST faceplate from the supplied Illustrator control kit

User correction: the previous Vocal Throw GUI looked like a browser form, not a premium audio hardware plug-in. This replaces the form layout, not another cosmetic recolor. Stacked above native engine / beat-grid M3 PR #476.

Reference interpretation

The uploaded 4974954.ai is a PDF-compatible Illustrator vector document, 500x500pt, containing a large nested rotary with radial tick marks and luminous violet rim, recessed small rotary and button families, illuminated push keys, and inset/tactile switches. We inspected the rendered source and reproduced the native vector control vocabulary in three tiny standalone SVG web assets (arson-vocal-hardware-rotor.svg, ...encoder.svg, ...push.svg) plus a switch reference asset. They preserve scalable crisp edges with no external font, CSS animation, or second UI renderer.

New native-approved GUI

  • Real device-style 3-part charcoal faceplate, low-noise typography and brushed/recessed hardware treatment.
  • One hero WET rotary, six physical encoder controls (capture, phrase end, gate, feedback, vocal duck, repeats), with vertical drag, mouse wheel, keyboard arrows/Page/Home/End, accessible slider values, double-click default and one control intent on gesture release.
  • Physical THROW and TAP keys, three-position Manual / Auto / Hybrid mode keys, quarter/eighth/dotted/half division latches, compact tempo CRT readout, real source selection, six LED repeat count and accepted native DSP readback.
  • No browser DSP. All parameter edits still use the original nativeThrowSet ACK + readback bridge; button THROW uses the real native command. Exactly the same authoritative /preview/ GUI asset bundle and JUCE callback.
  • Built-in FX Close and Power remain the same shared chrome as EQ and Compressor (24x24 Close / 26x24 Power). Never restyle them locally.

QA

Adds focused Chromium desktop/mobile tests for visible physical rotary controls, CSS SVG assets, actual wheel-to-native-intent/ACK/readback, source ACK, mode switch, stale graph, power/close sizing and no horizontal overflow. Native beat detector code unchanged from green M3 SHA 8dbf6d5, so run only fast contracts plus focused Chromium FAT first. Do not merge out of order; M1/M2/M3 remain draft.

Real physical singing/ASIO qualification remains separate.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5f6b1b0
Status: ✅  Deploy successful!
Preview URL: https://81a4cf43.arsonmix.pages.dev
Branch Preview URL: https://feature-arson-vocal-throw-m5.arsonmix.pages.dev

View logs

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

M4 hardware VST editor — completed checkpoint (2026-11-09)

Exact head: ab6170d7526fe719bd4f05868938b5cd9a2b1966 — stacked draft PR #479 on green M3 PR #476. No change to PCM, DSP, ASIO callback or audio graph.

User-supplied Illustrator UI kit analysis

Inspected 4974954.ai as a 1-page, PDF-compatible Illustrator file (500×500pt). Its visual vocabulary consists of concentric metal rotary rings, violet index/LED ticks, recessed circular encoders, illuminated mechanical push keys and inset toggles. The browser cannot efficiently render the 1.2 MB source design as interactive controls; M4 translates those geometries/materials into lightweight standalone vector SVG assets (rather than shipping the entire source document or generating a heavy Canvas). The original upload is not committed to the repository.

Delivered — no web-form UI

  • Fully rebuilt native plugin faceplate at 778px desktop; 390px portrait automatically reflows without horizontal scrolling. Hardware rotor WET MIX, six independent encoder dials, tactile THROW and TAP keys, Manual/Auto/Hybrid selector switches, musical division buttons, inset tempo LCD, source selection and six repeat LEDs.
  • Knob behaviors: pointer-captured vertical drag, mouse wheel, keyboard arrows/Page/Home/End and default-value double-click. Gestures feed the existing nativeThrowSet command/ACK/readback, not browser audio or uncontrolled visual-only states.
  • Existing native nativeThrowTrigger, nativeThrowTempoSource, graph-identity fencing, stale snapshot rejection, manual/TAP and conditional Beat Grid retained. The EQ/Compressor same shared Close/Power CSS owner and geometry remains intact.
  • DSP graph readback now also provides low-power/bypassed faceplate visual affordance. Buttons and layout do not claim acceptance before native ACK.

Evidence

  • Exact-SHA fast contracts + actual 1366x768 and 390x844 Chromium FAT: PASS, run #42537627071. Covers visible six hardware rotaries, physical wet knob, actual wheel-to-native settings action and ACK/readback, manual mode, trigger, stale FX graph, source ACK, LCD, repeat LEDs, overflow, shared EQ/Comp 24px Close and 26px Power.
  • Final screenshot artifact #13639104631, inspected desktop + portrait. A cramped rotor subcaption was removed and mobile spacing increased before this final exact-SHA CI.
  • Native DSP is unchanged from prior qualified M3 head 8dbf6d5, on which Windows MSVC/JUCE 64/64 CTest passed. This UI-only PR deliberately did not queue another expensive MSVC build.

M4 is DRAFT and mergeable until the dependency chain (#469 → #474 → #476 → #479) is reconciled and physical ASIO/singer release gates are met.

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

Singer-first THROW hardware redesign — verified final checkpoint (2026-11-09)

Exact qualified head: e719967d1ba6cbecd55a6ad6c9a43768fdb9855a | PR remains DRAFT, stacked on M3 #476, no change to native DSP/ASIO.

Correction from user review

The original M4 placed a text-heavy, flat pink THROW key off to the lower-left while WET MIX occupied the hero position. That inverted the singer's primary task and did not faithfully use the original Illustrator design. The revised face:

  • THROW is now the single largest, central 212×212 circular control (164×164 on 390px mobile), with an illuminated triangle and only discreet, engraved “THROW” below it. No words inside the key, no “FIRE PHRASE”, no meaningless motor/AI copy.
  • Its inner lit icon is actually cropped from the user's supplied 4974954.ai (PDF-compatible Illustrator image, cropped PDF region x=53..77/y=100..124), preserved as a tiny embedded WEBP within arson-vocal-throw-performance.svg. The outer recessed circular housing and directional markers are reconstructed as scalable SVG geometry inspired by the same source artwork. This is a genuine source-derived asset, not a mere palette match. Source AI file itself is not committed.
  • WET moved to a secondary 86px control. TAP button's already-accepted design is kept, as are six independent encoder knobs, mode/beat keys, music source control, accepted DSP ACK/readback and the unchanged EQ/Compressor shared Power/Close.
  • Removed verbose decorative headings, repetitive trigger text and noisy hints. Tempo and lock labels are factual and compact; detailed semantics remain accessible via ARIA/title. Native device power, rack bypass and actual tail status are the only status authorities.
  • Existing nativeThrowTrigger continues to fire only on singer action, with disabled-repeat behavior until a native response and tail illumination only after native readback.

Proof

Exact head UI smoke #42539990720 SUCCESS: fast UI contracts + real Chromium FAT on desktop 1366×768 and mobile 390×844. Tests check source-derived SVG embed, actual center hitbox (≥160px), icon-only semantics, native trigger dispatch, trigger lock until ACK, accepted tail illumination, rotary→DSP settings/readback, stale graph, shared Power/Close geometry and no UI overflow.

Final desktop/mobile screenshot artifact #13640996959 inspected: quiet dark hardware face, large center trigger, restrained neon treatment, aligned smaller encoders, TAP untouched, no clipping.

No full Windows CTest was queued because this patch changes HTML/CSS/SVG/UI tests only. Prior M3 8dbf6d5 native baseline already had 64/64 Windows CTest PASS. Hardware ASIO field qualification remains outstanding.

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

2026-11-09 — M4 visual layout/spacing recovery, native knobs and TEMPO/TAP face

Exact qualified head: 5f6b1b01ba41a5cc559f0335d38b052967949f55 | draft PR #479 remains stacked on M3 #476 and mergeable. This change is GUI-only; native PCM/ASIO callback and all beat-detector code remain unchanged.

Visual audit: causes and repairs

  1. THROW had four directional markers, making the singer's central phrase switch read like a four-way gamepad. Removed the directional SVG path entirely, retaining a clean circular hardware surface and the user's embedded illuminated play artwork.
  2. MIX used a different large rotor design from the six small encoders. All SEVEN knobs now render the same arson-vocal-hardware-encoder.svg body and shared pointer. A single pathLength=100 SVG 260° arc with round line caps advances in sync with pointer angle (-130° → +130°), with the chassis stationary. The actual outer rounded cyan arc and pointer are set from the accepted/draft parameter, not a fake animation.
  3. Tempo LCD was too small and isolated from TAP. Refactored the performance row into MIX / trigger mode / integrated LCD+TAP. Enlarged tempo numerals to 44px desktop and 47px mobile with subdued emerald LCD material and real native AUTO/GRID/TAP state, with the TAP mechanical key directly alongside (measured 9–10px gap).
  4. Detached manual BPM field repeated the number below LCD, looking like a web form and causing mobile overflow. The LCD numerals now act as an accessible BPM editor: click to focus the in-place input, Enter to commit through the original nativeThrowSet ACK/readback, Escape to cancel. No duplicate number on the face, all edit values remain graph-authoritative.
  5. Spacing was improvised across breakpoints. Rebuilt one consistent instrument/control/transport grid: desktop centered 212px THROW between two equally aligned three-knob banks; mobile centered 166px THROW above two clean rows of encoders. Both layouts keep MUSIC/RHYTHM and a visible status rail. No extra Power/Close CSS: the same EQ/Compressor shared 24×24 Close and 26×24 Power chrome is untouched.

Automated visual and functional QA

Exact SHA Chromium CI #42548611390 — PASS:

  • fast UI contracts PASS.
  • desktop 1366×768 and portrait 390×844 real Chromium FAT PASS.
  • Layout geometry assertions: throw centered (<4px), symmetric desktop encoder banks, stacked portrait flow, LCD/TAP adjacency (<=17px), aligned centerlines (<=24px), no clipping/overflow, visible footer in mobile.
  • Seven exact shared knob backgrounds, per-knob SVG rounded arc pathLength=100, level arc length and pointer update after wheel, stationary knob background.
  • Integrated LCD BPM editor click/focus/Escape, accepted native source and manual/autobeat readback, trigger single native command and ACK/tail glow, stale-device fencing and standard EQ/Comp Power/Close geometry.
  • Screenshot evidence: Actions artifact #13644975316, manually reviewed desktop and mobile.

No Windows native CTest was rerun for this pure HTML/CSS/SVG/test patch; previous exact M3 Windows 64/64 remains the native baseline, not a claim of current hardware ASIO field proof. M4 stays DRAFT until dependent PR chain and ASIO hardware/release gates are resolved.

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

Integration safety checkpoint — 2026-11-09 (DO NOT LOSE)

Authoritative durable M1–M4 handoff: #473 (comment)

This M4 PR remains at 5f6b1b01ba41a5cc559f0335d38b052967949f55, Open Draft, clean against its M3 base, with verified latest desktop/mobile GUI run #42548611390. This is the complete approved visual refinement: clean large THROW icon, seven matching encoders with moving rounded cyan arc, big editable tempo LCD beside TAP, tidy mobile and shared EQ/Compressor Power/Close.

IMPORTANT: upstream M1 #469 and M2 #474 now conflict with current protected main 381c1402. M3 and M4 clean states are only relative to preceding feature branches and do NOT mean ready to merge into main. Preserve all heads, integrate M1→M2→M3→M4 against new main semantically while keeping Compressor/Harmony/Player improvements, then qualify the newly reconciled exact SHA. No code/branch changes or extra CI have been made during this checkpoint.

Copy link
Copy Markdown
Owner Author

Repository housekeeping (2026-11-10): Close as superseded, not merged. The hardware VST faceplate was incorporated in the subsequent M1–M11 integration #497 and M14 #499; its original M4 stack is historical and must not be independently merged into today's main. UI and field acceptance remain separate.

Original branch/PR history remains available for audit. Current main and any pending candidate must pass their own exact-SHA CI and hardware gates.

@masarray masarray closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant