Repository navigation
Add after-selection scan preferences to the settings model - #936
Merged
Merged
Conversation
Next scan and Start from have a shared value and an override for each scanner. Standard keeps what each scanner does today. A saved wait after typing becomes the keyboard's choice, and a value this version does not know falls back alone. Closes #930 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review follow-up: a null shared value is dropped like an unknown one, and the keyboard's own standard choice now stands over a saved wait after typing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
enaboapps
marked this pull request as ready for review
September 28, 2026 08:21
This was referenced Sep 28, 2026
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #930
Part of #935.
Change
Adds two scan preferences to
point-scan.json, each with a shared value and an override for Point, Menu, Keyboard and Mouse.nextScanstandard,automatic,waitstandardstartFromstandard,beginning,selectionstandardstandardmeans what each scanner does today. The scanners differ, so one shared default of automatic or wait would change someone's behaviour on update.keyboardWaitAfterTypingresolves towaitfor the keyboard, unless a choice has been made since.No scanner reads the new values yet, so behaviour is unchanged. The settings stay local; there is no protocol change. Older builds ignore the new fields.
Validation at 41d0c5d
All run locally on Windows and passing:
npm run lint,npm test,npm run buildcargo fmt --checkcargo clippy --all-targets -- -D warningscargo test: 588 passedNew tests cover defaults, round trip, per-scanner overrides, the saved wait after typing, and unknown values.
🤖 Generated with Claude Code