Skip to content

Apply after-selection preferences in the action menu and point scan - #938

Merged
enaboapps merged 4 commits into
mainfrom
932-after-selection-menu-point
Sep 28, 2026
Merged

enaboapps merged 4 commits into
mainfrom
932-after-selection-menu-point

Conversation

@enaboapps

@enaboapps enaboapps commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Closes #932

Part of #935. Stacked on #937, which is stacked on #936.

Change

Scanner Preference Behaviour
Point Next scan: Standard or Wait After a click, a closing command or a drag, scanning stops until Select, as before
Point Next scan: Automatic The next point scan starts by itself. The pass limit still stops it
Menu Start from: Standard or Selection After a scroll or media item, the highlight stays on it, as before
Menu Start from: Beginning The highlight returns to the start of the open menu
Menu Next scan: Wait The menu waits for Select and shows "Select to continue"
  • The point scanner's choice decides what follows a click, because the point scan is what starts next. The menu's choice covers only items that leave the menu open.
  • Start from has no effect on the point scanner. A point scan always starts from its beginning.
  • A click that fails after the next scan has started still opens the menu with the error.
  • A click may bring another window forward. A scan that started by itself takes up the window in front until the user chooses something in it. From then on a change of window ends the scan, as before. This path runs in the runtime and has no automated test; the workflow side of it is tested.
  • With Automatic and no pass limit, or with step scanning, the point scan stays active after each click until Stop, Cancel or Pause. No click happens without switch presses.
  • Unchanged: opening a submenu, Back, Close menu, the speed and mode items, changing display, and the pass limit.

Remote scanning validation needs no change. Wait needs Select exactly as the pass limit pause already does.

No settings UI yet, so users see no change until #933. No persisted schema or protocol change.

Known limits

  • Only the window in front is taken up, not the work area. A click that changes the work area, such as entering a fullscreen space or hiding the taskbar, still ends the scan that followed.

  • A window that appears after the user has already chosen a line in the new scan ends that scan with the usual message. No click lands on the wrong window.

  • While no window is in front, a scan that started by itself holds still for up to a second in all, then ends with the usual message. A switch press in that moment is not acted on.

Validation at 57c9f35

All run locally on Windows and passing:

  • npm run lint, npm test, npm run build
  • cargo fmt --check
  • cargo clippy --all-targets -- -D warnings
  • cargo test: 598 passed

New tests drive the workflow directly and inject no input. Not verified in the running app.

🤖 Generated with Claude Code

@enaboapps enaboapps added this to the v1.0.0-rc.17 milestone Sep 28, 2026
@enaboapps
enaboapps marked this pull request as ready for review September 28, 2026 08:50
@enaboapps
enaboapps force-pushed the 931-after-selection-keyboard-mouse branch from 04fb0a3 to c00f965 Compare September 28, 2026 10:33
Base automatically changed from 931-after-selection-keyboard-mouse to main September 28, 2026 10:56
OwenMcGirr and others added 4 commits September 28, 2026 11:57
After a click, a closing command or a drag, the next point scan starts
by itself when the point scanner's Next scan is automatic. Scroll and
media items, which leave the menu open, follow the menu's choices.
Left alone, both behave as before.

Closes #932

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review follow-up: a click may bring another window forward, which used
to end a scan in progress. A scan that followed a click by itself now
takes up the window in front until something is chosen in it. A menu
left alone keeps the direction it was turned to.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review follow-up: while another window is coming forward there may be
none in front. A scan that started by itself now skips that moment
instead of ending.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review follow-up: the wait for a window to come forward is bounded, so
scanning cannot freeze. After a second it ends with the usual message.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@enaboapps
enaboapps force-pushed the 932-after-selection-menu-point branch from 57c9f35 to 57e84e5 Compare September 28, 2026 10:57
@enaboapps
enaboapps merged commit 0949dd8 into main Sep 28, 2026
6 checks passed
@enaboapps
enaboapps deleted the 932-after-selection-menu-point branch September 28, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply after-selection preferences in the action menu and point scan

2 participants