Repository navigation
Apply after-selection preferences in the action menu and point scan - #938
Merged
Merged
Conversation
enaboapps
marked this pull request as ready for review
September 28, 2026 08:50
This was referenced Sep 28, 2026
enaboapps
force-pushed
the
931-after-selection-keyboard-mouse
branch
from
September 28, 2026 10:33
04fb0a3 to
c00f965
Compare
After a click, a closing command or a drag, the next point scan starts by itself when the point scanner's Next scan is automatic. Scroll and media items, which leave the menu open, follow the menu's choices. Left alone, both behave as before. Closes #932 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review follow-up: a click may bring another window forward, which used to end a scan in progress. A scan that followed a click by itself now takes up the window in front until something is chosen in it. A menu left alone keeps the direction it was turned to. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review follow-up: while another window is coming forward there may be none in front. A scan that started by itself now skips that moment instead of ending. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review follow-up: the wait for a window to come forward is bounded, so scanning cannot freeze. After a second it ends with the usual message. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
enaboapps
force-pushed
the
932-after-selection-menu-point
branch
from
September 28, 2026 10:57
57c9f35 to
57e84e5
Compare
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #932
Part of #935. Stacked on #937, which is stacked on #936.
Change
Remote scanning validation needs no change. Wait needs Select exactly as the pass limit pause already does.
No settings UI yet, so users see no change until #933. No persisted schema or protocol change.
Known limits
Only the window in front is taken up, not the work area. A click that changes the work area, such as entering a fullscreen space or hiding the taskbar, still ends the scan that followed.
A window that appears after the user has already chosen a line in the new scan ends that scan with the usual message. No click lands on the wrong window.
While no window is in front, a scan that started by itself holds still for up to a second in all, then ends with the usual message. A switch press in that moment is not acted on.
Validation at 57c9f35
All run locally on Windows and passing:
npm run lint,npm test,npm run buildcargo fmt --checkcargo clippy --all-targets -- -D warningscargo test: 598 passedNew tests drive the workflow directly and inject no input. Not verified in the running app.
🤖 Generated with Claude Code