Repository navigation
Add after-selection options to scanning settings - #939
Merged
Merged
Conversation
enaboapps
marked this pull request as ready for review
September 28, 2026 08:57
enaboapps
force-pushed
the
932-after-selection-menu-point
branch
from
September 28, 2026 10:57
57c9f35 to
57e84e5
Compare
After a selection and Start from appear under More options, shared and for each scanner. A scanner shows what it will do, so its usual behaviour stands in where nothing has been chosen. They replace the keyboard's After typing, whose saved value remains the keyboard's usual behaviour. Closes #933 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review follow-up: the shared After a selection stays available while shared automatic scanning is off, since point scanning and scanners with their own setting use it. The notes say when the keyboard waits because of a setting saved earlier. Labels read Keep scanning and Start again from. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
enaboapps
force-pushed
the
933-after-selection-settings
branch
from
September 28, 2026 11:20
1832993 to
6d967ec
Compare
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #933
Part of #935. Stacked on #938, #937 and #936.
Change
Two option groups under More options in Scanning settings, in the shared view and for each scanner.
Differences from the issue
keyboardWaitAfterTypingis not rewritten to false. The backend already ignores it once the keyboard or the shared value has a choice, and rewriting it needed two saves for one press.Validation at 1832993
All run locally on Windows and passing:
npm run lintnpm test: 247 UI tests and 5 updater testsnpm run buildThe shared view was checked in a screenshot at desktop width. Not checked: the scanner views in a screenshot, dark mode, narrow widths, and the running app.
🤖 Generated with Claude Code