Skip to content

Add after-selection options to scanning settings - #939

Merged
enaboapps merged 2 commits into
mainfrom
933-after-selection-settings
Sep 28, 2026
Merged

enaboapps merged 2 commits into
mainfrom
933-after-selection-settings

Conversation

@enaboapps

@enaboapps enaboapps commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Closes #933

Part of #935. Stacked on #938, #937 and #936.

Change

Two option groups under More options in Scanning settings, in the shared view and for each scanner.

Group Shared view A scanner's view
After a selection Usual for each scanner, Keep scanning, Wait for Select Keep scanning, Wait for Select
Start again from Usual for each scanner, The beginning, Where I selected The beginning, Where I selected
  • A scanner's view shows what that scanner will do. Where nothing is chosen, its usual behaviour is shown as pressed and marked Default.
  • Point scanning has no Start from, because a point scan always starts from its beginning.
  • In a scanner's view, After a selection is disabled while that scanner is not automatic, except for Point scanning. The shared one is always available.
  • The notes say when the keyboard waits because of the setting saved earlier.
  • The keyboard's After typing control is removed. A saved Wait for Select stays as the keyboard's usual behaviour, and choosing either option for the keyboard overrides it.

Differences from the issue

  • The saved keyboardWaitAfterTyping is not rewritten to false. The backend already ignores it once the keyboard or the shared value has a choice, and rewriting it needed two saves for one press.
  • Reset scanning overrides returns the keyboard to that saved behaviour, and the view shows it.

Validation at 1832993

All run locally on Windows and passing:

  • npm run lint
  • npm test: 247 UI tests and 5 updater tests
  • npm run build

The shared view was checked in a screenshot at desktop width. Not checked: the scanner views in a screenshot, dark mode, narrow widths, and the running app.

🤖 Generated with Claude Code

@enaboapps enaboapps added this to the v1.0.0-rc.17 milestone Sep 28, 2026
@enaboapps
enaboapps marked this pull request as ready for review September 28, 2026 08:57
@enaboapps
enaboapps force-pushed the 932-after-selection-menu-point branch from 57c9f35 to 57e84e5 Compare September 28, 2026 10:57
Base automatically changed from 932-after-selection-menu-point to main September 28, 2026 11:19
OwenMcGirr and others added 2 commits September 28, 2026 12:20
After a selection and Start from appear under More options, shared and
for each scanner. A scanner shows what it will do, so its usual
behaviour stands in where nothing has been chosen. They replace the
keyboard's After typing, whose saved value remains the keyboard's
usual behaviour.

Closes #933

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review follow-up: the shared After a selection stays available while
shared automatic scanning is off, since point scanning and scanners
with their own setting use it. The notes say when the keyboard waits
because of a setting saved earlier. Labels read Keep scanning and
Start again from.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@enaboapps
enaboapps force-pushed the 933-after-selection-settings branch from 1832993 to 6d967ec Compare September 28, 2026 11:20
@enaboapps
enaboapps merged commit 8f87c55 into main Sep 28, 2026
6 checks passed
@enaboapps
enaboapps deleted the 933-after-selection-settings branch September 28, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add after-selection options to scanning settings

2 participants