Apply after-selection preferences in the keyboard and mouse panel - #937
Merged
Merged
Conversation
enaboapps
marked this pull request as ready for review
September 28, 2026 08:50
This was referenced Sep 28, 2026
After a key, a suggestion or a mouse action, scanning starts from the beginning or from the item just selected, and moves by itself or waits for Select, as chosen. A stopped move or scroll follows the same choice. Changing page, leaving the panel and failures are unchanged. Closes #931 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review follow-up: a failed mouse action no longer resumes at the failed key, and a chosen suggestion no longer leaves the highlight in a row whose new suggestions are held back. Staying at a selection keeps the chosen direction, and a display change keeps a wait. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
enaboapps
force-pushed
the
931-after-selection-keyboard-mouse
branch
from
September 28, 2026 10:33
04fb0a3 to
c00f965
Compare
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #931
Part of #935. Stacked on #936; review that first.
Change
The keyboard and the mouse panel now follow the two after-selection preferences.
PointSettingsno longer carries the separate flag.There is no settings UI yet, so users see no change until #933. No persisted schema or protocol change in this PR.
Validation at 04fb0a3
All run locally on Windows and passing:
npm run lint,npm test,npm run buildcargo fmt --checkcargo clippy --all-targets -- -D warningscargo test: 594 passedNew tests use the scanners directly and inject no input. Not verified in the running app.
🤖 Generated with Claude Code