Skip to content

Apply after-selection preferences in the keyboard and mouse panel - #937

Merged
enaboapps merged 2 commits into
mainfrom
931-after-selection-keyboard-mouse
Sep 28, 2026
Merged

enaboapps merged 2 commits into
mainfrom
931-after-selection-keyboard-mouse

Conversation

@enaboapps

@enaboapps enaboapps commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Closes #931

Part of #935. Stacked on #936; review that first.

Change

The keyboard and the mouse panel now follow the two after-selection preferences.

Preference Value Behaviour after a key, suggestion or mouse action
Start from Standard or Beginning First row, as before
Start from Selection The same row and item
Next scan Standard or Automatic Moves after one full interval, as before
Next scan Wait Waits for Select, then continues from the chosen place
  • With Selection, arriving suggestions do not pull the highlight to the suggestion row.
  • A repeating move or scroll stopped by a switch follows the same preferences.
  • Wait has no effect when automatic scanning is off.
  • Unchanged: page, dock and position keys, modifier keys, leaving the panel, failures, and a pause from the pass limit. These start from the first row. So does a chosen suggestion, because its row is replaced.
  • A repeat ended by a screen change or by turning repeat off starts from the first row, since no switch was pressed.
  • The keyboard still tracks its wait in its own flag, separate from the shared scanner's.
  • One change under default preferences: a display being added or removed no longer restarts the mouse panel's Movement page, whose keys do not depend on displays. The highlight, a pause and a failure message now stay as they were.
  • A saved wait after typing keeps working through the resolved preference. PointSettings no longer carries the separate flag.

There is no settings UI yet, so users see no change until #933. No persisted schema or protocol change in this PR.

Validation at 04fb0a3

All run locally on Windows and passing:

  • npm run lint, npm test, npm run build
  • cargo fmt --check
  • cargo clippy --all-targets -- -D warnings
  • cargo test: 594 passed

New tests use the scanners directly and inject no input. Not verified in the running app.

🤖 Generated with Claude Code

@enaboapps enaboapps added this to the v1.0.0-rc.17 milestone Sep 28, 2026
@enaboapps
enaboapps marked this pull request as ready for review September 28, 2026 08:50
Base automatically changed from 930-after-selection-model to main September 28, 2026 10:33
OwenMcGirr and others added 2 commits September 28, 2026 11:33
After a key, a suggestion or a mouse action, scanning starts from the
beginning or from the item just selected, and moves by itself or waits
for Select, as chosen. A stopped move or scroll follows the same
choice. Changing page, leaving the panel and failures are unchanged.

Closes #931

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review follow-up: a failed mouse action no longer resumes at the failed
key, and a chosen suggestion no longer leaves the highlight in a row
whose new suggestions are held back. Staying at a selection keeps the
chosen direction, and a display change keeps a wait.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@enaboapps
enaboapps force-pushed the 931-after-selection-keyboard-mouse branch from 04fb0a3 to c00f965 Compare September 28, 2026 10:33
@enaboapps
enaboapps merged commit 19211aa into main Sep 28, 2026
6 checks passed
@enaboapps
enaboapps deleted the 931-after-selection-keyboard-mouse branch September 28, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply after-selection preferences in the keyboard and mouse panel

2 participants