Skip to content

WIRE C2: public v8 ACK edits real native PCM and matches accepted EdgeId snapshot - #387

Merged
masarray merged 1 commit into
milestone/m5-universal-channelid-vst3-lease-migration-20261101from
work/wire-c2-native-v8-pcm-loop-20261104
Nov 4, 2026
Merged

masarray merged 1 commit into
milestone/m5-universal-channelid-vst3-lease-migration-20261101from
work/wire-c2-native-v8-pcm-loop-20261104

Conversation

@masarray

@masarray masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner

ENGINE C2 — real native PCM loop through existing v8 bridge

No new DSP/graph/compatibility layer. Extends the existing JUCE native CTest with DynamicAcceptedSession as a real PCM publisher rather than only mocking route authorization: physical impulse at sample 11, concurrent direct SOURCE→MAIN and nested SOURCE→VIA→MAIN graph, project exact accepted native graph as v8 snapshot, submit APPLY_WIRE_TRANSACTION REMOVE with exact focused EdgeId through LiveConsoleBridgeV6, execute DynamicAcceptedSession::wireTransaction with output armed against same physical request, assert ACCEPTED graph/roster revisions, render PCM again at same sample index with only selected direct MAIN path removed, and verify post-ACK accepted graph.edges[] and stale command rollback. Keeps original M4/FX regression and v8 existing mocks.

This remains C++ native fake-device integration, not hardware ASIO/WASAPI FAT, vendor Show parity or user UAT. Preserve GUI CSS/visual and one callback. Require exact SHA Windows Native MSVC/CTest PASS before integration into ENGINE #266.

masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

FINAL OVERRIDE / RETRACTION OF PREVIOUS /preview-v2/ DIRECTION (2026-11-04). The user's ONLY approved GUI is https://masarray.github.io/arsonmix/preview/ — NOT bare /preview-v2/. Previous agent statements suggesting /preview-v2/ is product authority were wrong and MUST NOT guide work. The actual /preview/ GUI is the assembly of internal HTML/WIRE/fader/FX source with approved PNG MUTE/SOLO/PFL CSS/JS/sprite (site/preview-buttons/assets). Pages publication now serves just /preview/; legacy /preview-v2, /preview-buttons and Vxx paths are redirect-only. Native Windows EXE must embed the EXACT generated /preview/ assembled HTML/assets and preserve every visual/gesture, then connect one native accepted v8 Snapshot/Intent/ACK adapter and genuine PCM/VST3. NO alternate renderer (web/index, web/mixer-layout old shell, web/console-native). Reference issue #389, AGENTS.md and docs/workstreams/HANDOFF_APPROVED_PREVIEW_V2_NATIVE_20261104.md (historical filename; content corrected). Do not merge old #271/#356 visual UI. Engine #266/#387 continues ONLY as native audio work, FAT #270 gates exact compiled GUI and PCM.

@masarray
masarray marked this pull request as ready for review November 4, 2026 19:23
@masarray
masarray merged commit 168b1a2 into milestone/m5-universal-channelid-vst3-lease-migration-20261101 Nov 4, 2026
1 check passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T19:25:01.001257Z 55d697d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

M2 consumer boundary now in PR #395: exact approved /preview/ native adapter parses decimal uint64 ChannelId and rejects all demo browser audio mutations, and requires intent ACK followed by matching native device epoch / graph revision / roster revision snapshot before applying state. This is not a second WIRE graph. Please expose stable native ChannelId→explicit GUI presentation binding and accepted EdgeId graph only from installed JUCE PCM callback. Do not rely on demo strip index/legacy M4 name or invent physical input mappings. Until real graph capabilities are admitted, M2 consumer remains fail-closed; merge engine #387 with #266 producer, then connect to same M2 socket (no new GUI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant