Repository navigation
fix: guaranteed negative ACK and retry for Routing APPLY during Studio IO - #152
Conversation
…outing_ui_contract_test.mjs
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Cross-thread coordination: PR #151 was independently opened from the same |
Ports the focused implementation from stale #147 onto current production routing
main@f997fb3cwithout replacing its integrated workspace. The older PR currently conflicts when merged.Functional fix: on native Studio backup / Show IO rejection of
routingDryApply, emitarMixRoutingLabAck(ok=false)with authoritative unchanged routing state so UI releases pending state and preserves draft for retry. Patch preflight validates device epoch/ports before setting pending. No second engine or callback edits.Regression: existing Chromium smoke gets a negative-ACK/retry path and native contract asserts upstream rejection sends the ACK. No GUI styling changes, no VST3/Orbit code changes, no reintroduction of LAB user mode.
Review/merge gates: exact PR head Windows MSVC+CTest, Chromium UI smoke, and live head-source diff. Zero-VST physical hardware FAT #15 remains open, not claimed by this PR. Supersedes #147 after verification.