Skip to content

fix: guaranteed negative ACK and retry for Routing APPLY during Studio IO - #152

Merged
masarray merged 4 commits into
mainfrom
fix/r1-ack-rebased-production-20261029
Oct 29, 2026
Merged

masarray merged 4 commits into
mainfrom
fix/r1-ack-rebased-production-20261029

Conversation

@masarray

Copy link
Copy Markdown
Owner

Ports the focused implementation from stale #147 onto current production routing main@f997fb3c without replacing its integrated workspace. The older PR currently conflicts when merged.

Functional fix: on native Studio backup / Show IO rejection of routingDryApply, emit arMixRoutingLabAck(ok=false) with authoritative unchanged routing state so UI releases pending state and preserves draft for retry. Patch preflight validates device epoch/ports before setting pending. No second engine or callback edits.

Regression: existing Chromium smoke gets a negative-ACK/retry path and native contract asserts upstream rejection sends the ACK. No GUI styling changes, no VST3/Orbit code changes, no reintroduction of LAB user mode.

Review/merge gates: exact PR head Windows MSVC+CTest, Chromium UI smoke, and live head-source diff. Zero-VST physical hardware FAT #15 remains open, not claimed by this PR. Supersedes #147 after verification.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T11:13:16.029374Z 3cb9c88 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

Cross-thread coordination: PR #151 was independently opened from the same main@f997fb3 for this exact Studio-busy routing ACK defect. Both Chromium heads are green and both Windows heads are still running. Please merge only one exact-head green implementation and mark the other superseded; do not combine or overwrite current web/monitor.js. #151 additionally asserts a second APPLY is emitted after reject–retry. The distinct production-graph milestone remains issue #149.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant