Repository navigation
R0B B1: de-click CH1 FX MOVE in live 10CH+4AUX routing - #153
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#149 R0B — executable native slice B1 (not full product consolidation)
G0 routing ACK #152 has merged. This PR is independent, touching only
src/LiveAudioEngine.h,tests/live_graph_contract_test.mjs, and focused docs. Current native 10CH/4AUX routing already reuses the original CH1 vendor FX processors via R0A, butmoveSlot()rejects any MOVE while routing is active even though its atomic physical-slot order can be read in that callback. This change allows that same CH1 rack MOVE under one routing callback and the existing two-bufferFxMoveRampde-click: fade to zero, publish order (release), fade up next block.Safety: CH1 vendor instances/Orbit/editors/tails are not recreated or moved; output-ramped PCM is sent to the existing MASTER LUFS/dBTP analyzer and peak publication. No new callback, hardware reopen, plugin state calls, allocation, mutex, UI work, or new timers on the real-time path. Independent-clock mode remains blocked. Other-channel/AUX FX state and routing ACK unchanged. Device epoch and native route graph remain in their existing owner.
Regression: native engine graph contract specifically checks the routed two-phase publication and meter order. Existing
fx_order_atomic_test.cppand R0A/10CH regression remain. Request one exact-head canonical Windows MSVC+CTest and existing Chromium as relevant, no matrix or speculative reruns.Not claimed: This does not implement ADD/REMOVE/SHOW lifecycle with a shared prepared owner or default always-on 10CH startup. Those are next #149 slices. Physical #15 ASIO/WASAPI clean-sound FAT still required. Detailed scope:
docs/R0B_CH1_FX_MOVE_NATIVE_ROUTING_20261029.md.Commits b69cc50 + 19da114, based on main f997; GitHub compare confirms three disjoint changed files against merged G0 main.