Skip to content

R0B B1: de-click CH1 FX MOVE in live 10CH+4AUX routing - #153

Merged
masarray merged 3 commits into
mainfrom
feat/r0b-ch1-fx-move-routing-20261029
Oct 29, 2026
Merged

masarray merged 3 commits into
mainfrom
feat/r0b-ch1-fx-move-routing-20261029

Conversation

@masarray

Copy link
Copy Markdown
Owner

#149 R0B — executable native slice B1 (not full product consolidation)

G0 routing ACK #152 has merged. This PR is independent, touching only src/LiveAudioEngine.h, tests/live_graph_contract_test.mjs, and focused docs. Current native 10CH/4AUX routing already reuses the original CH1 vendor FX processors via R0A, but moveSlot() rejects any MOVE while routing is active even though its atomic physical-slot order can be read in that callback. This change allows that same CH1 rack MOVE under one routing callback and the existing two-buffer FxMoveRamp de-click: fade to zero, publish order (release), fade up next block.

Safety: CH1 vendor instances/Orbit/editors/tails are not recreated or moved; output-ramped PCM is sent to the existing MASTER LUFS/dBTP analyzer and peak publication. No new callback, hardware reopen, plugin state calls, allocation, mutex, UI work, or new timers on the real-time path. Independent-clock mode remains blocked. Other-channel/AUX FX state and routing ACK unchanged. Device epoch and native route graph remain in their existing owner.

Regression: native engine graph contract specifically checks the routed two-phase publication and meter order. Existing fx_order_atomic_test.cpp and R0A/10CH regression remain. Request one exact-head canonical Windows MSVC+CTest and existing Chromium as relevant, no matrix or speculative reruns.

Not claimed: This does not implement ADD/REMOVE/SHOW lifecycle with a shared prepared owner or default always-on 10CH startup. Those are next #149 slices. Physical #15 ASIO/WASAPI clean-sound FAT still required. Detailed scope: docs/R0B_CH1_FX_MOVE_NATIVE_ROUTING_20261029.md.

Commits b69cc50 + 19da114, based on main f997; GitHub compare confirms three disjoint changed files against merged G0 main.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T11:24:14.004666Z 19da114 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit eb94203 into main Oct 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant