Skip to content

R1 hardening: guaranteed native routing rejection ACK during Studio backup - #147

Closed
masarray wants to merge 1 commit into
mainfrom
fix/r1-native-routing-busy-ack-20261029
Closed

masarray wants to merge 1 commit into
mainfrom
fix/r1-native-routing-busy-ack-20261029

Conversation

@masarray

Copy link
Copy Markdown
Owner

Follow-up to merged R1 #146. Fixes a real pending-state deadlock: while native Shows/Studio backup busy, Main.cpp rejects routingDryApply before the normal handler, previously without any arMixRoutingLabAck, leaving UI APPLY disabled. Emit one fail-closed negative ACK with unchanged authoritative status and reason. UI enters pending only after physical-port/epoch/stereo/output-mute synchronous gates. Regression adds native code contract and Playwright rejected-ACK/retry. No RT audio code, callback, FX/Orbit, device or GUI visual changes; require exact-head Windows/Chromium before merge.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-29T09:31:17.425496Z 904c40c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

Superseded by #152. This original branch conflicts with merged premium R0 Routing workspace when actually merging into latest main (GitHub returned merge-conflict 405 despite stale mergeability metadata). All four functional/test changes were ported in isolation to a fresh main@f997fb3c branch in #152, without overwriting current routing CSS/GUI. #152 Chromium PASS; Windows native CI is required before final merge. Closing this stale PR to prevent duplicate/conflicting integration; no feature dropped.

@masarray masarray closed this Oct 29, 2026
masarray added a commit that referenced this pull request Oct 29, 2026
* fix(routing): port reviewed #147 src/Main.cpp on latest main

* fix(routing): port reviewed #147 web/monitor.js on latest main

* test(routing): regression rejected ACK and pending retry tests/live_routing_ui_contract_test.mjs

* test(routing): regression rejected ACK and pending retry tests/ui_smoke.py

Copy link
Copy Markdown
Owner Author

Superseded by merged #152 (main squash 72a4bfc). Reviewed changed files: the same upstream routing rejection ACK and UI pending/retry semantics were selectively ported onto current R0/R1 workspace, avoiding stale monitor.js overlap. Exact-head Windows and Chromium for #152 passed. No unique unmerged functional requirement found in this old patch; R0B is separately tracked in #149.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant