Repository navigation
R0: premium Routing workspace unified with main mixer, zero-hover grid and lazy native controls - #148
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92cc07731d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if(event.target.closest('[data-view]:not([data-view="SIGNAL FLOW"]),[data-my-sounds],[data-plugin-manager],[data-native-action="audioSetup"],#arSignalOpen')) | ||
| routeOverlay.classList.remove("open"); |
There was a problem hiding this comment.
Close routing when navigating through the left-rail tabs
With ROUTING open, clicking the now-accessible CHANNELS or FX CHAINS left-rail tab changes the underlying view but leaves the routing workspace covering it. Those buttons use data-side, which this selector does not match, while their handler in web/app.js calls setView('MIX') or setView('FX RACK'). Consequently, the selected navigation state changes without showing the requested workspace until the user separately closes routing. Include these navigation controls in the dismissal logic, or dismiss routing centrally when the view changes.
Useful? React with 👍 / 👎.
Baseline and non-regression
Built from latest main
3ab35d3including R1 real native INPUT PATCH matrix (PR #146) and P0 passive-hover fix. No second routing engine, no replacement matrix, no JUCE audio/FX/Orbit changes. Concurrent PR #147 modifies native ACK error handling; this PR never touchessrc/Main.cppor native action semantics.Productized Routing R0
Not in R0
Internal send matrix, shared searchable native FX picker and true hardware OUTPUT patchbay remain later gates; the existing INTERNAL sends list and real native data model are retained. No fabricated output capability. Physical WebView2 DPI and low-GPU p95 remain separately measured FAT.
Architecture/acceptance:
docs/R0_PREMIUM_ROUTING_WORKSPACE_20261029.md. Merge only after exact-head existing UI Chromium and Windows tests PASS.