Skip to content

R0: premium Routing workspace unified with main mixer, zero-hover grid and lazy native controls - #148

Merged
masarray merged 3 commits into
mainfrom
feature/r0-routing-workspace-integration-20261029
Oct 29, 2026
Merged

masarray merged 3 commits into
mainfrom
feature/r0-routing-workspace-integration-20261029

Conversation

@masarray

Copy link
Copy Markdown
Owner

Baseline and non-regression

Built from latest main 3ab35d3 including R1 real native INPUT PATCH matrix (PR #146) and P0 passive-hover fix. No second routing engine, no replacement matrix, no JUCE audio/FX/Orbit changes. Concurrent PR #147 modifies native ACK error handling; this PR never touches src/Main.cpp or native action semantics.

Productized Routing R0

  • Change the centred 1110px technical dialog to a full-size native routing workbench exactly beneath the main toolbar and beside the existing left rail, above status footer. Uses existing steel/graphite/turquoise and semantic green active controls. No modal dimmer, blur, heavy glow, animation or passive hover repaint.
  • Preserve honest 10-channel × 8 paginated verified-hardware INPUT PATCH matrix with draft/live/removed states, stereo L/R, hardware epoch, read-only output and native ACK-only activation. Keyboard focus and press remain visible.
  • Single consolidated native-only CSS definition replaces stacked historical routing visual overrides. Remove the per-cell pointerover DOM class toggles and related shadow/hover declarations.
  • Lazy INTERNAL rendering: don't eagerly create 10 channel and 4 AUX FX dropdowns on opening INPUT PATCH; only render that panel on explicit tab entry. Native catalog changes only refresh it while visible. No additional listeners, animation frame loops or timers.
  • Escape and navigating to other top-level sections close workspace; leave the rest of main mixer untouched.
  • Tests extend existing Chromium native mock UI smoke with workspace geometry, inert hover, lazy internal DOM and keep R1 matrix/ACK/hotplug coverage; add native UI contract tests. No new CI matrix.

Not in R0

Internal send matrix, shared searchable native FX picker and true hardware OUTPUT patchbay remain later gates; the existing INTERNAL sends list and real native data model are retained. No fabricated output capability. Physical WebView2 DPI and low-GPU p95 remain separately measured FAT.

Architecture/acceptance: docs/R0_PREMIUM_ROUTING_WORKSPACE_20261029.md. Merge only after exact-head existing UI Chromium and Windows tests PASS.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T09:59:08.374716Z 92cc077 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 92cc07731d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/monitor.js
Comment on lines +564 to +565
if(event.target.closest('[data-view]:not([data-view="SIGNAL FLOW"]),[data-my-sounds],[data-plugin-manager],[data-native-action="audioSetup"],#arSignalOpen'))
routeOverlay.classList.remove("open");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Close routing when navigating through the left-rail tabs

With ROUTING open, clicking the now-accessible CHANNELS or FX CHAINS left-rail tab changes the underlying view but leaves the routing workspace covering it. Those buttons use data-side, which this selector does not match, while their handler in web/app.js calls setView('MIX') or setView('FX RACK'). Consequently, the selected navigation state changes without showing the requested workspace until the user separately closes routing. Include these navigation controls in the dismissal logic, or dismiss routing centrally when the view changes.

Useful? React with 👍 / 👎.

@masarray
masarray merged commit 4d14251 into main Oct 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant