Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions docs/R0_PREMIUM_ROUTING_WORKSPACE_20261029.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# R0 — Premium native routing workspace reconciliation (2026-10-29)

Baseline: `main@3ab35d3f3a8f8afef2a5909de531ab98618d61ba`. PR #146 already delivered an ACK-aware real INPUT PATCH matrix with eight visible hardware columns, stereo L/R guards and device epoch safety. R0 **reuses it** instead of shipping another matrix or replacing the accepted live mixer.

## Product implementation
- The routing surface now fills the existing **workbench** below the approved 56px ArSonMix toolbar, beside the 156px channel rail, above the 24px status/footer. No fullscreen dimmer, blocking center dialog, glass blur, unnecessary margin or fake product shell.
- A single source-owned native `monitor.js` style block replaces stacked R1 visual overrides with the same graphite/steel/turquoise/green active semantics as the mixer. No passive hover CSS, per-cell column JS pointerover scan or additional animation/RAF/timer. Keyboard focus remains visible.
- Compact INPUT PATCH tabs, 10 CH × eight paginated physical input cells, LIVE/draft/removed meaning, device port names, and read-only hardware OUTPUT keep native authoritative ACK and fail-closed APPLY.
- INTERNAL / SENDS is **lazy**: 10 channel VST3 dropdowns and 4 AUX VST3 dropdowns are not populated on INPUT open or when catalog status changes while that tab is hidden. It is rendered on explicit selection and otherwise retained with existing 10+4 controls and PRE/POST sends. Full internal send matrix and single shared plugin picker are later R1/R2 optimization gates, not falsely marked delivered here.
- APPLY, stale device detection, MUTE OUTPUT fence, native revision ACK, draft revert, channel values, live FX instance preservation, DRY Show eligibility, and all engine files are untouched. Escape and toolbar navigation close the workspace without changing routes.

## Validation
- Chromium native-bridge smoke adds precise workspace geometry and screenshot-compatible checks at 1680×920 and 1440×820, verifies no eager INTERNAL construction and inert hover, on top of the existing R1 matrix, ACK, stereo and device swap tests.
- Native routing Node contract checks workspace region, preserved ACK and absence of hover hooks.
- This is an independent GUI PR; Windows CI stays on canonical main/feature pipelines. Real ASIO/WASAPI FAT, WebView2 low-GPU p95 input-to-paint, and physical no-crackle qualification remain separate from browser smoke.

No changes to `web/styles-src`, `web/app.js`, `src/Main.cpp`, callback audio code, Plugin Vault, or any VST3/Orbit processing.
13 changes: 13 additions & 0 deletions tests/live_routing_ui_contract_test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -192,3 +192,16 @@ test("R1 matrix edits only device-bound draft and honors native revision ACK",()
assert.doesNotMatch(ui,/filter\s*:\s*blur\(/);
assert.match(ui,/document\.addEventListener\("click",event=>/);
});


test("R0 premium workspace is anchored to mixer chrome and lazily opens INTERNAL tab",()=>{
assert.match(ui,/role="region" aria-label="ArSonMix routing workspace"/);
assert.match(ui,/#arRoutingLabOverlay\{display:none;position:fixed;inset:62px 7px 30px 168px/);
assert.match(ui,/patchTab==="internal"\)drawRoutes\(\)/);
assert.match(ui,/if\(tab==="input"\)renderPatchMatrix\(\)/);
assert.doesNotMatch(ui,/arPatchCell:hover|arPatchColHover|hoveredPort/);
assert.doesNotMatch(ui,/backdrop-filter:|filter:blur\(/);
assert.match(ui,/event\.key!=="Escape"/);
assert.match(ui,/routingDryApply/);
assert.match(ui,/hydrateAcceptedRoute/);
});
24 changes: 24 additions & 0 deletions tests/ui_smoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -1260,6 +1260,30 @@ async def image_for(selector):
document.querySelectorAll('#arPatchGrid .arPatchChan').length};
}""")
assert patch_visual['rowCount']==10 and len(patch_visual['cols'])==8,patch_visual

# R0: real desktop-workspace geometry, not a centered modal. Its
# header, left rail and status bar stay reachable while editing.
workspace_layout=await native.evaluate("""()=>{
const panel=document.querySelector('#arRoutingLabPanel');
const cover=document.querySelector('#arRoutingLabOverlay');
const rect=cover.getBoundingClientRect();
const cs=getComputedStyle(cover);
return {role:panel.getAttribute('role'),
left:Math.round(rect.left),top:Math.round(rect.top),
width:Math.round(rect.width),height:Math.round(rect.height),
viewport:innerWidth,backdrop:cs.backdropFilter,
routeRows:document.querySelectorAll('#arRouteRows [data-route-row]').length}
}""")
assert workspace_layout['role']=='region',workspace_layout
assert 160<=workspace_layout['left']<=175 and 58<=workspace_layout['top']<=65,workspace_layout
assert workspace_layout['width']>workspace_layout['viewport']*.80,workspace_layout
assert workspace_layout['backdrop']=='none',workspace_layout
assert workspace_layout['routeRows']==0, "Input patch should not eagerly build 14 VST selectors"
normal_cell=native.locator('[data-patch-row="0"][data-patch-port="2"].arPatchCell')
idle_color=await normal_cell.evaluate('(e)=>getComputedStyle(e).backgroundColor')
await normal_cell.hover()
assert await normal_cell.evaluate('(e)=>getComputedStyle(e).backgroundColor')==idle_color

assert max(patch_visual['cols'])-min(patch_visual['cols'])<=1,patch_visual
assert all(58<=w<=140 for w in patch_visual['cols']),patch_visual
await native.screenshot(path=str(project/"native-input-patch-review-1680.png"))
Expand Down
Loading
Loading