Skip to content

fix(routing): reconcile R1 Studio-busy ACK with merged R0 workbench - #151

Closed
masarray wants to merge 1 commit into
mainfrom
fix/routing-ack-studio-busy-reconciled-20261029
Closed

masarray wants to merge 1 commit into
mainfrom
fix/routing-ack-studio-busy-reconciled-20261029

Conversation

@masarray

Copy link
Copy Markdown
Owner

Gate A / #147 reconciliation

Built from latest main f997fb3 (R0 premium workbench + R1 physical INPUT PATCH already merged), not from stale #147 UI. Reproduces the upstream native backup-busy rejection with no arMixRoutingLabAck, which leaves APPLY pending indefinitely.

  • One explicit ok:false native ACK with current authoritative route state and actionable error before returning the notice; no route graph change, no RT callback work.
  • R1 UI performs all synchronous physical-port/epoch/MUTE preflight before setting patchPending; rejected native ACK unlocks APPLY and retains the DRAFT for retry.
  • Add native contract and Chromium browser rejection→retry regression; preserve 10CH/4AUX, Orbit, existing CSS and visual design.

Gate / scope

No R0/R1 rerun, CSS generation or new audio graph. Check node --test tests/live_routing_ui_contract_test.mjs, Chromium UI smoke and Windows MSVC+CTest on this exact head. Physical zero-FX crackle #15 remains independently open. Once green, this supersedes the obsolete overlapping branch PR #147; R0B #149 remains next.

Based on main f997fb3; commit 04e411ede939645ced252b187c1c4a7701bd70da.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T11:11:48.937523Z 04e411e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

Superseded by merged #152 (main squash 72a4bfc): same Studio-busy native negative ACK, preflight-before-pending, preserved draft and Chromium reject/retry coverage. #152 passed exact-head Chromium and Windows+CTest. No duplicate merge or further CI required here. R0B remains #149.

@masarray masarray closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant