Repository navigation
🐛 dashboard: overview under-reports total open issues - #10648
Merged
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This was referenced Oct 5, 2026
clubanderson
added a commit
that referenced
this pull request
Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
This was referenced Oct 5, 2026
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
This was referenced Oct 5, 2026
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
clubanderson
force-pushed
the
fix/overview-open-issue-count
branch
from
October 5, 2026 17:42
ab294d1 to
bf6563b
Compare
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The Overview KPI labelled Total open issues was not using the raw repo totals from the server status payload. In
renderOverviewKPIs, it summed the Overview issue chart slices:repo.actionableIssues + repo.heldIssuesrepo.issuesbut intentionally kept out of agent-visible lists, such as hard human-gated labels, exempt/meta items, standing meta issues, and other filtered itemsFrontendRepo.Issues/FrontendRepo.PRs, so the current browser value and server history could disagreeGovernor numbers are different by design:
status.actionableNow.issues, derived fromrepo.actionableIssuesafter excluding waiting/done/blocked/draft bands.status.hold.total, issues and PRs carrying hold labels.So the dashboard was mixing a subset label with a total label. PRs happened to look right for the reported fleet because its filtered/hidden PR bucket was empty or small; the same frontend bug existed for PR totals too.
Current hivecommons/hive issue bucket check
Using the requested
gh issue listshape against the current 39 open hive issues and applying the code paths inpkg/github/client.go+pkg/dashboard/bands.go:hold/on-hold/hold/review)needs-human,needs-direction,needs-decision,needs-spec)meta-trackeretc.)The old KPI counted chart-visible tracked+held items, not all 39 raw open issues.
Fix
issues, with old-field fallbacks) instead of issue chart slices.prs) for consistency.Validation
gofmt -l src/pkg/dashboard/overview_kpi_sparklines_test.goreturned no files.AGENTS.md, did not run localgo test,go vet, or citation guards; CI is the validation source for this repo.