Skip to content

🐛 dashboard: surface alerts section at top of page - #10640

Merged
clubanderson merged 2 commits into
v5from
fix/alert-section-top
Oct 5, 2026
Merged

🐛 dashboard: surface alerts section at top of page#10640
clubanderson merged 2 commits into
v5from
fix/alert-section-top

Conversation

@clubanderson

@clubanderson clubanderson commented Oct 5, 2026

Copy link
Copy Markdown
Member

Closes #10635

Summary

  • move the GitHub auth and rate-limit alert containers into the pinned #dash-notices top-of-page banner area
  • keep the light-mode rate-limit selector working after the move
  • add a static dashboard test asserting GitHub alerts render before the first content section
  • add a changelog fragment

Root cause

The GitHub API auth/rate-limit alert elements lived after #hive-dashboard-root, below all dashboard content and just before the sidebar markup. Since they were not inside the pinned #dash-notices area (which the layout code keeps above reorderable dashboard sections), active rate-limit alerts rendered at the bottom of the page.

Validation

  • gofmt -w src/pkg/dashboard/dashboard_alerts_placement_test.go
  • Not run locally: repository AGENTS.md directs agents not to run go build/go test; CI is the verification path.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 5, 2026
@kubestellar-prow

kubestellar-prow Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2026
clubanderson added a commit that referenced this pull request Oct 5, 2026
@clubanderson @github-actions
changelog: fragment for #10640
94ab06c 
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
Merged
@github-actions

github-actions Bot commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#10613 ✨ dashboard: Review Queue collapsed row shows a priority-split history sparkline same files src/pkg/dashboard/static/index.html
#10589 🐛 fix: route reporter-trust waits through poller relay same files src/pkg/dashboard/static/index.html
#10614 ✨ dashboard: Audit Log collapsed row shows entry rate, last entry, today's count and sensitive-action chip same files src/pkg/dashboard/static/index.html
#10638 🐛 dashboard: Overview open-issue/PR totals explain their gap to the forge counts same files src/pkg/dashboard/static/index.html
#10619 ✨ dashboard: move project actions to toolbar same files src/pkg/dashboard/static/index.html
#10618 ✨ Improve collapsed Advisory and ACMM headers CONFLICT src/pkg/dashboard/webstatic/style_ratchet_test.go

This was referenced Oct 5, 2026
Merged
Merged
Merged
Merged
@clubanderson
clubanderson force-pushed the fix/alert-section-top branch from 94ab06c to 411ef9d Compare October 5, 2026 16:55
clubanderson added a commit that referenced this pull request Oct 5, 2026
@clubanderson @github-actions
changelog: fragment for #10640
b98d59a 
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
This was referenced Oct 5, 2026
Merged
Merged
Merged
Merged
Merged
Merged
@clubanderson
clubanderson force-pushed the fix/alert-section-top branch from b98d59a to 8f5f937 Compare October 5, 2026 17:09
clubanderson added a commit that referenced this pull request Oct 5, 2026
@clubanderson @github-actions
changelog: fragment for #10640
be0a1c0 
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@clubanderson
clubanderson force-pushed the fix/alert-section-top branch from be0a1c0 to f090cfd Compare October 5, 2026 17:10
clubanderson added a commit that referenced this pull request Oct 5, 2026
@clubanderson @github-actions
changelog: fragment for #10640
f443084 
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 5, 2026
This was referenced Oct 5, 2026
Merged
Merged
Merged
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 5, 2026
clubanderson and others added 2 commits October 5, 2026 13:32
@clubanderson
🐛 dashboard: surface alerts at top
1567367 
Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson @github-actions
changelog: fragment for #10640
7c46cb2 
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the fix/alert-section-top branch from f443084 to 7c46cb2 Compare October 5, 2026 17:32
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
Merged
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 5, 2026
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
Merged
@clubanderson
clubanderson merged commit 080696b into v5 Oct 5, 2026
63 of 64 checks passed
@clubanderson
clubanderson deleted the fix/alert-section-top branch October 5, 2026 17:56
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 dashboard: GitHub API rate-limit alert renders at bottom of page instead of top

1 participant

@clubanderson