Repository navigation
π dashboard: Overview open-issue/PR totals explain their gap to the forge counts - #10638
Merged
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
clubanderson
added a commit
that referenced
this pull request
Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
clubanderson
force-pushed
the
fix/total-open-counts-10629
branch
from
October 5, 2026 16:46
da8c540 to
90435db
Compare
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
clubanderson
added a commit
that referenced
this pull request
Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
clubanderson
force-pushed
the
fix/total-open-counts-10629
branch
from
October 5, 2026 16:49
014edbb to
dd621ee
Compare
clubanderson
added a commit
that referenced
this pull request
Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
This was referenced Oct 5, 2026
clubanderson
force-pushed
the
fix/total-open-counts-10629
branch
from
October 5, 2026 16:59
6c22542 to
f408eb3
Compare
clubanderson
added a commit
that referenced
this pull request
Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
This was referenced Oct 5, 2026
clubanderson
force-pushed
the
fix/total-open-counts-10629
branch
from
October 5, 2026 17:12
aa47922 to
7430c52
Compare
clubanderson
added a commit
that referenced
this pull request
Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
This was referenced Oct 5, 2026
clubanderson
force-pushed
the
fix/total-open-counts-10629
branch
from
October 5, 2026 17:30
5c01268 to
76a23a2
Compare
clubanderson
added a commit
that referenced
this pull request
Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
This was referenced Oct 5, 2026
clubanderson
added a commit
that referenced
this pull request
Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
clubanderson
force-pushed
the
fix/total-open-counts-10629
branch
from
October 5, 2026 17:59
d33e7f8 to
59cded7
Compare
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
clubanderson
force-pushed
the
fix/total-open-counts-10629
branch
from
October 5, 2026 18:06
59cded7 to
ce40fde
Compare
This was referenced Oct 5, 2026
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overviewTotalsto/api/status, scanner detail for hard-suppress/exempt issue filters, UI tooltips/sub-lines, docs, changelog, and regression coverage.Closes #10629
Trace / root cause
Before this PR the Overview cards were not forge totals. The browser built the card values from Overview band slices:
overviewIssueBandSlices()walksrepos[].actionableIssuesplusrepos[].heldIssues, whileoverviewPRBandSlices()walksrepos[].openPrsplusrepos[].heldPrs;renderOverviewKPIs()then summed those slices for the visible card values (src/pkg/dashboard/static/index.html:12482,src/pkg/dashboard/static/index.html:12521,src/pkg/dashboard/static/index.html:13162). Those arrays come from/api/status.repos[];FrontendRepo.ActionableIssues/OpenPrsare explicitly the automated-consumer/actionable sets, andHeldIssues/HeldPrsare display-only hold sets (src/pkg/dashboard/server.go:832).buildRepos()fills them from the scanner result and separately attachesWorkBreakdown/raw counts (src/pkg/dashboard/status_builder.go:1927).The scanner starts from GitHub open data on the existing scan tick: issues use
GET /repos/{owner}/{repo}/issues?state=openand then skip pull requests (src/pkg/github/issue_dependencies.go:59,src/pkg/github/client.go:1131); PRs usePullRequests.List(state=open)(src/pkg/github/client.go:1337). The filters before an issue reachesactionableIssuesare, in order: standing meta issues (hive/advisoryand dependency dashboards), hold labels (moved toheldIssues), governor exempt labels, hard-suppress labels (needs-human,needs-direction,needs-decision,needs-spec), reporter-trust triage for untrusted human reporters, thenproject.issue_filter.require_labels(src/pkg/github/client.go:1137,src/pkg/github/client.go:1156,src/pkg/github/client.go:1172,src/pkg/github/client.go:1200,src/pkg/github/client.go:1209). Bot-authored issues are not dropped merely for being bots; they are annotated withauthor_is_human/human acknowledgment for banding after admission (src/pkg/github/client.go:1216). PRs are counted from all open PRs, then hold labels move non-draft held PRs toheldPrs, exempt labels filter, drafts are counted as drafts but excluded fromopenPrs, and the rest enteropenPrs(src/pkg/github/client.go:1358,src/pkg/github/client.go:1365,src/pkg/github/client.go:1420,src/pkg/github/client.go:1425,src/pkg/github/client.go:1457). No age window or dedupe is applied in these count paths; multi-repo union is by the configured repo list. That explains the symptom: issues can be lower than GitHub because hard-suppressed/exempt/reporter-triage/meta issues were outside the Overview bands; PRs can be higher than the single GitHub repo header when the selected/configured repo set spans multiple repos, while drafts/filtered PRs explain gaps between forge totals and Overview bands.Fix choice
The configured repo set is the dashboard scope operators select, so the cards now show forge-open totals for that selected configured repo set. The server publishes all-repo
overviewTotalsfrom the scanner's cachedWorkBreakdownwithout adding a new poll, and the client recomputes the same totals from per-repo breakdowns when the Overview repo filter is narrowed (src/pkg/dashboard/overview_status.go:105,src/pkg/dashboard/static/index.html:13103,src/pkg/dashboard/static/index.html:13138,src/pkg/dashboard/static/index.html:13168). The sub-line explains the gap (tracked in Overview bands,held, and outside reasons such asneeds-direction,exempt,draft) and each card tooltip defines the count (src/pkg/dashboard/static/index.html:13148,src/pkg/dashboard/static/index.html:13179).Tests / validation
TestOverviewTotalsUseForgeCountsAndExplainScannerGap10629for held, hard-suppressed, bot-authored, draft, and multi-repo fixture coverage.overviewTotals, uses forge fields, and has tooltips/sub-line wiring.gofmt -landgit diff --checkperAGENTS.md; no localgo test,go build,go vet, or citation guard was run.