Forkpty replace

[RoniKishner]

What this PR does / why we need it:

replace pexpect.spawn with pty+subprocess to avoid forkpty

• Replace pexpect.spawn with pty.openpty() + subprocess.Popen to avoid deprecated os.forkpty() in Python 3.12+ multi-threaded processes
• Add _spawn_console() to create a pty pair and wrap the subprocess in pexpect.fdpexpect.fdspawn
• Add _terminate_proc() to cleanly shut down the subprocess, call it in both the connect error path and disconnect cleanup
• Simplify console_eof_sampler() — remove parameters, use _spawn_console() internally

Which issue(s) this PR fixes:

DeprecationWarning on test_vm_console

Special notes for reviewer:

The following warning was shown:
/tmp/pr-tests/.local/share/uv/python/cpython-3.14.5-linux-x86_64-gnu/lib/python3.14/pty.py:66: DeprecationWarning: This process (pid=110) is multi-threaded, use of forkpty() may lead to deadlocks in the child.

jira-ticket:

NONE

[RoniKishner]

/split-pr

[pull-apart]

Split complete. Open these pull requests:

• Refactor / cleanup: [split] Refactor / cleanup — from #21 #22
• Main changes: [split] Main changes — from #21 #23

[pull-apart]

/split-pr

[automation-flow-helper]

/split-pr

[pull-apart]

Split complete. Open these pull requests:

• Refactor / cleanup: [split] Refactor / cleanup — from #21 #24
• Main changes: [split] Main changes — from #21 #25

[RoniKishner]

/split-pr

[pull-apart]

To open the split PRs under your GitHub account (so you can edit and close them), please authorize the app.

Once authorized, the split will run automatically. The link expires in 1 hour; comment /split-pr again if it does.

[RoniKishner]

/split-pr

[pull-apart]

You need to wait 5 minutes before calling /split-pr again on this pull request (about 3 minutes remaining).

[pull-apart]

Split complete. Open these pull requests:

• Refactor / cleanup: [split] Refactor / cleanup — from #21 #31
• Main changes: [split] Main changes — from #21 #32

[RoniKishner]

/split-pr

[pull-apart]

You have reached the maximum daily limit for /split-pr in RoniKishner/openshift-virtualization-tests (3 uses per day per repository during the beta; you've used 0 today in this repo). Please wait about 15 hours until the limit resets at 2026-07-07 00:00 UTC.

[RoniKishner]

/split-pr

[pull-apart]

You have reached the maximum daily limit for /split-pr in RoniKishner/openshift-virtualization-tests (3 uses per day per repository during the beta; you've used 0 today in this repo). Please wait about 15 hours until the limit resets at 2026-07-07 00:00 UTC.

[RoniKishner]

/split-pr

[RoniKishner]

/split-pr

[pull-apart]

Your GitHub authorization has expired. The split PRs were created by the app bot instead of your account.

To have future splits opened under your account, please re-authorize the app.

[pull-apart]

Split complete. Open these pull requests:

• Refactor / cleanup: [split] Refactor / cleanup — from #21 #37
• Main changes: [split] Main changes — from #21 #38

[RoniKishner]

/split-pr

[pull-apart]

You need to wait 5 minutes before calling /split-pr again on this pull request (about 1 minute remaining).

[RoniKishner]

/split-pr

[pull-apart]

Split complete. Open these pull requests:

• Refactor / cleanup: [split] Refactor / cleanup — from #21 #39
• Main changes: [split] Main changes — from #21 #40

[RoniKishner]

/split-pr

[pull-apart]

Your GitHub authorization has expired. The split PRs were created by the app bot instead of your account.

To have future splits opened under your account, please re-authorize the app.

[pull-apart]

Split complete. Open these pull requests:

• Refactor / cleanup: [split] Refactor / cleanup — from #21 #41
• Main changes: [split] Main changes — from #21 #42

[RoniKishner]

/split-pr

[pull-apart]

To open the split PRs under your GitHub account (so you can edit and close them), please authorize the app.

Once authorized, the split will run automatically. The link expires in 1 hour; comment /split-pr again if it does.