Skip to content

[split] Main changes — from #21#42

Closed
pull-apart[bot] wants to merge 1 commit into
mainfrom
split-pr-21-1783491041-main
Closed

[split] Main changes — from #21#42
pull-apart[bot] wants to merge 1 commit into
mainfrom
split-pr-21-1783491041-main

Conversation

@pull-apart

@pull-apart pull-apart Bot commented Jul 8, 2026

Copy link
Copy Markdown

Automated split from #21.

Context

This is the main / behavior half of an automated split from #21.

Changes in this PR:

  • utilities/console.py: Added imports: pty, shlex, subprocess, pexpect.fdpexpect, TimeoutExpiredError
  • Added _proc attribute (subprocess.Popen) to Console class
  • Modified connect() to call self.console_eof_sampler() without arguments and added TimeoutExpiredError to exception handling
  • Modified connect() and disconnect() to call _terminate_proc() for cleanup
  • Modified disconnect() condition to check self._proc.poll() instead of child.terminated
  • Added new method _spawn_console() to create a pty pair and wrap subprocess.Popen in pexpect.fdpexpect.fdspawn
  • Added new method _terminate_proc() to gracefully or forcefully shut down the subprocess
  • Simplified console_eof_sampler() parameters and updated func to self._spawn_console
How this split maps your changes
  • Refactor branch (split-pr-21-1783491041-refactor): files classified as cleanup / mechanical work:
    • utilities/unittests/test_console.py
  • Main branch (split-pr-21-1783491041-main): files classified as feature / behavior work:
    • utilities/console.py

Merge order

Merge the refactor PR first if it touches shared files or would conflict with the main PR; then merge the main PR. Resolve conflicts in the usual way if both branches touch the same lines.

Refactor PR: #41

@RoniKishner RoniKishner closed this Jul 8, 2026
@RoniKishner RoniKishner deleted the split-pr-21-1783491041-main branch July 8, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant