Skip to content

[split] Refactor / cleanup — from #21#39

Closed
RoniKishner wants to merge 1 commit into
mainfrom
split-pr-21-1783450195-refactor
Closed

[split] Refactor / cleanup — from #21#39
RoniKishner wants to merge 1 commit into
mainfrom
split-pr-21-1783450195-refactor

Conversation

@RoniKishner

@RoniKishner RoniKishner commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Automated split from #21.

Context

This is the refactor / cleanup half of an automated split from #21.

Changes in this PR:

  • utilities/unittests/test_console.py: Added imports: subprocess, pytest
  • Added helper function _single_attempt_sampler for mocking TimeoutSampler
  • Updated test_console_disconnect_terminated_child to mock _proc and call console_eof_sampler without arguments
  • Updated test_console_eof_sampler_success assertions to reflect _spawn_console as function and removed command, timeout parameters
  • Added new tests for _spawn_console method (success, Popen failure, fdspawn failure, process termination on failure)
  • Added new tests for _terminate_proc method (running, already exited, timeout and kill)
  • Added test for connect error cleanup behavior
How this split maps your changes
  • Refactor branch (split-pr-21-1783450195-refactor): files classified as cleanup / mechanical work:
    • utilities/unittests/test_console.py
  • Main branch (split-pr-21-1783450195-main): files classified as feature / behavior work:
    • utilities/console.py

Merge order

Merge the refactor PR first if it touches shared files or would conflict with the main PR; then merge the main PR. Resolve conflicts in the usual way if both branches touch the same lines.

Main PR: #40

@pull-apart pull-apart Bot mentioned this pull request Jul 7, 2026
@RoniKishner RoniKishner closed this Jul 8, 2026
@RoniKishner RoniKishner deleted the split-pr-21-1783450195-refactor branch July 8, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant