Skip to content

[split] Main changes — from #21#40

Closed
RoniKishner wants to merge 1 commit into
mainfrom
split-pr-21-1783450195-main
Closed

[split] Main changes — from #21#40
RoniKishner wants to merge 1 commit into
mainfrom
split-pr-21-1783450195-main

Conversation

@RoniKishner

Copy link
Copy Markdown
Owner

Automated split from #21.

Context

This is the main / behavior half of an automated split from #21.

Changes in this PR:

  • utilities/console.py: Added imports: pty, shlex, subprocess, pexpect.fdpexpect
  • Modified import: TimeoutSampler now imports TimeoutExpiredError
  • Added instance attribute self._proc to store subprocess handle
  • Modified connect method to use _spawn_console and handle TimeoutExpiredError, pexpect.exceptions.ExceptionPexpect
  • Modified connect method to call _terminate_proc on connection failure
  • Modified disconnect method to check _proc.poll() instead of child.terminated
  • Modified disconnect method to call _terminate_proc in finally block
  • Added _spawn_console method to create pty pair and wrap subprocess in fdpexpect.fdspawn
  • Added _terminate_proc method for clean subprocess shutdown
  • Simplified console_eof_sampler method: removed parameters and now calls _spawn_console internally
How this split maps your changes
  • Refactor branch (split-pr-21-1783450195-refactor): files classified as cleanup / mechanical work:
    • utilities/unittests/test_console.py
  • Main branch (split-pr-21-1783450195-main): files classified as feature / behavior work:
    • utilities/console.py

Merge order

Merge the refactor PR first if it touches shared files or would conflict with the main PR; then merge the main PR. Resolve conflicts in the usual way if both branches touch the same lines.

Refactor PR: #39

@pull-apart pull-apart Bot mentioned this pull request Jul 7, 2026
@RoniKishner RoniKishner closed this Jul 8, 2026
@RoniKishner RoniKishner deleted the split-pr-21-1783450195-main branch July 8, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant