Skip to content

[split] Main changes — from #21#34

Closed
pull-apart[bot] wants to merge 1 commit into
mainfrom
split-pr-21-1783401787-main
Closed

[split] Main changes — from #21#34
pull-apart[bot] wants to merge 1 commit into
mainfrom
split-pr-21-1783401787-main

Conversation

@pull-apart

@pull-apart pull-apart Bot commented Jul 7, 2026

Copy link
Copy Markdown

Automated split from #21.

Context

This is the main / behavior half of an automated split from #21.

Changes in this PR:

  • utilities/unittests/test_console.py: Added extensive new unit tests for the _spawn_console method, covering success and various failure scenarios (Popen failure, fdspawn failure with process termination outcomes).
  • Added extensive new unit tests for the _terminate_proc method, testing scenarios like no process, process already exited, and a running process with graceful termination or forced kill.
  • Added new unit tests for the connect method's error handling, verifying _terminate_proc is called on TimeoutExpiredError or pexpect exceptions.
  • Updated test_console_disconnect_terminated_child to align with the new _proc attribute and console_eof_sampler changes.
  • Updated test_console_eof_sampler_success and test_console_eof_sampler_no_sample to reflect _spawn_console as the internal retry function.
  • Introduced _single_attempt_sampler helper function for mocking TimeoutSampler behavior in tests.
  • Added pytest import for new test cases.
How this split maps your changes
  • Refactor branch (split-pr-21-1783401787-refactor): files classified as cleanup / mechanical work:
    • utilities/console.py
  • Main branch (split-pr-21-1783401787-main): files classified as feature / behavior work:
    • utilities/unittests/test_console.py

Merge order

Merge the refactor PR first if it touches shared files or would conflict with the main PR; then merge the main PR. Resolve conflicts in the usual way if both branches touch the same lines.

Refactor PR: #33

@RoniKishner

Copy link
Copy Markdown
Owner

@pull-apart /close

@RoniKishner RoniKishner closed this Jul 7, 2026
@RoniKishner RoniKishner deleted the split-pr-21-1783401787-main branch July 7, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant