Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Nov 20, 2026
zlareb1
force-pushed
the
fix/cell-close-cleanup-clock
branch
from
November 20, 2026 23:08
eb0200c to
24feba9
Compare
This was referenced Nov 20, 2026
Keep the blocked close, deadline observers and loop timers on one private clock. A controlled independent clock advance reproduces the elapsed-time dependency while the original cleanup and refusal assertions stay intact. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 57327d5) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
fix/cell-close-cleanup-clock
branch
from
November 21, 2026 00:08
24feba9 to
721f3ee
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1076
Related: #1041
Changelog category
Changelog entry
Not required.
Why
The cleanup allowance test uses a real monotonic stopwatch around an inert connection close that intentionally never finishes. A scheduler delay can spend that stopwatch's budget independently of the cleanup protocol. A controlled advance in the independent monotonic clock reproduces this dependency.
The hosted failure measured about 159 ms against its 150 ms bound. The cause of that particular overrun remains unknown. This change fixes the independently reproduced clock dependency.
Scope and risk
Replicated-erasure lease provisioning and its unit regression controls are on main. This branch preserves them unchanged. No production lease or erasure rule changes. The person-query recorder selects decision-tagged reads and retains unbounded-read negative controls.
The cleanup unit-test file and two person-query fixture/regression files change. Only the cleanup allowance case and its clock controls use a private function loop. Its loop, cleanup owner, connection-close budget and elapsed-time assertion share one clock that advances during selector waits. The test measures elapsed idle time during the bounded cleanup protocol. Fixture teardown drains and rejects newly pending tasks.
Every existing test body, assertion and deadline value is retained, including the 30 ms cleanup allowance and 150 ms elapsed bound. A control checks that the blocked close still expires after 30 ms. The other cases keep their existing loop scopes. Production code and shared test helpers are unchanged.
Compatibility, rollout and rollback
Tests
This head matches the exact three-way composition of the preceding qualified source and current main. The erasure fixture and its canonical unit regression module are inherited from main. On this composed head, all three erasure unit cases, scoped Ruff, Python formatting, committed-range whitespace and public-body prose checks pass. Full required hosted CI and a fresh independent whole review remain required for this exact head.
Earlier feature qualification
The following feature-specific results were recorded before this composition. They are prior-source receipts, not new tests of this composed head.
LOOM_ENV_FILE= .venv/bin/python -m pytest -q tests/unit/test_cell_attach_cleanup.py: nine passed.AI assistance in the code
AI-generated: Codex wrote the fixture and controls, then checked deadline coherence, retained assertions and task cleanup.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist