Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zlareb1
force-pushed
the
fix/digest-source-authority-fence
branch
3 times, most recently
from
November 20, 2026 23:46
0d742b6 to
e563599
Compare
A parked source publication can leave an obsolete digest searchable. Require exact-key authority metadata and content proof before a projected source can validate its digest. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 57327d5) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Exercise each default-field refusal and JSON numeric distinction before consolidating repeated default comparisons. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 73ef63b) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit cb594d0) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep every default-field and JSON type check while avoiding a separate encoder setup for each field. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 0bfc712) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit a94d2f9) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the blocked close, deadline observers and loop timers on one private clock. A controlled independent clock advance reproduces the elapsed-time dependency while the original cleanup and refusal assertions stay intact. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 4b03db4) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
fix/digest-source-authority-fence
branch
from
November 21, 2026 00:02
e563599 to
f9ba955
Compare
3 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1087
Related: #1041
Related: #1056
Related: #1077
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
Session digests withhold facts whose authoritative sources changed before their search projections caught up.
Why
A source can be deleted, rewritten, rejected or restricted after its projection was admitted for search. Checking that projection alone can still serve a digest derived from the obsolete source. The digest leg reads each exact source key from Postgres after reading its projection, and requires matching version, content hash and serving metadata. Missing or unreadable authority never falls back to the projection.
Scope and risk
Native FixedString content hashes pass through the existing hash-to-text conversion before projection and authority state are compared. The authority hash must still be valid; changed, empty, padded-empty, nonhex and invalid UTF-8 hashes cannot validate a digest.
The read selects source metadata without copying source values. Every lookup includes org, namespace, agent, user and session. Sources without valid content hashes withhold their digests under Postgres authority. Digests without fact lineage remain transcript evidence. Redacted projected sources cannot validate digests. The analyzer corpus drives known-source checks for current reads and both replay bases. The journal-read inventory classifies this serving filter as sending no rows to ClickHouse. The person-query prerequisite scopes observations to the authorization decision task. The replicated erasure lease fixture is already present on main; its unit controls are now on main with the existing Keeper path. The default-comparison prerequisite computes the canonical mapping once. The cleanup fixture uses one private idle clock for the real owner and connection-close budgets. Deadline values, refusal controls and behavior assertions remain unchanged. No erasure fixture DDL change is included.
Compatibility, rollout and rollback
Tests
The native-byte regression initially fails both matching bytes and bytearray cases while all five refusal controls pass. After hash normalization, the identical seven-case command passes. Existing text-hash, identity and lifecycle controls remain unchanged.
pytest tests/unit/test_summary_source_authority.py tests/unit/test_summary_sources.py tests/unit/test_summary_leg_links.py tests/unit/test_summary_leg_as_of.py tests/unit/test_session_summary_retrieval.py -q: 43 passed, including 22 authority cases.AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated (an agent wrote most of the diff): Codex; checked source authority, tenant scope, sparse defaults, failure behavior and regression evidence.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist
The prerequisite cases comprise 47 default-comparison, 10 person-query observation, 3 erasure-fixture, 9 cleanup. Fresh independent whole review and complete hosted CI are required for this head.