Repository navigation
Conversation
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1071
Changelog category
Changelog entry
Not required.
Why
A failed retrieval-floor ingestion assertion prints only the input filename. Its retained logs lack the persisted status needed to distinguish a scheduled retry from a revision conflict. The historical cause remains unknown.
Read fixed status fields after the original readiness assertion fails. Keep the single ingestion attempt and fail that assertion.
Scope and risk
Two test files change. A failed single ingestion pass performs one same-scope status lookup, bounded to one second. Only whitelisted state, stage and error-code values and a bounded integer attempt count are printed. Stored error messages, source content and identifiers are excluded. Missing or unavailable observations use fixed labels.
The ready path performs no diagnostic lookup. No ingestion retry, readiness exception, retrieval floor, workload, query order, production source or CI gate changes.
Compatibility, rollout and rollback
Tests
Eight focused cases pass, including the ready path, unsafe fields, a failed observation and a genuinely blocked lookup. Six status cases fail before the context is added; the blocked lookup fails before the diagnostic bound is added. All eight original assertions, the retrieval test body and corpus constants remain.
Scoped Ruff, formatting, public-body prose and whitespace checks pass. Full exact-head hosted CI and a fresh independent whole review remain required. This change collects evidence and claims no ingestion root-cause fix.
AI assistance in the code
AI-generated: Codex wrote the fixture diagnostic and controlled regressions.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist