Skip to content

Report bounded status after fixture ingestion fails - #1096

Open
zlareb1 wants to merge 1 commit into
mainfrom
test/ingestion-failure-context
Open

zlareb1 wants to merge 1 commit into
mainfrom
test/ingestion-failure-context

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 21, 2026

Copy link
Copy Markdown
Member

Related: #1071

Changelog category

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry

Not required.

Why

A failed retrieval-floor ingestion assertion prints only the input filename. Its retained logs lack the persisted status needed to distinguish a scheduled retry from a revision conflict. The historical cause remains unknown.

Read fixed status fields after the original readiness assertion fails. Keep the single ingestion attempt and fail that assertion.

Scope and risk

Two test files change. A failed single ingestion pass performs one same-scope status lookup, bounded to one second. Only whitelisted state, stage and error-code values and a bounded integer attempt count are printed. Stored error messages, source content and identifiers are excluded. Missing or unavailable observations use fixed labels.

The ready path performs no diagnostic lookup. No ingestion retry, readiness exception, retrieval floor, workload, query order, production source or CI gate changes.

Compatibility, rollout and rollback

  • Wire and operator steps: none.
  • Rollback: revert the test-only diagnostic.

Tests

Eight focused cases pass, including the ready path, unsafe fields, a failed observation and a genuinely blocked lookup. Six status cases fail before the context is added; the blocked lookup fails before the diagnostic bound is added. All eight original assertions, the retrieval test body and corpus constants remain.

Scoped Ruff, formatting, public-body prose and whitespace checks pass. Full exact-head hosted CI and a fresh independent whole review remain required. This change collects evidence and claims no ingestion root-cause fix.

AI assistance in the code

  • AI-generated: Codex wrote the fixture diagnostic and controlled regressions.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Commits are signed off.
  • No generated interface, migration, setting or operator step changes.
  • Full exact-head hosted CI passes.
  • Fresh independent whole review has no unresolved findings or nits.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 21, 2026 1:02am UTC

Request Review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant