Repository navigation
Conversation
4 of 5 tasks
zlareb1
force-pushed
the
fix/cell-provenance-phase-evidence
branch
from
November 20, 2026 23:06
247b780 to
2de349e
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 of 5 tasks
An interrupted proof needs its last observed page and validation phase. Numeric checkpoints retain that evidence while preserving proof checks, deadlines and the original failure. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit f43e6d1) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Bound HTTP helper timings to the existing six request samples so acceptance failures retain evidence for work outside named spans. Preserve delegation, failure identity and the original workload and limits. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit fc936c8) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Exercise each default-field refusal and JSON numeric distinction before consolidating repeated default comparisons. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 73ef63b) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep every default-field and JSON type check while avoiding a separate encoder setup for each field. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 0bfc712) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 57327d5) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the blocked close, deadline observers and loop timers on one private clock. A controlled independent clock advance reproduces the elapsed-time dependency while the original cleanup and refusal assertions stay intact. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 4b03db4) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
fix/cell-provenance-phase-evidence
branch
from
November 21, 2026 00:08
2de349e to
9765f69
Compare
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 4a183d8) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1041
Related: #1072
Related: #1077
Related: #1087
Related: #1091
Changelog category
Changelog entry
Not required.
Why
An interrupted Cell provenance proof needs its last observed page and validation phase. Bounded numeric checkpoints retain that evidence beside the acceptance result. Selected HTTP helper timings show request work at the existing sample boundaries.
Scope and risk
The harness exports bounded provenance progress, observed remaining work budget and request-phase timings. Only the existing six sampled requests receive the nine HTTP boundary observations. Wrappers preserve arguments, return values, cancellation and error identity, and restore helpers after startup failure or completion. Records contain numeric checkpoints and hashed query tags.
The proof-default comparison uses the related canonical-mapping correction to bound encoder setup while retaining every field and JSON type check.
Qualification controls exercise the isolated replicated-erasure lease table already on main, decision-tag filtering for the SCIM query recorder and a private cleanup clock. Missing-lease refusal, unbounded-query negative controls, original cleanup deadlines and original assertions are retained. The existing lease-table fixture remains unchanged.
The graph-stats cancellation fixture includes the related private idle-clock correction. Its original pass deadline, signal watchdog, post-cancellation waits, statement-count freeze and test bodies remain intact. Pure graph calculations use their original functions through the fixture's inline thread seam; this fixture does not qualify real executor or wall-clock latency.
Workload, pages, resource census, global deadlines, latency and throughput bounds are retained. Latency, throughput and complete acceptance require hosted validation.
Compatibility, rollout and rollback
Tests
On this composed head, all 67 directly related graph-stats, provenance-progress and request-phase cases pass in 2.38 seconds. Scoped Ruff, Python formatting and whitespace checks pass; public-body prose is checked before publication. Full exact-head hosted CI and a fresh independent whole review remain required. The earlier hosted graph-fixture failure stays recorded; its particular scheduling cause was not identified.
Earlier feature qualification
The following feature-specific results were recorded before this composition. They are prior-source receipts, not new tests of this composed head.
LOOM_ENV_FILE= .venv/bin/python -m pytest -q tests/unit/test_cell_trigger_default_comparison.py tests/unit/test_scim_person_query_observation.py tests/unit/test_erasure_replicated_fixture.py tests/unit/test_cell_attach_cleanup.py tests/unit/test_cell_trigger_provenance_progress.py tests/unit/test_cell_trigger_request_phases.py: 112 passed in 3.50 seconds.AI assistance in the code
AI-generated: Codex wrote the changes and controls, then checked bounded encoding and diagnostics, refusal paths, retained assertions and task cleanup.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist