Skip to content

Bound JSON encoder setup in Cell proof checks - #1041

Open
zlareb1 wants to merge 4 commits into
mainfrom
fix/cell-proof-default-comparison
Open

zlareb1 wants to merge 4 commits into
mainfrom
fix/cell-proof-default-comparison

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Related: #1072
Related: #1077
Related: #1087

Changelog category

  • CI Fix or Improvement

Changelog entry

Not required.

Why

The page proof compares default values on every row. Repeatedly constructing an encoder for individual fields adds work to each comparison. Compare one canonical mapping while retaining exact JSON representations and every default-field refusal.

Scope and risk

The capture helper compares the default fields in one canonical mapping. Regression cases cover every altered default, numeric type distinctions and the number of encoder setups. The page proof, default values and validation rules are retained.

Qualification controls exercise the isolated replicated-erasure lease table already on main, decision-tag filtering for the SCIM query recorder and a private cleanup clock. Missing-lease refusal, unbounded-query negative controls, original cleanup deadlines and original assertions are retained. The existing lease-table fixture remains unchanged.

Workload, pages, resource census, global deadlines, latency and throughput bounds are retained. Latency, throughput and complete acceptance require hosted validation.

Compatibility, rollout and rollback

  • Wire, production server behavior, schema, settings and operator steps: none.
  • Rollback: revert the harness and fixture changes. No persisted server data changes.

Tests

This head matches the exact three-way composition of the preceding qualified source and current main. The erasure fixture and its canonical unit regression module are inherited from main. On this composed head, all three erasure unit cases, scoped Ruff, Python formatting, committed-range whitespace and public-body prose checks pass. Full required hosted CI and a fresh independent whole review remain required for this exact head.

env LOOM_ENV_FILE= .venv/bin/python -m pytest tests/unit/test_erasure_replicated_fixture.py -q

Earlier feature qualification

The following feature-specific results were recorded before this composition. They are prior-source receipts, not new tests of this composed head.

  • LOOM_ENV_FILE= .venv/bin/python -m pytest -q tests/unit/test_cell_trigger_default_comparison.py tests/unit/test_scim_person_query_observation.py tests/unit/test_erasure_replicated_fixture.py tests/unit/test_cell_attach_cleanup.py: 69 passed in 2.33 seconds.
  • Scoped Ruff lint and format, component-source parity, original cleanup-test body preservation and diff whitespace checks pass.
  • Full exact-head hosted CI, including Cell acceptance and real replicated erasure behavior, must pass before merge.

AI assistance in the code

  • AI-generated: Codex wrote the changes and controls, then checked bounded encoding and diagnostics, refusal paths, retained assertions and task cleanup.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Acceptance thresholds, workload and deadlines are retained.
  • No production source, generated interfaces, migrations or operator settings change.
  • Commits are signed off.
  • Full exact-head GitHub CI passes.

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 21, 2026 12:10am UTC

Request Review

Exercise each default-field refusal and JSON numeric distinction before consolidating repeated default comparisons.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 73ef63b)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep every default-field and JSON type check while avoiding a separate encoder setup for each field.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 0bfc712)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 57327d5)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the blocked close, deadline observers and loop timers on one private
clock. A controlled independent clock advance reproduces the elapsed-time
dependency while the original cleanup and refusal assertions stay intact.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 4b03db4)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 force-pushed the fix/cell-proof-default-comparison branch from 49ab94f to 9d57ebb Compare November 21, 2026 00:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant