Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zlareb1
marked this pull request as ready for review
November 20, 2026 13:29
6 of 7 tasks
zlareb1
force-pushed
the
fix/cell-proof-default-comparison
branch
from
November 20, 2026 22:03
26253c9 to
a94d2f9
Compare
4 of 5 tasks
zlareb1
force-pushed
the
fix/cell-proof-default-comparison
branch
from
November 20, 2026 23:05
a94d2f9 to
49ab94f
Compare
This was referenced Nov 20, 2026
Exercise each default-field refusal and JSON numeric distinction before consolidating repeated default comparisons. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 73ef63b) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep every default-field and JSON type check while avoiding a separate encoder setup for each field. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 0bfc712) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 57327d5) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the blocked close, deadline observers and loop timers on one private clock. A controlled independent clock advance reproduces the elapsed-time dependency while the original cleanup and refusal assertions stay intact. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 4b03db4) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
fix/cell-proof-default-comparison
branch
from
November 21, 2026 00:08
49ab94f to
9d57ebb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1072
Related: #1077
Related: #1087
Changelog category
Changelog entry
Not required.
Why
The page proof compares default values on every row. Repeatedly constructing an encoder for individual fields adds work to each comparison. Compare one canonical mapping while retaining exact JSON representations and every default-field refusal.
Scope and risk
The capture helper compares the default fields in one canonical mapping. Regression cases cover every altered default, numeric type distinctions and the number of encoder setups. The page proof, default values and validation rules are retained.
Qualification controls exercise the isolated replicated-erasure lease table already on main, decision-tag filtering for the SCIM query recorder and a private cleanup clock. Missing-lease refusal, unbounded-query negative controls, original cleanup deadlines and original assertions are retained. The existing lease-table fixture remains unchanged.
Workload, pages, resource census, global deadlines, latency and throughput bounds are retained. Latency, throughput and complete acceptance require hosted validation.
Compatibility, rollout and rollback
Tests
This head matches the exact three-way composition of the preceding qualified source and current main. The erasure fixture and its canonical unit regression module are inherited from main. On this composed head, all three erasure unit cases, scoped Ruff, Python formatting, committed-range whitespace and public-body prose checks pass. Full required hosted CI and a fresh independent whole review remain required for this exact head.
Earlier feature qualification
The following feature-specific results were recorded before this composition. They are prior-source receipts, not new tests of this composed head.
LOOM_ENV_FILE= .venv/bin/python -m pytest -q tests/unit/test_cell_trigger_default_comparison.py tests/unit/test_scim_person_query_observation.py tests/unit/test_erasure_replicated_fixture.py tests/unit/test_cell_attach_cleanup.py: 69 passed in 2.33 seconds.AI assistance in the code
AI-generated: Codex wrote the changes and controls, then checked bounded encoding and diagnostics, refusal paths, retained assertions and task cleanup.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist