Repository navigation
Conversation
zlareb1
force-pushed
the
feat/native-loom-assistant
branch
5 times, most recently
from
November 20, 2026 08:19
51cc243 to
4ef7d6c
Compare
4 of 5 tasks
zlareb1
force-pushed
the
feat/native-loom-assistant
branch
3 times, most recently
from
November 20, 2026 11:27
f486829 to
b91a612
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zlareb1
force-pushed
the
feat/native-loom-assistant
branch
6 times, most recently
from
November 20, 2026 23:46
69e6674 to
ca2b113
Compare
Own bounded streaming model turns and authenticated MCP tools in the web process. Validate citations against answer receipts and capture usage before completion. Retain external state and provisioning metadata for an approved cutover. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Streaming requests share endpoint resolution, credential refresh and private header filtering with the provider transport. Cancellation joins pending signing before the producer exits. Reuse the deployment region setting and regenerate its settings artifacts. Verify native enablement with serving TLS. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Whole replies retain nested source-access proofs through required accounting and response delivery. Citations use returned help anchors, and native configuration failures remain visible in the dashboard. Retained provisioning credentials keep their rotation coverage while replaced polling paths are removed. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Route fixtures bind the answer-owned MCP app. Protected ledger fixtures exercise the pure support rule with all authorization and marked-outcome expectations kept. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep authorization, revocation and whole-response publication assertions on the provisioning-aware credential boundary used by the served routes. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Remove unused persisted-answer query code and preserve receipt-based support assertions. Cover configuration admission and model-alias pricing, correct configuration documentation and bounds, and align the disabled chat fixture with the native refusal contract. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep persisted query metadata separate from citation verification and remove unused support fixtures after the polling path is retired. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep step labels and protected-row rules in the shared formatter. Retain the local-model routing and container networking guidance alongside assistant setup. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Regenerate the published setup destinations when the English guide is replaced. Keep the translated text and source stamps for the translation updater. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Create converted archives exclusively with owner-only permissions and keep credential resealing statements inside the retained provisioning lease. Remove unused ticket and accounting state and obsolete test seams. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep nested tool publication guards through final accounting and refuse citations to unread help outline sections. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Exercise access changes during model generation and an awaited send while preserving final accounting and stream cleanup. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Share retained source proofs with the HTTP request tail while keeping streamed accounting open until its terminal event. The new source-loss regressions reproduce unchecked private content before this repair. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 6debd25)
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 7cd6fe5) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Exercise real admission and response accounting through source activation, marked refusal, failed private delivery and repeated provider cancellation. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit d667581) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit f93385b) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit a6d8a12) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Exercise each default-field refusal and JSON numeric distinction before consolidating repeated default comparisons. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 73ef63b) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit cb594d0) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep every default-field and JSON type check while avoiding a separate encoder setup for each field. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 0bfc712) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit a94d2f9) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the blocked close, deadline observers and loop timers on one private clock. A controlled independent clock advance reproduces the elapsed-time dependency while the original cleanup and refusal assertions stay intact. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 4b03db4) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Compose the reviewed retirement fixture clock so handler startup does not consume cancellation checks. Keep the original deadline and assertion bodies. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Code cards and skeletons retain original line bounds while withholding source. Require a complete unelided unit or file body with matching line bounds before verifying a code citation. Cover malformed and withheld spans while preserving full-source positives and other citation kinds. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
feat/native-loom-assistant
branch
from
November 21, 2026 00:04
ca2b113 to
77c4d34
Compare
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit a909dad) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1093
Related: #1087
Related: #1041
Related: #993
Related: #1072
Related: #1077
Related: #1081
Changelog category
Changelog entry
The assistant runs inside Loom with bounded model and tool execution. Configure its provider and model explicitly; the separate assistant service and database are no longer deployed.
Why
The assistant owns authentication, tools, citations and accounting. Running its model loop in the server removes separate runtime provisioning while retaining caller-bound authorization for every tool call.
Scope and risk
Native streaming adapters use the existing provider routes. Context and model-selected tools pass through authenticated MCP with answer-scoped viewer credentials, fixed caller identity and bounded reads. Delegation ceilings, revocation, mirrored-source admission, cancellation and accounting remain enforced. Whole and streamed responses retain source-access proofs through the response boundary; access loss withholds successful completion.
The dashboard reports explicit native configuration failures and retains refused drafts. HTTP chat,
assistant.askand SDK interfaces remain available. Help citations require returned text and matching anchors; code citations require returned source spans. Incomplete model usage keeps a labelled reservation rather than invented token counts.The change removes bundled assistant workloads and provisioning loops. Historical provisioning storage, erasure coverage and credential rotation remain. Rotation retains its lease-scoped statement deadline. The offline history converter uses explicit owner bindings and creates an exclusive owner-only file without opening a database or executing queued work.
Related renewal, placement and repository-expiry fixtures control simulated time through private per-case loops while preserving deadline values, behavior assertions and task cleanup. The session-end deadline repair is already present on main.
The person-query prerequisite scopes observations to the authorization decision task. The replicated erasure lease fixture is already present on main; its unit controls are now on main with the existing Keeper path. The default-comparison prerequisite computes the canonical mapping once. The cleanup fixture uses one private idle clock for the real owner and connection-close budgets. Deadline values, refusal controls and behavior assertions remain unchanged. No erasure fixture DDL change is included.
The grep fallback fixtures retain native output, exit status and deadline assertions. A child-only response fixture proves the received 401 and malformed-JSON paths independently of lazy HTTP startup; the real HTTP case still covers a server that exceeds the timeout. The original macOS failure does not establish a production defect. The exact reviewed test-only support change is included from #1093; no shipped plugin or version changes.
Compatibility, rollout and rollback
assistant_librechat_url,assistant_service_emailandassistant_setup_retry_s. Configureassistant_enabled,assistant_providerandassistant_model; an alias requires a verifiedassistant_price_model. Model steps, tools, context, result text and tokens are bounded. A zero answer ceiling refuses model calls. There is no provider fallback.docs/operations/assistant.md. Keep retired runtimes and queues stopped. Preserve database bytes, volumes, claims, backups and exports. Keep assistant traffic disabled across mixed serving builds, then verify an approved provider and caller-bound tools before enabling it. No automatic migration or deletion occurs.Tests
The generated documentation summary is refreshed after the provider architecture opening changes. Its existing exact-currentness regression fails before regeneration and passes afterward. The single-provider recipe explicitly routes the separately configured conflict judge.
Focused fake-provider regressions cover orchestration, authenticated tools, delegation, revocation, protected receipts, publication, provider routes, cancellation, limits and accounting. Source-access regressions cover loss during generation, accounting and awaited sends. Archive fixtures cover explicit owner bindings, private output and refusal to replace an existing file or symlink. Seven marked-answer cases exercise real native admission, refusal before model work, the source-activation ceiling, private event delivery before completion and repeated provider cancellation. Known usage and estimated reservations reach actual request accounting; failed private delivery withholds terminal success. Configuration, deployment definitions, citations and dashboard behavior have focused coverage. Translation URL regeneration preserves translated prose and source stamps. Provider setup and passive failure diagnostics include the reviewed documentation correction; the native assistant retains its separate credential and no-fallback contract.
Prior source qualification recorded 34 retirement-clock cases, 65 publication, archive, HTTP placement, authorization and documentation-currentness cases, and 69 prerequisite cases passing. The prior primary command was:
The integration map retains current integrations and removes the retired runtime entry. The placement-clock repair already present on main is preserved. Historical focused results do not qualify this composition. Full hosted CI, platform checks, builds, integration and mixed-version checks must pass on the new head. Live provider and serving-instance behavior remain separately unverified. No live model or benchmark was run for this change.
AI assistance in the code
Checklist
The prerequisite cases comprise 47 default-comparison, 10 person-query observation, 3 erasure-fixture, 9 cleanup. Fresh independent whole review and complete hosted CI are required for this head.
The retirement fixture uses its existing private loop clock, preserving the half-second handler-start and cancellation assertions. This composition addresses its wall-clock dependency; it does not establish the cause of the previous scheduler delay.
Code citations require complete returned source text with matching line bounds. Metadata-only cards, elided bodies, skeletons and malformed spans cannot verify a line they did not return. Focused controls cover both code lookup operations and preserve complete-source positives. Other citation kinds and authorization boundaries are unchanged.
The citation repair has 44 focused cases, with 28 failures against the original verifier and all 44 passing after the change. On the current composed head, the native assistant and help-citation modules pass 100 cases. The 65 primary, 69 prerequisite and 34 retirement results are retained prior-source receipts; their feature source files are preserved in the current-main composition. Scoped static receipts for the two citation files are also retained. AST comparison preserves all 34 existing test-function bodies and every other citation branch. An existing Starlette deprecation warning remains.
Fresh checks on this composition pass all 100 native assistant and help-citation cases and both selected grep fallback cases. Both JavaScript files pass syntax and Biome format checks. These local checks do not qualify the unrun hosted platform, build, integration or mixed-version gates. Full exact-head hosted CI and a fresh independent whole review remain required.