Repository navigation
Conversation
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
4 of 5 tasks
Preserve the RSS read-race fix and all resource tests while composing the independently landed shared HTTP fixture repair. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The integration fixture provisions the lease table used by fenced memory clearing. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #995
Changelog category (leave one):
Changelog entry
The Cell resource census repeats a complete process-tree observation after a verified descendant disappears during an RSS read. A failed status-file read cannot count as zero memory while the process identity remains present.
Why
A process can exit after its identity check and before its RSS status is read. ProcessLookupError from that read escapes the existing disappearance handler. FileNotFoundError becomes zero RSS, which can admit the sample while the identity remains present. Hosted regression tests reproduce both behaviors before this fix.
Scope and risk
Move the unchanged RSS read and limit check into the existing child-census handler. A fresh identity check must verify that a nonroot disappeared before the entire incomplete traversal is discarded. A fresh complete forest is required to renew the sample. Root loss, a present process whose status read failed, PID reuse, other I/O errors, excess RSS and stale observations refuse admission.
The existing three-attempt, three-second bound and all resource, workload, proof and statistical limits remain unchanged. The existing zero fallback after a successful status read with no VmRSS field is also unchanged; that separate parsing edge is outside this fix. Process cleanup and signaling are unchanged.
The independently landed placement-test repair is retained exactly from the adopted parent. Its private asynchronous clock, prepared inert transport, six cases, numeric limits and task-leak assertion remain. This PR now changes only the RSS reader, forest census and their resource tests. No production placement code changes here.
Compatibility, rollout and rollback
Tests
The preceding published head failed the two replicated-erasure integration cases because their isolated database lacked
_migration_lock; fenced memory writes could not read the lease holder. This head includes the landed fixture repair. All three RSS source and test images remain byte-identical to the preceding head. The failed cohort remains recorded. Fresh independent entire pushed-source review and all required hosted gates are pending for this composition; earlier results do not qualify it.AI assistance in the code
AI-generated: Codex prepared the diff. Independent source reviews and hosted regressions check the identity, full-forest and refusal requirements.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist