Fix timezone loss and time shifts in encrypted datetimes - #8
Merged
script3r merged 1 commit intoSep 5, 2026
Merged
Conversation
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
USE_TZ=True, encrypted datetimes stored by SQLite were decrypted as naive values because binary columns skip Django's datetime result converters. Re-saving a value under a non-UTC default timezone could shift the instant and break deterministic equality lookups.Restore the connection timezone after decrypting naive datetime representations. Already-aware values and
USE_TZ=Falseretain their behavior. Serialization is unchanged, so existing ciphertext and deterministic equality remain compatible without a data migration.Validation: 6 new cases failed before the fix. All 102 library tests and 6 example tests pass on Python 3.14 / Django 6.0 and Python 3.10 / Django 5.2 / Tink 1.13.0. Tests cover UTC and non-UTC database timezones, raw ciphertext, existing offset and naive representations,
values_list(), re-saves, and deterministic equality. Ruff lint/format and Pyright pass.Stack position: 2 of 6; depends on #7. Land #7 first, then retarget this PR to
mainif GitHub has not done so automatically. Database integration was tested with SQLite.Landing order: #7 → #8 → #9 → #10 → #11 → #12.
Full review and landing notes. Use merge commits to preserve stack ancestry; squash/rebase merges require rebasing the remaining stack before landing it.