Enforce resolved database options and remove implicit slug indexes - #11
Merged
script3r merged 1 commit intoSep 5, 2026
Merged
Conversation
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database-option checks only inspected keyword arguments. Positional
primary_key,unique,db_index, anddb_defaultarguments bypassed the restrictions, andEncryptedSlugField()silently inherited Django'sdb_index=Truedefault.Validate options after Django resolves arguments and defaults, and default randomized slug fields to
db_index=False. Supported deterministic indexes and uniqueness remain available, including positional arguments.Applications using encrypted slug fields should run
makemigrationsand apply the generated index-removal migration. Existing ciphertext is unchanged. Previously accepted positional configurations that violate the documented restrictions now fail during field construction.Validation: 6 initial regression cases failed before the fix; additional cases cover positional database defaults. All 130 library tests pass on Python 3.14 / Django 6.0, with the new constructor suite also passing on Python 3.10 / Django 5.2 / Tink 1.13.0. The 6 example tests pass. Tests inspect real database indexes and migration deconstruction/clone behavior. Ruff lint/format and Pyright pass.
Stack position: 5 of 6; depends on #10. Land predecessors first and retarget to
mainas needed.Landing order: #7 → #8 → #9 → #10 → #11 → #12.
Full review and landing notes. Use merge commits to preserve stack ancestry; squash/rebase merges require rebasing the remaining stack before landing it.