Land reviewed datetime, cache, binary, and field-option fixes - #13
Merged
Conversation
Modernize keyset loading and test the full support matrix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the already-reviewed datetime, cache, PostgreSQL binary, and field-option fixes into
main.PR #7 reached
main, but #8, #9, #10, and #11 were merged into their predecessor branches after those predecessors had already landed. Those four changes are therefore marked merged on GitHub but are not yet inmain. This integration PR contains their original four commits, without additional code changes:The original PRs passed CI. This PR runs CI against current
mainagain. Its tree has 130 library tests and 6 example integration tests. Existing ciphertext is unchanged except that already-corrupted PostgreSQL binary values require application-specific recovery. Encrypted slug users should generate and apply the index-removal migration.Current landing order: merge this PR into
main, then change #12's base tomainbefore merging #12. If this head branch is deleted after merging, verify that GitHub automatically retargeted #12. Use a merge commit to preserve ancestry; squash/rebase merging requires rebasing #12.Full review and rollout notes.