Fix plaintext lookup and transform bypasses on encrypted fields - #7
Merged
Conversation
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encrypted JSON key lookups, date transforms, and lookups registered after import bypassed the ciphertext restrictions. For example,
filter(payload__has_key="secret")generated JSON SQL against encrypted bytes. These operations now raiseFieldErrorwhen the query is constructed.Use an explicit lookup allowlist and two concrete equality classes instead of generating lookup subclasses from Django's registry at import time. Deterministic equality and SQL null handling retain their existing behavior. Custom registered lookups are intentionally rejected too.
Validation: 12 new regression cases failed before the fix; all 90 library tests and 6 example integration tests pass on Python 3.14 / Django 6.0. Ruff lint/format and Pyright pass. Regression coverage includes inherited transforms, projected JSON keys, late lookup registration, and raw SQL NULL storage.
Stack position: 1 of 6; base is
main. Land this before the remaining PRs in the stack.Landing order: #7 → #8 → #9 → #10 → #11 → #12.
Full review and landing notes. Use merge commits to preserve stack ancestry; squash/rebase merges require rebasing the remaining stack before landing it.