Skip to content

i18n(ja): restore text dropped by the translation pipeline#23315

Draft
yahonda wants to merge 11 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-mt-dropped-text
Draft

i18n(ja): restore text dropped by the translation pipeline#23315
yahonda wants to merge 11 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-mt-dropped-text

Conversation

@yahonda

@yahonda yahonda commented Jul 21, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

The machine-translation pipeline numbers inline elements (code spans, links) before translating and restores them afterwards. In many places it failed to restore one, leaving a bare digit where the text should be — and often shuffling the surrounding code spans as well. The English source is intact; only the Japanese is damaged.

EN: ... in which the `WHERE` clause is used to specify the databases and tables to be checked.
    If you want to check the replication status of all databases, remove the `WHERE` clause from the statement.
JA: ... 次のステートメントを実行します。3 句は、確認するデータベースとテーブルを指定します。
    ... ステートメントから`WHERE`句`WHERE`削除します。
->  ... 次のステートメントを実行します。`WHERE`句は、確認するデータベースとテーブルを指定します。
    ... ステートメントから`WHERE`句を削除します。

155 lines across 115 files. Two kinds of damage:

  1. Dropped text (127 lines). A digit stands where a code span or word belongs. Deleting the digit alone is not enough — the sentence loses its subject — so each line was reconstructed from the English source.
  2. Literal tool tokens (18 lines). Strings such as {{B-PLACEHOLDER-2-PLACEHOLDER-E}} leaked into the published text. The English source contains zero occurrences of "PLACEHOLDER", so all of it is garbage.

Several instances were losing technical information outright:

file was now
runtime-filter.md 効率はANALYZE %向上します 効率は 50 %向上します(50 was gone)
as-of-timestamp.md NOW(3)秒単位で取得 ミリ秒単位で取得(wrong precision)
grafana-pd-dashboard.md (P99) 100msである必要があります 100ms未満である必要があります(「未満」was gone)
develop/dev-guide-sql-development-specification.md INの数は300でなければなりません 300未満でなければなりません
pd-control.md ×2 2 に設定すると falseに設定すると(the value was gone)

How it was checked

Every line was cross-checked against release-8.5 before editing. Mechanical verification after editing:

  • link targets: 0 added, removed or altered;
  • code spans: 0 invented — every code span introduced exists verbatim in the English source file;
  • doubled particles (をを/はは/がが/にに/でで/、、/。。): no increase over the base;
  • grep -r PLACEHOLDER: 0 remaining.

Scope note

This PR covers the artifacts that follow a sentence-ending . A wider sweep suggests roughly 1,600 further bare-digit sites across ~550 files that still need the same treatment; those are left for follow-up PRs. Note that sweep mixes in genuine numbers (「12 テーブル」, 「0 に設定すると」), so each hit needs an English cross-check before editing.

This damage predates the current translation tooling, which has since been replaced, so it is a finite backlog rather than something that regenerates on each sync.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e4037f40-1b4d-4587-9cb4-51239b714079

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/develop This PR relates to the area of TiDB App development. labels Jul 21, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yahonda
yahonda force-pushed the i18n-ja-fix-mt-dropped-text branch from 4c1e066 to 022ea3e Compare July 21, 2026 05:34
@yahonda
yahonda force-pushed the i18n-ja-fix-mt-dropped-text branch from 022ea3e to bc7fb1a Compare July 21, 2026 06:03
@yahonda
yahonda force-pushed the i18n-ja-fix-mt-dropped-text branch from bc7fb1a to 8549433 Compare July 21, 2026 06:33
@yahonda
yahonda force-pushed the i18n-ja-fix-mt-dropped-text branch from 8549433 to 7427a2a Compare July 21, 2026 07:08
yahonda added a commit to yahonda/docs that referenced this pull request Jul 21, 2026
Follow-up to pingcap#23315, covering the bare-digit artifacts outside the subset that PR
handled — including the form with no space after the digit (`。1パラメータ`), which
the earlier detection regex missed entirely.

The old MT pipeline numbered inline elements before translating and sometimes failed
to restore one, leaving a digit where the text belongs and shuffling the neighbouring
code spans. Each site was reconstructed from the English source on release-8.5.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@yahonda
yahonda force-pushed the i18n-ja-fix-mt-dropped-text branch from 7427a2a to 13d72e7 Compare July 21, 2026 09:07
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants