i18n(ja): restore particles dropped before nouns and copulas#23322
i18n(ja): restore particles dropped before nouns and copulas#23322yahonda wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The old MT pipeline also dropped the particle between a code span (or link) and a following noun or copula, not just before verbs. The right particle depends on the relation, which the English settles: EN "the value of `X`" -> `X`の値 EN "If `header` is `false`" -> `header`が`false`の場合 Compound nouns that need no particle (`TIMESTAMP`値 = "TIMESTAMP values", `WHERE`句, `X`テーブル) were left alone. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2b7d68b to
d1e6a95
Compare
What is changed, added or deleted? (Required)
Companion to #23318. That PR restored the particle between a code span and a following verb; the same pipeline also dropped it before a following noun or copula, which this PR covers.
211 lines across 138 files. Particle distribution: の 197, が 31, を 27, は 22, で 16, に 10.
の dominates, but a quarter of the sites need something else, decided from the English each time:
`strict-picking-store`は…— EN "strict-picking-storecontrols…" (topic)`select`で場合によっては誤った結果が返される— で rather than が, because the clause already carries 結果が`NULL`になります— the copula had lost にAlso fixed on the same lines
About 25 lines were scrambled, not merely missing a particle, and were repaired against the English. Two changed the meaning:
dm/dm-error-handling.mdmax_allowed_packetではなく64Mですmax_allowed_packetのデフォルト値は64Mですliteral-values.md'20170824''2017-08-24'いずれか20170824日付として解釈します'20170824'、'2017-08-24'、20170824のいずれかが日付として解釈されますHow it was checked
Every site read against
release-8.5before editing. 27 candidates were skipped as already correct — the detection regex is coarse, and these turned out to be compound nouns that take no particle (`TIMESTAMP`値= EN "TIMESTAMP values",`Segment Split`中,`WHERE`句) or lines whose link text already ends in a plain-form verb ([接続する](…)場合).Mechanical verification of the result:
Left for a follow-up
A few sites cannot be fixed by inserting a particle:
optimizer-hints.md— EN "is used for Resource Control to isolate resources" was rendered 代わりに ("instead of"), inverting the meaning. Needs a reword.tidb-cloud/tidb-cloud-dm-precheck-and-troubleshooting.md,changefeed-sink-to-mysql.md— the defect is inside the link text (…移行します+ときに), which must stay byte-identical.releases/release-7.3.0.md— the correct fix collapses a duplicated link and code span into one, which the span-preservation rule forbids.Relationship to the sibling PRs
Developed on top of the other open ja PRs and harmonized with them: all fifteen merge cleanly in any order (verified — 105 pairwise merges, 0 conflicts).
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?