Skip to content

i18n(ja): restore the pre_split_regions heading so its anchor resolves#23324

Draft
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-presplit-anchor
Draft

i18n(ja): restore the pre_split_regions heading so its anchor resolves#23324
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-presplit-anchor

Conversation

@yahonda

@yahonda yahonda commented Jul 21, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

All nine ja links to #pre_split_regions are currently dead.

The English heading is the identifier itself:

EN: ## pre_split_regions
JA: ## 分割前リージョン {#pre-split-regions}

Translating the heading changed the anchor from pre_split_regions to pre-split-regions, while every link in the ja docs still points at #pre_split_regions. Restoring the identifier as the heading text — and pinning the anchor explicitly — fixes all nine at once.

分割前 was also a mistranslation of the feature: PRE_SPLIT_REGIONS splits the Regions in advance, whereas 「分割前の」 reads as "before splitting".

The same PR also aligns one link's text with its eight siblings:

-[分割前のリージョン](/sql-statements/sql-statement-split-region.md#pre_split_regions)
+[`PRE_SPLIT_REGIONS`](/sql-statements/sql-statement-split-region.md#pre_split_regions)

Seven of the nine links already read [`PRE_SPLIT_REGIONS`]; this was the only one rendered as prose.

How it was checked

  • Confirmed #pre_split_regions does not exist as an anchor anywhere in the ja file, while nine links target it.
  • After the fix, every sql-statement-split-region.md#… link in the ja docs resolves to a heading that exists.
  • The sub-heading ### pre_split_regionsの例 {#examples-of-pre-split-regions} was left untouched — nothing links to it, so changing it would be churn.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

The English heading is the identifier itself (`## pre_split_regions`). Translating it
to 「分割前リージョン」 changed the generated anchor from `#pre_split_regions` to
`#pre-split-regions`, so all nine ja links pointing at `#pre_split_regions` were dead.
Restore the identifier as the heading text and pin the anchor.

「分割前」 was also a mistranslation: PRE_SPLIT means splitting the Regions in advance,
not "regions before splitting".

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2026
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b248fe8e-9c3e-43dd-b98f-d2e2f6636a80

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants