Skip to content

i18n(ja): restore particles dropped after code spans and links#23318

Draft
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-restore-particles-pr
Draft

i18n(ja): restore particles dropped after code spans and links#23318
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-restore-particles-pr

Conversation

@yahonda

@yahonda yahonda commented Jul 21, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

The old MT pipeline dropped the particle between a code span (or link) and the verb that governs it. The correct particle depends on grammatical voice, so every site was read against the English source rather than pattern-replaced:

EN: See [Manual collection](/x.md) for details.     -> [手動収集](/x.md)を参照してください
EN: `200 OK` is returned.                           -> `200 OK`が返されます      (passive: が, not を)
EN: You can safely use `KILL`.                      -> `KILL`を使用できます
EN: If no `project_id` is specified                 -> `project_id`が指定されていない

433 lines across 212 files. Particle distribution:

particle count when
319 active / transitive
139 passive され forms, and potentials whose subject is the code span
20 code span is the sentence topic
7 code span is a location or complement — e.g. "INFORMATION_SCHEMA.CLUSTER_HARDWARE might contain …" -> に…含まれている
の / で / も 6 genitive; agent of a passive ("the name that -n/--name specifies" -> ); correlative ("neither <version> nor --all" -> )

28% of the sites are not を. A mechanical insertion would have been wrong on those 112 lines — which is why #23272 deliberately excluded passive forms and left them for a pass like this one.

How it was checked

  • Every changed line differs from the original by inserted characters only — zero deletions, so every code span, link URL, list marker, table pipe and indentation is byte-identical. (13 lines also carry a sibling PR's fix, see below.)
  • Link targets: 0 added, removed or altered. Code-span multiset per line: unchanged.
  • No doubled particle (をを/はは/がが/にに/でで/をが/がを) introduced.
  • No line-ending (CRLF/LF) changes.

Not fixed

About a dozen flagged sites are damaged beyond a missing particle — the pipeline transposed or duplicated code spans, so no particle is correct. Examples: optimizer-hints.md (ヒントを already holds the accusative, so QB_NAME has no valid slot), br/br-checkpoint-restore.md (the br span is duplicated, giving two subjects), partition-pruning.md (the operator list is torn apart). These need rewording, not particle restoration, and are left for a follow-up.

Relationship to the sibling PRs

These fixes were developed on top of the other open ja PRs and then harmonized with them, so all thirteen merge cleanly in any order (verified: 78 pairwise merges, 0 conflicts). Where a line is shared or adjacent, every branch carries the same final text — which is why 13 lines here also contain a sibling PR's fix (a stray digit removed, a stranded }} dropped).

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/develop This PR relates to the area of TiDB App development. labels Jul 21, 2026
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6daea668-f2e6-454b-913a-250a0ccffcc9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jackysp for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yahonda
yahonda force-pushed the i18n-ja-restore-particles-pr branch from ca11335 to a73819e Compare July 21, 2026 06:33
@yahonda
yahonda force-pushed the i18n-ja-restore-particles-pr branch 2 times, most recently from 2b321d6 to f5b3208 Compare July 21, 2026 07:08
The old MT pipeline dropped the particle between a code span (or link) and the
verb that governs it. The correct particle depends on voice, which the English
source settles:

  EN "See [X](/x.md)"        -> [X](/x.md)を参照してください
  EN "`200 OK` is returned"  -> `200 OK`が返されます   (passive: が, not を)

Every site was read against release-8.5 before editing. Verified mechanically:
each changed line differs from the original by inserted particles only — zero
deletions, so every code span, link URL and markdown structure is byte-identical.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@yahonda
yahonda force-pushed the i18n-ja-restore-particles-pr branch from f5b3208 to 3a16df0 Compare July 21, 2026 08:30
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants