feat: route.meta page titles, booth tab mappings, SR-visible topbar title#52
Merged
Conversation
…itle - currentPageTitle now falls back to route.meta.title (fixes missing titles for Decks, Meta Decks, Deck Builder, ShelfGuide, designs) - DeckBuilder title shows the deck's name (from #30, without its unrelated SVG mutation) - TAB_FOR_ROUTE: BoothDisplay/BoothTable map to booth tab; Settings, Terms, ShelfGuide mapped (from #48, without its .value-removal regression) - Remove aria-hidden from .topbar-page (from #28): no aria-live route announcer exists in the codebase, so no duplicated screen-reader output; makes page context available to SR users
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
✅ |
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of the bot-PR cleanup: one
App.vuePR combining the accepted pieces of #38, #48, #30, and #28 — reimplemented clean from currentmain, without the regressions found in the original bot branches (.valueremoval on a const ref, SVG path mutations). Do not merge those bot branches.Changes
route.meta(from Refactor: Dynamic page titles from router metadata in App.vue #38):currentPageTitlenow falls back toroute.meta.titleinstead of a hardcoded name chain. Fixes missing topbar titles for Decks, Meta Decks, Deck Builder, Shelf Guide, and design-lab routes — every route inrouter/index.jsalready declaresmeta.title. The Portfolio special case (shelf name) is preserved.useDeckStore. The unrelated one-character settings-gear SVG mutation in the original PR is excluded.BoothDisplayandBoothTablenow light the Booth tab;Settings,Terms,ShelfGuidemapped as well. The original PR'sshowNewPortfolioModal.value→ const-ref assignment regression (TypeError on shelf creation) is excluded.aria-hidden(from refactor: simplify page title logic and improve accessibility in App.vue #28): verified no aria-live route-change announcer exists in the codebase, so removingaria-hiddencannot duplicate screen-reader output — it makes current-page context available to SR users and exposes the mobile tour-replay button.Verification (per AGENTS.md)
eval:harness— ✅ all passedeval:danger— ✅ no danger-zone files touchedbuild— ✅ cleansmoke:browser—/booth/display🤖 Reimplemented by opencode from reviewed bot PRs