Skip to content

feat: route.meta page titles, booth tab mappings, SR-visible topbar title#52

Merged
poketonova merged 1 commit into
mainfrom
feat/phase-2-titles-and-tabs
Jul 18, 2026
Merged

feat: route.meta page titles, booth tab mappings, SR-visible topbar title#52
poketonova merged 1 commit into
mainfrom
feat/phase-2-titles-and-tabs

Conversation

@poketonova

Copy link
Copy Markdown
Collaborator

Summary

Phase 2 of the bot-PR cleanup: one App.vue PR combining the accepted pieces of #38, #48, #30, and #28 — reimplemented clean from current main, without the regressions found in the original bot branches (.value removal on a const ref, SVG path mutations). Do not merge those bot branches.

Changes

  • Page titles from route.meta (from Refactor: Dynamic page titles from router metadata in App.vue #38): currentPageTitle now falls back to route.meta.title instead of a hardcoded name chain. Fixes missing topbar titles for Decks, Meta Decks, Deck Builder, Shelf Guide, and design-lab routes — every route in router/index.js already declares meta.title. The Portfolio special case (shelf name) is preserved.
  • Deck-name title (from refactor: improve and unify top bar page title logic #30): Deck Builder shows the deck's name, falling back to "Deck Builder". Uses the existing useDeckStore. The unrelated one-character settings-gear SVG mutation in the original PR is excluded.
  • Booth tab mappings (from refactor: improve navigation tab mapping and page title logic #48): BoothDisplay and BoothTable now light the Booth tab; Settings, Terms, ShelfGuide mapped as well. The original PR's showNewPortfolioModal.value → const-ref assignment regression (TypeError on shelf creation) is excluded.
  • Topbar title no longer aria-hidden (from refactor: simplify page title logic and improve accessibility in App.vue #28): verified no aria-live route-change announcer exists in the codebase, so removing aria-hidden cannot duplicate screen-reader output — it makes current-page context available to SR users and exposes the mobile tour-replay button.

Verification (per AGENTS.md)

  • eval:harness — ✅ all passed
  • eval:danger — ✅ no danger-zone files touched
  • build — ✅ clean
  • smoke:browser⚠️ skipped locally (no Chrome in this environment); recommend a quick manual pass: check topbar title on Dashboard, a shelf, a deck, Booth Display, and tab highlighting on /booth/display

🤖 Reimplemented by opencode from reviewed bot PRs

…itle

- currentPageTitle now falls back to route.meta.title (fixes missing
  titles for Decks, Meta Decks, Deck Builder, ShelfGuide, designs)
- DeckBuilder title shows the deck's name (from #30, without its
  unrelated SVG mutation)
- TAB_FOR_ROUTE: BoothDisplay/BoothTable map to booth tab; Settings,
  Terms, ShelfGuide mapped (from #48, without its .value-removal
  regression)
- Remove aria-hidden from .topbar-page (from #28): no aria-live
  route announcer exists in the codebase, so no duplicated
  screen-reader output; makes page context available to SR users
@vercel

vercel Bot commented Jul 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pokemon-collectr Ready Ready Preview, Comment Jul 18, 2026 6:13pm

@poketonova

Copy link
Copy Markdown
Collaborator Author

smoke:browser now run against this branch (Chrome for Testing + Node 22 locally): all 12 checks pass — 8 desktop routes + 4 mobile-viewport routes, correct titles, no overflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants