refactor: improve and unify top bar page title logic#30
Closed
poketonova wants to merge 1 commit into
Closed
Conversation
- Use route.meta.title as the base for page titles to ensure consistency with browser tab titles. - Implement dynamic deck name in the top bar when using the Deck Builder. - Add support for missing route titles in the mobile top bar (Decks, Meta Decks, Shelf Guide).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
poketonova
added a commit
that referenced
this pull request
Jul 18, 2026
…itle (#52) - currentPageTitle now falls back to route.meta.title (fixes missing titles for Decks, Meta Decks, Deck Builder, ShelfGuide, designs) - DeckBuilder title shows the deck's name (from #30, without its unrelated SVG mutation) - TAB_FOR_ROUTE: BoothDisplay/BoothTable map to booth tab; Settings, Terms, ShelfGuide mapped (from #48, without its .value-removal regression) - Remove aria-hidden from .topbar-page (from #28): no aria-live route announcer exists in the codebase, so no duplicated screen-reader output; makes page context available to SR users Co-authored-by: novaoc <novaoc@users.noreply.github.com>
Collaborator
Author
|
Closing without merging. This branch contains an unrelated one-character mutation of the settings-gear SVG path data. The deck-name page title behavior was reimplemented cleanly in #52 (merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
currentPageTitlecomputed property inApp.vueto leverage themeta.titlealready defined in the router configuration.Pro Value:
if/elseblock and automatically supporting new routes that define ameta.title.Automated contribution by dev-agent.