refactor: simplify page title logic and improve accessibility in App.vue#28
Closed
poketonova wants to merge 1 commit into
Closed
refactor: simplify page title logic and improve accessibility in App.vue#28poketonova wants to merge 1 commit into
poketonova wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
poketonova
added a commit
that referenced
this pull request
Jul 18, 2026
…itle (#52) - currentPageTitle now falls back to route.meta.title (fixes missing titles for Decks, Meta Decks, Deck Builder, ShelfGuide, designs) - DeckBuilder title shows the deck's name (from #30, without its unrelated SVG mutation) - TAB_FOR_ROUTE: BoothDisplay/BoothTable map to booth tab; Settings, Terms, ShelfGuide mapped (from #48, without its .value-removal regression) - Remove aria-hidden from .topbar-page (from #28): no aria-live route announcer exists in the codebase, so no duplicated screen-reader output; makes page context available to SR users Co-authored-by: novaoc <novaoc@users.noreply.github.com>
Collaborator
Author
|
Closing without merging. This branch turns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
currentPageTitlecomputed property inApp.vueto leverage the router's metadata.Changes:
App.vue, the code now primarily usesroute.meta.title. This reduces code duplication and ensures that the UI title stays in sync with the document title defined in the router.aria-hidden="true"from the.topbar-pageelement. Since this element displays the current page title, it should be accessible to screen readers.ifstatements for static routes.This automated improvement enhances maintainability and accessibility of the tactile shell.