Repository navigation
Conversation
…ult-record-holds-resource # Conflicts: # src/generator/typescript.rs
moetemp
changed the title
moetemp
changed the title
moetemp
changed the title
# Conflicts: # advanced/samples/inputs/examples.toml
moetemp
changed the title
# Conflicts: # advanced/samples/inputs/examples.toml # src/generator/dotnet.rs # src/generator/python.rs # src/planning/mod.rs
moetemp
changed the base branch from
moe/up/ts-system-nexus-resource-return
to
moe/up/dotnet-resource-property-name
October 22, 2026 23:19
# Conflicts: # advanced/samples/inputs/examples.toml
# Conflicts: # advanced/samples/dotnet/wit/stream-service/Models.cs # advanced/samples/dotnet/wit/stream-service/Operations.cs # advanced/samples/dotnet/wit/stream-service/Services.cs # advanced/samples/inputs/examples.toml # src/generator/dotnet.rs # src/planning/mod.rs
moetemp
changed the base branch from
moe/up/dotnet-resource-property-name
to
moe/up/ts-system-nexus-resource-return
October 23, 2026 01:55
moetemp
force-pushed
the
moe/up/ts-system-nexus-resource-return
branch
from
October 23, 2026 04:18
4ec6f17 to
d9b9b23
Compare
# Conflicts: # advanced/samples/README.md # advanced/samples/dotnet/Nexgen.DotNetExamples.csproj # src/generator/typescript.rs
moetemp
changed the base branch from
moe/up/ts-system-nexus-resource-return
to
moe/up/sample-and-system-nexus
October 23, 2026 04:28
moetemp
changed the title
moetemp
changed the base branch from
moe/up/sample-and-system-nexus
to
moe/up/required-resource-result-field
October 23, 2026 06:08
This was referenced Oct 23, 2026
…esult-record-holds-resource
moetemp
added a commit
to temporalio/nexgen
that referenced
this pull request
Oct 23, 2026
) ## What changed? This PR adds a `stream-service` sample for Python and TypeScript, with today's output. #272 adds .NET with its fix. It has a `stream` resource built from a ref, `create-stream`, append, read, describe and close, with 64-bit offsets, payloads and durations. Its records are proto-backed, as a stream service's are. Upstream has no stream protos, so the sample has its own small proto in `descriptors/streamsample/v1/`, with checked-in bindings. The samples README has the commands that regenerate them. `build_examples` now loads every `*.bin` under `descriptors/`. ## Why? Later fixes show their effect as a golden diff on this sample. ## How did you test it? The goldens. A TypeScript test sends a full `ReadRecordsRequest` through the converter, so the TypeScript type file can't drift from the proto. ## What comes next These fixes are ready, in this order. Each one adds its shape to this sample, then the fix. - #272: adds .NET, where the `stream` field of the `Stream` class fails with CS0542, then the fix. - [moetemp#52](moetemp#52): Check required resource fields of a response. Adds `create-stream` returning the `stream` resource. - [moetemp#56](moetemp#56): Allow a result record to hold a resource. Adds a `create-stream-result` holder record. - [moetemp#53](moetemp#53): Emit `@nexus.doc` on resources and methods as Python docstrings. - [moetemp#70](moetemp#70): Convert 64-bit resource method values to `Long` for a proto request in TypeScript. Adds 64-bit method parameters. Needs #265. - [moetemp#54](moetemp#54): Generate a Python caller per service over a transport. Turns on the client for the sample. - [moetemp#55](moetemp#55): Add `@nexus.long-poll` to the Python caller. Marks `read-records` as a long poll. - [moetemp#57](moetemp#57): Add Python client classes for resources with methods. - [moetemp#71](moetemp#71): Drop the bare keyword marker from a Python signature with no parameters. Adds a `stream-writer` interface with no endpoint. - [moetemp#60](moetemp#60): Indent the docstrings of Python caller methods. Adds a doc on a writer operation. - [moetemp#69](moetemp#69): Import record types that an endpoint-less Python client uses in unpacked parameters. Adds `open-writer`. - [moetemp#72](moetemp#72): Plan proto unsigned integers as unsigned. Adds a `uint64` writer id. - [moetemp#73](moetemp#73): Build a returned proto-wire resource in an endpoint-less TypeScript client. Makes `open-writer` return the `writer` resource. #262 adds a `status` enum to the holder record once it merges.
Owner
Author
|
Upstreamed as temporalio#280. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR lets an operation return a proto-backed record that holds a resource in one
own<T>field, next to other fields of the same message.own<T>result does. The other fields come from the fields of the same name.any.Why?
A create often answers with a handle and with facts about the create, such as whether it made a new object. An
own<T>result alone drops those facts.How did you test it?
The
stream-servicesample'screate-streamreturnscreate-stream-result { stream, created }onCreateStreamResponse. The first commit has the shape, which fails to generate today, and the second commit has the output. Theworkflow-rungoldens cover the proto-backed case in four targets.Brook's
statusfield joinscreate-stream-resultonce the proto enum fix (upstream temporalio#262) lands.Based on fork PR #52.
Came from fork PR #45.