Repository navigation
test: add a stream-service sample with a resource built from a ref - #273
Merged
moetemp merged 0 commit intoOct 23, 2026
Merged
Conversation
This was referenced Oct 23, 2026
moetemp
force-pushed
the
moe/up/stream-service-sample
branch
from
October 23, 2026 04:35
888a889 to
a063930
Compare
moetemp
force-pushed
the
moe/up/dotnet-resource-property-name-2
branch
from
October 23, 2026 04:35
bad8742 to
5750cd4
Compare
moetemp
force-pushed
the
moe/up/dotnet-resource-property-name-2
branch
from
October 23, 2026 08:46
5750cd4 to
6758b6d
Compare
moetemp
force-pushed
the
moe/up/stream-service-sample
branch
from
October 23, 2026 08:46
a155a8a to
184dcd5
Compare
moetemp
force-pushed
the
moe/up/stream-service-sample
branch
from
October 23, 2026 08:54
184dcd5 to
e0b693b
Compare
moetemp
force-pushed
the
moe/up/dotnet-resource-property-name-2
branch
from
October 23, 2026 08:54
6758b6d to
c74a58d
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds a
stream-servicesample for Python, TypeScript and .NET, with today's output. It has astreamresource built from a ref,create-stream, append, read, describe and close, with 64-bit offsets, payloads and durations.Its records are proto-backed, as a stream service's are. Upstream has no stream protos, so the sample has its own small proto in
descriptors/streamsample/v1/, with checked-in bindings. The samples README has the commands that regenerate them.build_examplesnow loads every*.binunderdescriptors/.Why?
Later fixes show their effect as a golden diff on this sample.
How did you test it?
The goldens. A TypeScript test sends a full
ReadRecordsRequestthrough the converter, so the TypeScript type file can't drift from the proto.What comes next
These fixes are ready on our fork, in this order. Each one adds its shape to this sample, then the fix.
create-streamreturning thestreamresource.create-stream-resultholder record.@nexus.docon resources and methods as Python docstrings.Longfor a proto request in TypeScript. Adds 64-bit method parameters. Needs fix(wit): keep the size and sign of WIT integers #265.@nexus.long-pollto the Python caller. Marksread-recordsas a long poll.stream-writerinterface with no endpoint.open-writer.uint64writer id.open-writerreturn thewriterresource.#262 adds a
statusenum to the holder record once it merges.This PR is based on #272, since the
streamresource has astreamfield.